Qt: Fix drag-and-drop from packet list

Only initiate drag-and-drop when the left mousebutton has been
clicked, and also add the filter as plain text, so to enable
dragging to external applications.

Change-Id: I2f6ac7f9c543d003070c2a6c0ce671ed5a215669
Reviewed-on: https://code.wireshark.org/review/33620
Petri-Dish: Roland Knall <rknall@gmail.com>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>

1 files changed, 26 insertions, 21 deletions

diff --git a/ui/qt/packet_list.cpp b/ui/qt/packet_list.cpp
index 16e1538099..e8d0039717 100644
--- a/ui/qt/packet_list.cpp
+++ b/ui/qt/packet_list.cpp
@@ -651,30 +651,35 @@ void PacketList::mousePressEvent (QMouseEvent *event)
     setAutoScroll(false);
     QTreeView::mousePressEvent(event);
     setAutoScroll(true);
+}
 
-    QModelIndex curIndex = indexAt(event->pos());
-    ctx_column_ = curIndex.column();
-    QString filter = getFilterFromRowAndColumn();
-    if ( ! filter.isEmpty() )
+void PacketList::mouseMoveEvent (QMouseEvent *event)
+{
+    if ( event->buttons() & Qt::LeftButton )
     {
-        QString abbrev = filter.left(filter.indexOf(' '));
-        QString name = model()->headerData(ctx_column_, header()->orientation()).toString();
-
-        DisplayFilterMimeData * dfmd =
-                new DisplayFilterMimeData(name, abbrev, filter);
-        QDrag * drag = new QDrag(this);
-        drag->setMimeData(dfmd);
-
-        DragLabel * content = new DragLabel(dfmd->labelText(), this);
-        qreal dpr = window()->windowHandle()->devicePixelRatio();
-        QPixmap pixmap(content->size() * dpr);
-        pixmap.setDevicePixelRatio(dpr);
-        content->render(&pixmap);
-        drag->setPixmap(pixmap);
-
-        drag->exec(Qt::CopyAction);
+        QModelIndex curIndex = indexAt(event->pos());
+        ctx_column_ = curIndex.column();
+        QString filter = getFilterFromRowAndColumn();
+        if ( ! filter.isEmpty() )
+        {
+            QString abbrev = filter.left(filter.indexOf(' '));
+            QString name = model()->headerData(ctx_column_, header()->orientation()).toString();
+
+            DisplayFilterMimeData * dfmd =
+                    new DisplayFilterMimeData(name, abbrev, filter);
+            QDrag * drag = new QDrag(this);
+            drag->setMimeData(dfmd);
+
+            DragLabel * content = new DragLabel(dfmd->labelText(), this);
+            qreal dpr = window()->windowHandle()->devicePixelRatio();
+            QPixmap pixmap(content->size() * dpr);
+            pixmap.setDevicePixelRatio(dpr);
+            content->render(&pixmap);
+            drag->setPixmap(pixmap);
+
+            drag->exec(Qt::CopyAction);
+        }
     }
-
 }
 
 void PacketList::resizeEvent(QResizeEvent *event)