aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/models/expert_info_model.cpp
diff options
context:
space:
mode:
authorMichael Mann <mmann78@netscape.net>2017-12-16 10:03:55 -0500
committerMichael Mann <mmann78@netscape.net>2017-12-16 15:41:21 +0000
commit0b88544b07075741e6f89666867f0926c45fa419 (patch)
tree4d12ea6067a16260d8d9d90d3514e786a0d8d57f /ui/qt/models/expert_info_model.cpp
parent68668b785c73a1676ef4573290be7b50abb1c5a8 (diff)
Fix memory leaks in Expert Info dialog
Models and children weren't deleted which leaked memory all over the place. Change-Id: I961016b2501ad8cc8c75cf5fa5b0c86756a29382 Reviewed-on: https://code.wireshark.org/review/24858 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'ui/qt/models/expert_info_model.cpp')
-rw-r--r--ui/qt/models/expert_info_model.cpp11
1 files changed, 11 insertions, 0 deletions
diff --git a/ui/qt/models/expert_info_model.cpp b/ui/qt/models/expert_info_model.cpp
index 326a369290..5b34fbed5e 100644
--- a/ui/qt/models/expert_info_model.cpp
+++ b/ui/qt/models/expert_info_model.cpp
@@ -29,6 +29,12 @@ ExpertPacketItem::ExpertPacketItem(expert_info_t& expert_info, column_info *cinf
ExpertPacketItem::~ExpertPacketItem()
{
+ for (int row = 0; row < childItems_.count(); row++)
+ {
+ delete childItems_.value(row);
+ }
+
+ childItems_.clear();
}
QString ExpertPacketItem::groupKey(bool group_by_summary, int severity, int group, QString protocol, int expert_hf)
@@ -92,6 +98,11 @@ ExpertInfoModel::ExpertInfoModel(CaptureFile& capture_file, QObject *parent) :
{
}
+ExpertInfoModel::~ExpertInfoModel()
+{
+ delete root_;
+}
+
void ExpertInfoModel::clear()
{
emit beginResetModel();