diff options
author | Stig Bjørlykke <stig@bjorlykke.org> | 2019-11-17 20:02:20 +0100 |
---|---|---|
committer | Roland Knall <rknall@gmail.com> | 2019-11-17 20:43:10 +0000 |
commit | a51c58fa1b1605a6088d82baf832f4fd7df49a75 (patch) | |
tree | d2f4bc0bddebd7ccfb4ad072a5114005d190b41c /ui/qt/main_status_bar.cpp | |
parent | 1ddd30856d59b138861def6bff407f035c8babee (diff) |
Qt: Cleanup space inside parentheses
Remove randomly used space inside parentheses to make the coding
style uniform. Add space after if, for and while.
Change-Id: I519f5994b6f73d8a57a5004d51ca460276c618fe
Reviewed-on: https://code.wireshark.org/review/35112
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Diffstat (limited to 'ui/qt/main_status_bar.cpp')
-rw-r--r-- | ui/qt/main_status_bar.cpp | 60 |
1 files changed, 30 insertions, 30 deletions
diff --git a/ui/qt/main_status_bar.cpp b/ui/qt/main_status_bar.cpp index 5ca66d8cf1..955b6667d9 100644 --- a/ui/qt/main_status_bar.cpp +++ b/ui/qt/main_status_bar.cpp @@ -261,16 +261,16 @@ void MainStatusBar::selectedFieldChanged(FieldInformation * finfo) { QString item_info; - if ( ! finfo ) { + if (! finfo) { pushGenericStatus(STATUS_CTX_FIELD, item_info); return; } FieldInformation::HeaderInfo hInfo = finfo->headerInfo(); - if ( hInfo.isValid ) + if (hInfo.isValid) { - if ( hInfo.description.length() > 0 ) { + if (hInfo.description.length() > 0) { item_info.append(hInfo.description); } else { item_info.append(hInfo.name); @@ -279,7 +279,7 @@ void MainStatusBar::selectedFieldChanged(FieldInformation * finfo) if (!item_info.isEmpty()) { int finfo_length; - if ( hInfo.isValid ) + if (hInfo.isValid) item_info.append(" (" + hInfo.abbreviation + ")"); finfo_length = finfo->position().length + finfo->appendix().length; @@ -295,7 +295,7 @@ void MainStatusBar::highlightedFieldChanged(FieldInformation * finfo) { QString hint; - if ( finfo ) + if (finfo) { FieldInformation::Position pos = finfo->position(); QString field_str; @@ -317,20 +317,20 @@ void MainStatusBar::pushGenericStatus(StatusContext status, const QString &messa { LabelStack * stack = &info_status_; - if ( status == STATUS_CTX_MAIN ) + if (status == STATUS_CTX_MAIN) stack = &packet_status_; - if ( message.isEmpty() && status != STATUS_CTX_FILE && status != STATUS_CTX_TEMPORARY && status != STATUS_CTX_PROGRESS ) + if (message.isEmpty() && status != STATUS_CTX_FILE && status != STATUS_CTX_TEMPORARY && status != STATUS_CTX_PROGRESS) popGenericStatus(status); else stack->pushText(message, status); stack->setToolTip(messagetip); - if ( status == STATUS_CTX_FILTER || status == STATUS_CTX_FILE ) + if (status == STATUS_CTX_FILTER || status == STATUS_CTX_FILE) expertUpdate(); - if ( status == STATUS_CTX_PROGRESS ) + if (status == STATUS_CTX_PROGRESS) progress_frame_.showBusy(true, false, NULL); } @@ -338,14 +338,14 @@ void MainStatusBar::popGenericStatus(StatusContext status) { LabelStack * stack = &info_status_; - if ( status == STATUS_CTX_MAIN ) + if (status == STATUS_CTX_MAIN) stack = &packet_status_; stack->setToolTip(QString()); stack->popText(status); - if ( status == STATUS_CTX_PROGRESS ) + if (status == STATUS_CTX_PROGRESS) progress_frame_.hide(); } @@ -376,7 +376,7 @@ void MainStatusBar::showCaptureStatistics() QList<int> rows; MainWindow * mw = qobject_cast<MainWindow *>(wsApp->mainWindow()); - if ( mw ) + if (mw) rows = mw->selectedRows(true); #ifdef HAVE_LIBPCAP @@ -401,25 +401,25 @@ void MainStatusBar::showCaptureStatistics() .arg(cap_file_->displayed_count) .arg((100.0*cap_file_->displayed_count)/cap_file_->count, 0, 'f', 1) .arg(UTF8_MIDDLE_DOT)); - if(rows.count() > 1) { + if (rows.count() > 1) { packets_str.append(QString(tr(" %1 Selected: %2 (%3%)")) .arg(UTF8_MIDDLE_DOT) .arg(rows.count()) .arg((100.0*rows.count())/cap_file_->count, 0, 'f', 1)); } - if(cap_file_->marked_count > 0) { + if (cap_file_->marked_count > 0) { packets_str.append(QString(tr(" %1 Marked: %2 (%3%)")) .arg(UTF8_MIDDLE_DOT) .arg(cap_file_->marked_count) .arg((100.0*cap_file_->marked_count)/cap_file_->count, 0, 'f', 1)); } - if(cap_file_->drops_known) { + if (cap_file_->drops_known) { packets_str.append(QString(tr(" %1 Dropped: %2 (%3%)")) .arg(UTF8_MIDDLE_DOT) .arg(cap_file_->drops) .arg((100.0*cap_file_->drops)/cap_file_->count, 0, 'f', 1)); } - if(cap_file_->ignored_count > 0) { + if (cap_file_->ignored_count > 0) { packets_str.append(QString(tr(" %1 Ignored: %2 (%3%)")) .arg(UTF8_MIDDLE_DOT) .arg(cap_file_->ignored_count) @@ -430,7 +430,7 @@ void MainStatusBar::showCaptureStatistics() .arg(UTF8_MIDDLE_DOT) .arg(cap_file_->packet_comment_count)); } - if(prefs.gui_qt_show_file_load_time && !cap_file_->is_tempfile) { + if (prefs.gui_qt_show_file_load_time && !cap_file_->is_tempfile) { /* Loading an existing file */ gulong computed_elapsed = cf_get_computed_elapsed(cap_file_); packets_str.append(QString(tr(" %1 Load time: %2:%3.%4")) @@ -493,33 +493,33 @@ void MainStatusBar::showProfileMenu(const QPoint &global_pos, Qt::MouseButton bu QActionGroup global(this); QActionGroup user(this); - for(int cnt = 0; cnt < model.rowCount(); cnt++) + for (int cnt = 0; cnt < model.rowCount(); cnt++) { QModelIndex idx = model.index(cnt, ProfileModel::COL_NAME); - if ( ! idx.isValid() ) + if (! idx.isValid()) continue; QAction * pa = Q_NULLPTR; QString name = idx.data().toString(); - if ( idx.data(ProfileModel::DATA_IS_DEFAULT).toBool() ) + if (idx.data(ProfileModel::DATA_IS_DEFAULT).toBool()) { pa = profile_menu_.addAction(name); } - else if ( idx.data(ProfileModel::DATA_IS_GLOBAL).toBool() ) + else if (idx.data(ProfileModel::DATA_IS_GLOBAL).toBool()) { /* Check if this profile does not exist as user */ - if ( cnt == model.findByName(name) ) + if (cnt == model.findByName(name)) pa = global.addAction(name); } else pa = user.addAction(name); - if ( ! pa ) + if (! pa) continue; pa->setCheckable(true); - if ( idx.data(ProfileModel::DATA_IS_SELECTED).toBool() ) + if (idx.data(ProfileModel::DATA_IS_SELECTED).toBool()) pa->setChecked(true); pa->setFont(idx.data(Qt::FontRole).value<QFont>()); @@ -540,7 +540,7 @@ void MainStatusBar::showProfileMenu(const QPoint &global_pos, Qt::MouseButton bu bool enable_edit = false; QModelIndex idx = model.activeProfile(); - if ( ! idx.data(ProfileModel::DATA_IS_DEFAULT).toBool() && ! idx.data(ProfileModel::DATA_IS_GLOBAL).toBool() ) + if (! idx.data(ProfileModel::DATA_IS_DEFAULT).toBool() && ! idx.data(ProfileModel::DATA_IS_GLOBAL).toBool()) enable_edit = true; profile_menu_.setTitle(tr("Switch to")); @@ -567,10 +567,10 @@ void MainStatusBar::showProfileMenu(const QPoint &global_pos, Qt::MouseButton bu action->setProperty("dialog_action_", (int)ProfileDialog::ImportDirProfile); ctx_menu_.addMenu(importMenu); - if ( model.userProfilesExist() ) + if (model.userProfilesExist()) { QMenu * exportMenu = new QMenu(tr("Export")); - if ( enable_edit ) + if (enable_edit) { action = exportMenu->addAction(tr("selected personal profile"), this, SLOT(manageProfile())); action->setProperty("dialog_action_", (int)ProfileDialog::ExportSingleProfile); @@ -636,7 +636,7 @@ void MainStatusBar::captureEventHandler(CaptureEvent ev) { #ifdef HAVE_LIBPCAP case CaptureEvent::Update: - switch ( ev.eventType() ) + switch (ev.eventType()) { case CaptureEvent::Continued: updateCaptureStatistics(ev.capSession()); @@ -646,7 +646,7 @@ void MainStatusBar::captureEventHandler(CaptureEvent ev) } break; case CaptureEvent::Fixed: - switch ( ev.eventType() ) + switch (ev.eventType()) { case CaptureEvent::Continued: updateCaptureFixedStatistics(ev.capSession()); @@ -657,7 +657,7 @@ void MainStatusBar::captureEventHandler(CaptureEvent ev) break; #endif case CaptureEvent::Save: - switch ( ev.eventType() ) + switch (ev.eventType()) { case CaptureEvent::Finished: case CaptureEvent::Failed: |