diff options
| author | Moshe Kaplan <me@moshekaplan.com> | 2020-12-20 21:30:28 -0500 |
|---|---|---|
| committer | AndersBroman <a.broman58@gmail.com> | 2020-12-22 14:56:38 +0000 |
| commit | e16166a74cca1d66e2c302e257cf94aebb380599 (patch) | |
| tree | 8834b4b8390fca83dd7bc1b4b9e6a7bb276e1d7e /ui/profile.c | |
| parent | 7b27b444cbd94853b399da770e0dad4b91ef23ac (diff) | |
Detect and replace bad allocation patterns
Adds a pre-commit hook for detecting and replacing
occurrences of `g_malloc()` and `wmem_alloc()` with
`g_new()` and `wmem_new()`, to improve the
readability of Wireshark's code, and
occurrences of
`g_malloc(sizeof(struct myobj) * foo)`
with
`g_new(struct myobj, foo)`
to prevent integer overflows
Also fixes all existing occurrences across
the codebase.
Diffstat (limited to 'ui/profile.c')
| -rw-r--r-- | ui/profile.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui/profile.c b/ui/profile.c index a6742e5320..3a24f97ae1 100644 --- a/ui/profile.c +++ b/ui/profile.c @@ -45,7 +45,7 @@ add_profile_entry(GList *fl, const char *profilename, const char *reference, int { profile_def *profile; - profile = (profile_def *) g_malloc0(sizeof(profile_def)); + profile = g_new0(profile_def, 1); profile->name = g_strdup(profilename); profile->reference = g_strdup(reference); profile->status = status; |