diff options
| author | Tomasz Moń <desowin@gmail.com> | 2019-05-20 19:33:12 +0200 |
|---|---|---|
| committer | Peter Wu <peter@lekensteyn.nl> | 2019-05-21 11:01:24 +0000 |
| commit | 3451314e5cc57be2229232a94fce6d8938568372 (patch) | |
| tree | d666edfb4667da4402d3f27e398386a264d59e18 /ui/preference_utils.c | |
| parent | 5d2af76c9842436f7e556f5e4743cd7347690fe6 (diff) | |
ui: Fix memory leak on extcap configuration save
Change-Id: I8099fe33fd7a93064d7a9c2220c9b47206bae74f
Reviewed-on: https://code.wireshark.org/review/33282
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Diffstat (limited to 'ui/preference_utils.c')
| -rw-r--r-- | ui/preference_utils.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/ui/preference_utils.c b/ui/preference_utils.c index e0b1cbfbdb..c9b0dff569 100644 --- a/ui/preference_utils.c +++ b/ui/preference_utils.c @@ -130,18 +130,18 @@ prefs_store_ext_multiple(const char * module, GHashTable * pref_values) if ( ! keys ) return pref_changed; - while ( keys != NULL ) + for ( GList * key = keys; key != NULL; key = g_list_next(key) ) { - gchar * pref_name = (gchar *)keys->data; - gchar * pref_value = (gchar *) g_hash_table_lookup(pref_values, keys->data); + gchar * pref_name = (gchar *)key->data; + gchar * pref_value = (gchar *) g_hash_table_lookup(pref_values, key->data); if ( pref_name && pref_value ) { if ( prefs_store_ext_helper(module, pref_name, pref_value) ) pref_changed = TRUE; } - keys = g_list_next(keys); } + g_list_free(keys); if ( pref_changed ) { |