diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2015-06-29 11:22:08 +0200 |
|---|---|---|
| committer | Peter Wu <peter@lekensteyn.nl> | 2015-06-29 09:43:02 +0000 |
| commit | 59d56bf55199c6f457dca5e3cafb4147e0725167 (patch) | |
| tree | 6762dd981f97ab385e564f1848de46a8b86b596e /ui/gtk/main_menubar.c | |
| parent | 149d0b7e910f99f72a74e0c1a441f4db213cf3c1 (diff) | |
gtk: Fix use-after-free on removing recent file
Change-Id: I930b0522d116d53aeef366ae0b43f818b9a81d7f
Reviewed-on: https://code.wireshark.org/review/9211
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Diffstat (limited to 'ui/gtk/main_menubar.c')
| -rw-r--r-- | ui/gtk/main_menubar.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/ui/gtk/main_menubar.c b/ui/gtk/main_menubar.c index 50292d049e..78ddced40f 100644 --- a/ui/gtk/main_menubar.c +++ b/ui/gtk/main_menubar.c @@ -3643,11 +3643,12 @@ set_menu_object_data (const gchar *path, const gchar *key, gpointer data) static GList * remove_present_file_name(GList *recent_files_list, const gchar *cf_name) { - GList *li; + GList *li, *next; gchar *widget_cf_name; - for (li = g_list_first(recent_files_list); li; li = li->next) { + for (li = g_list_first(recent_files_list); li; li = next) { widget_cf_name = (gchar *)li->data; + next = li->next; if ( #ifdef _WIN32 /* do a case insensitive compare on win32 */ |