aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk/dlg_utils.c
diff options
context:
space:
mode:
authorBill Meier <wmeier@newsguy.com>2013-03-05 22:12:09 +0000
committerBill Meier <wmeier@newsguy.com>2013-03-05 22:12:09 +0000
commitfaa06129a916b6021faa22cc3eb0d6312e9e22a2 (patch)
treea68b689a2780d15abc95636932572fde3d86128b /ui/gtk/dlg_utils.c
parent1a8a9a1b3a8e08ec2eecf5d020283da3ea621c69 (diff)
Remove a comment left over from the "old days".
Also: Add an XXX comment re one effect of the fact that, on Windows, dlg_window_new() does *not* set the newly created dialog window as 'transient for' the Wireshark top_level window. svn path=/trunk/; revision=48106
Diffstat (limited to 'ui/gtk/dlg_utils.c')
-rw-r--r--ui/gtk/dlg_utils.c19
1 files changed, 5 insertions, 14 deletions
diff --git a/ui/gtk/dlg_utils.c b/ui/gtk/dlg_utils.c
index 86b34e009a..cd4384e9f4 100644
--- a/ui/gtk/dlg_utils.c
+++ b/ui/gtk/dlg_utils.c
@@ -455,23 +455,14 @@ dlg_window_new(const gchar *title)
win = window_new(GTK_WINDOW_TOPLEVEL, title);
/*
- * XXX - if we're running in the capture child process, we can't easily
- * make this window transient for the main process's window. We just
- * punt here.
- *
- * Perhaps the child process should only capture packets, write them to
- * a file, and somehow notify the parent process and let *it* do all
- * the GUI work. If we can do that efficiently (so that we don't drop
- * more packets), perhaps we can also do so even when we're *not* doing
- * an "Update list of packets in real time" capture. That'd let the
- * child process run set-UID on platforms where you need that in order
- * to capture, and might also simplify the job of having the GUI main
- * loop wait both for user input and packet arrival.
- */
- /*
* On Windows, making the dialogs transient to top_level behaves strangely.
* It is not possible any more to bring the top level window to front easily.
* So we don't do this on Windows.
+ *
+ * XXX: Note well: This means that *on Windows* any code which creates a
+ * window using dlg_window_new() and then calls
+ * gtk_widget_destroy_with_parent() will *not* get the desired effect
+ * since the dialog window actually has has no parent.
*/
#ifndef _WIN32
if (top_level) {