aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk/decode_as_dlg.c
diff options
context:
space:
mode:
authorChris Maynard <Christopher.Maynard@GTECH.COM>2012-05-25 00:43:32 +0000
committerChris Maynard <Christopher.Maynard@GTECH.COM>2012-05-25 00:43:32 +0000
commitada62f22a8170705a32dd3ce7f7d700eba94d7c2 (patch)
treef5b4a49871369795dc6a15a724fb4e3665b76357 /ui/gtk/decode_as_dlg.c
parent8fd9342f7dbfe88883f7a5122ab68bf439c9d9f5 (diff)
If either create_persconffile_dir() or ws_fopen() fail, then bail out. This avoids potentially dereferencing "daf" if it's NULL and fixes Coverity CID 281275.
svn path=/trunk/; revision=42841
Diffstat (limited to 'ui/gtk/decode_as_dlg.c')
-rw-r--r--ui/gtk/decode_as_dlg.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/ui/gtk/decode_as_dlg.c b/ui/gtk/decode_as_dlg.c
index a1ea92512f..6af95d0c9e 100644
--- a/ui/gtk/decode_as_dlg.c
+++ b/ui/gtk/decode_as_dlg.c
@@ -679,6 +679,7 @@ decode_show_save_cb (GtkWidget *win _U_, gpointer user_data _U_)
"Can't create directory\n\"%s\"\nfor recent file: %s.", pf_dir_path,
g_strerror(errno));
g_free(pf_dir_path);
+ return;
}
daf_path = get_persconffile_path(DECODE_AS_ENTRIES_FILE_NAME, TRUE, TRUE);
@@ -687,6 +688,7 @@ decode_show_save_cb (GtkWidget *win _U_, gpointer user_data _U_)
"Can't open decode_as_entries file\n\"%s\": %s.", daf_path,
g_strerror(errno));
g_free(daf_path);
+ return;
}
fputs("# \"Decode As\" entries file for Wireshark " VERSION ".\n"