diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2014-07-29 00:04:00 +0200 |
|---|---|---|
| committer | Evan Huus <eapache@gmail.com> | 2014-07-29 01:53:32 +0000 |
| commit | 0272b9c435db6b8665504d402ce1a23325f5b409 (patch) | |
| tree | 37d6e8f1ad8906b16261f7995e9af218fcf217a7 /ui/cli/tap-rtp.c | |
| parent | 3db115a545587f3420b9509bd4dc6097417184d5 (diff) | |
Fix heap-use-after-free via setlocale
setlocale returns a statically-allocated memory which can be modified by
subsequent calls of setlocale. This triggers a heap-use-after free in
ASAN when the setlocale function is called again with the previous
pointer.
This was found when trying to use the "Show All Streams" option via
the Telephony -> RTP menu.
While at it, add some modelines
Change-Id: Ide47e877ce828734fd8c5c1b064d9c505ba2b37a
Reviewed-on: https://code.wireshark.org/review/3234
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Evan Huus <eapache@gmail.com>
Diffstat (limited to 'ui/cli/tap-rtp.c')
| -rw-r--r-- | ui/cli/tap-rtp.c | 16 |
1 files changed, 15 insertions, 1 deletions
diff --git a/ui/cli/tap-rtp.c b/ui/cli/tap-rtp.c index 3456bacc86..11322dab84 100644 --- a/ui/cli/tap-rtp.c +++ b/ui/cli/tap-rtp.c @@ -71,7 +71,7 @@ rtp_streams_stat_draw(void *arg _U_) printf("%15s %5s %15s %5s %10s %16s %5s %12s %15s %15s %15s %s\n","Src IP addr", "Port", "Dest IP addr", "Port", "SSRC", "Payload", "Pkts", "Lost", "Max Delta(ms)", "Max Jitter(ms)", "Mean Jitter(ms)", "Problems?"); /* save the current locale */ - savelocale = setlocale(LC_NUMERIC, NULL); + savelocale = g_strdup(setlocale(LC_NUMERIC, NULL)); /* switch to "C" locale to avoid problems with localized decimal separators in g_snprintf("%f") functions */ setlocale(LC_NUMERIC, "C"); @@ -129,6 +129,7 @@ rtp_streams_stat_draw(void *arg _U_) printf("==============================================================\n"); /* restore previous locale setting */ setlocale(LC_NUMERIC, savelocale); + g_free(savelocale); } @@ -157,3 +158,16 @@ register_tap_listener_rtp_streams(void) { register_stat_cmd_arg("rtp,streams", rtp_streams_stat_init,NULL); } + +/* + * Editor modelines - http://www.wireshark.org/tools/modelines.html + * + * Local variables: + * c-basic-offset: 4 + * tab-width: 8 + * indent-tabs-mode: nil + * End: + * + * vi: set shiftwidth=4 tabstop=8 expandtab: + * :indentSize=4:tabSize=8:noTabs=true: + */ |