aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorDario Lombardo <lomato@gmail.com>2016-09-06 13:41:46 +0200
committerAlexis La Goutte <alexis.lagoutte@gmail.com>2016-09-06 12:31:02 +0000
commit3fce8da341b12cf3bcb3bf8e7473e1a7efbbba3f (patch)
treeb65024be40ed2a338a1a8c1d2a846a08c4ce7ccf /tools
parent10e84a612b629341acd9cd20876517e5bab63d37 (diff)
checkAPI: move atoi from deprecated to soft-deprecated list.
atoi must lie in soft-deprecated list until close to complete removal. Change-Id: Ia26ada56114559637fdc598913ee93523ed9434d Reviewed-on: https://code.wireshark.org/review/17529 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Diffstat (limited to 'tools')
-rwxr-xr-xtools/checkAPIs.pl9
1 files changed, 7 insertions, 2 deletions
diff --git a/tools/checkAPIs.pl b/tools/checkAPIs.pl
index 6117bf2575..14e18a2582 100755
--- a/tools/checkAPIs.pl
+++ b/tools/checkAPIs.pl
@@ -143,7 +143,6 @@ my %APIs = (
'freopen',
'fstat',
'lseek',
- 'atoi', # use wsutil/ws_strtoi.h function
# Misc
'tmpnam', # use mkstemp
'_snwprintf' # use StringCchPrintf
@@ -160,7 +159,13 @@ my %APIs = (
# "I" isn't always the upper-case form of "i", and "i" isn't
# always the lower-case form of "I"). Use the g_ascii_* version
# instead.
- 'toupper'
+ 'toupper',
+
+ # use wsutil/ws_strtoi.h function
+ # because of the wide use of atoi, we keep it in soft-deprecation status
+ # until we approach its complete removal, otherwise windows buildbot
+ # will keep to stuck with error.
+ 'atoi',
] },
# APIs that SHOULD NOT be used in Wireshark (any more)