aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorMartin Mathieson <martin.r.mathieson@googlemail.com>2023-01-29 18:39:20 +0000
committerMartin Mathieson <martin.r.mathieson@googlemail.com>2023-01-29 18:39:20 +0000
commit407b707e1f0c9cbcf2c4b753e08801777478c51c (patch)
treeb529b5b56e64eec0d06ad5848d2e8a04d4932013 /tools
parent516c69b92188275b571a90d415f95dc4f5e3b5f9 (diff)
check_typed_item_calls: filter out some false positives
Diffstat (limited to 'tools')
-rwxr-xr-xtools/check_typed_item_calls.py52
1 files changed, 49 insertions, 3 deletions
diff --git a/tools/check_typed_item_calls.py b/tools/check_typed_item_calls.py
index 76641f3b27..3b62c6a2a5 100755
--- a/tools/check_typed_item_calls.py
+++ b/tools/check_typed_item_calls.py
@@ -313,6 +313,51 @@ field_widths = {
'FT_INT64' : 64
}
+def is_ignored_consecutive_filter(filter):
+ ignore_patterns = [
+ re.compile(r'^elf.sh_type'),
+ re.compile(r'^elf.p_type'),
+ re.compile(r'^btavrcp.pdu_id'),
+ re.compile(r'^nstrace.trcdbg.val(\d+)'),
+ re.compile(r'^netlogon.dummy_string'),
+ re.compile(r'^opa.reserved'),
+ re.compile(r'^mpls_pm.timestamp\d\..*'),
+ re.compile(r'^wassp.data.mu_mac'),
+ re.compile(r'^thrift.type'),
+ re.compile(r'^quake2.game.client.command.move.angles'),
+ re.compile(r'^ipp.enum_value'),
+ re.compile(r'^idrp.error.subcode'),
+ re.compile(r'^ftdi-ft.lValue'),
+ re.compile(r'^6lowpan.src'),
+ re.compile(r'^couchbase.flex_frame.frame.id'),
+ re.compile(r'^rtps.param.id'),
+ re.compile(r'^rtps.locator.port'),
+ re.compile(r'^sigcomp.udvm.value'),
+ re.compile(r'^opa.mad.attributemodifier.n'),
+ re.compile(r'^smb.cmd'),
+ re.compile(r'^sctp.checksum'),
+ re.compile(r'^dhcp.option.end'),
+ re.compile(r'^nfapi.num.bf.vector.bf.value'),
+ re.compile(r'^dnp3.al.range.abs'),
+ re.compile(r'^dnp3.al.range.quantity'),
+ re.compile(r'^dnp3.al.index'),
+ re.compile(r'^dnp3.al.size'),
+ re.compile(r'^ftdi-ft.hValue'),
+ re.compile(r'^homeplug_av.op_attr_cnf.data.sw_sub'),
+ re.compile(r'^radiotap.he_mu.preamble_puncturing'),
+ re.compile(r'^ndmp.file'),
+ re.compile(r'^ocfs2.dlm.lvb'),
+ re.compile(r'^oran_fh_cus.reserved'),
+ re.compile(r'^qnet6.kif.msgsend.msg.read.xtypes0-7'),
+ re.compile(r'^mih.sig_strength')
+ ]
+
+ for patt in ignore_patterns:
+ if patt.match(filter):
+ return True
+ return False
+
+
# The relevant parts of an hf item. Used as value in dict where hf variable name is key.
class Item:
@@ -336,9 +381,10 @@ class Item:
if check_consecutive:
if Item.previousItem and Item.previousItem.filter == filter:
if label != Item.previousItem.label:
- print('Warning:', filename, hf, ': - filter "' + filter +
- '" appears consecutively - labels are "' + Item.previousItem.label + '" and "' + label + '"')
- warnings_found += 1
+ if not is_ignored_consecutive_filter(self.filter):
+ print('Warning:', filename, hf, ': - filter "' + filter +
+ '" appears consecutively - labels are "' + Item.previousItem.label + '" and "' + label + '"')
+ warnings_found += 1
Item.previousItem = self