Revise and enable test for hf[] FT_BOOLEAN fields with a non-zero bit mask and with BASE_... in the 'display' field.

svn path=/trunk/; revision=41399

1 files changed, 9 insertions, 8 deletions

diff --git a/tools/checkAPIs.pl b/tools/checkAPIs.pl
index f43cc96645..a31f3d5be6 100755
--- a/tools/checkAPIs.pl
+++ b/tools/checkAPIs.pl
@@ -1572,15 +1572,16 @@ sub check_hf_entries($$)
                         print STDERR "Error: $abbrev uses a value_string but is an FT_BOOLEAN in $filename\n";
                         $errorCount++;
 		}
+		if (($ft eq "FT_BOOLEAN") && ($bitmask !~ /^(0x)?0+$/) && ($display =~ /^BASE_/)) {
+			print STDERR "Error: $abbrev: FT_BOOLEAN with a bitmask must specify a 'parent field width' for 'display' in $filename\n";
+			$errorCount++;
+		}
+## Benign...
 ##		if (($ft eq "FT_BOOLEAN") && ($bitmask =~ /^(0x)?0+$/) && ($display ne "BASE_NONE")) {
-##			print STDERR "Error: $abbrev FT_BOOLEAN with no bitmask must use BASE_NONE for 'display' in $filename\n";
-##                        $errorCount++;
-##                }
-##		if (($ft eq "FT_BOOLEAN") && ($bitmask !~ /^(0x)?0+$/) && ($display !~ /^\d+$/)) {
-##			print STDERR "Error: $abbrev FT_BOOLEAN with a bitmask must use a numeric vale for 'display' in $filename\n";
-##                        $errorCount++;
-##                }
-        }
+##			print STDERR "Error: $abbrev: FT_BOOLEAN with no bitmask must use BASE_NONE for 'display' in $filename\n";
+##			$errorCount++;
+##		}
+	}
 
         return $errorCount;
 }