CLI: Use a better error message for obsolete preferences

Say that the preference is "obsolete", not "unknown".

Wireshark GUI already uses this language.

1 files changed, 5 insertions, 7 deletions

diff --git a/tfshark.c b/tfshark.c
index 93440f0ecc..5f53c5bce7 100644
--- a/tfshark.c
+++ b/tfshark.c
@@ -616,16 +616,14 @@ main(int argc, char *argv[])
       case PREFS_SET_OK:
         break;
 
-      case PREFS_SET_SYNTAX_ERR:
-        cmdarg_err("Invalid -o flag \"%s\"%s%s", ws_optarg,
-            errmsg ? ": " : "", errmsg ? errmsg : "");
-        g_free(errmsg);
-        return 1;
+      case PREFS_SET_NO_SUCH_PREF:
+        cmdarg_err("-o flag \"%s\" specifies unknown preference", ws_optarg);
+        exit_status = INVALID_OPTION;
+        goto clean_exit;
         break;
 
-      case PREFS_SET_NO_SUCH_PREF:
       case PREFS_SET_OBSOLETE:
-        cmdarg_err("-o flag \"%s\" specifies unknown preference", ws_optarg);
+        cmdarg_err("-o flag \"%s\" specifies obsolete preference", ws_optarg);
         exit_status = INVALID_OPTION;
         goto clean_exit;
         break;