diff options
| author | Guy Harris <guy@alum.mit.edu> | 2020-01-24 10:17:22 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2020-01-24 18:51:33 +0000 |
| commit | 0b64a3afc06bf90c9158b62d8692d6a974ab7f29 (patch) | |
| tree | 85610886d8cfba87e04e3aa91b5b1ac5a3726060 /test | |
| parent | 8a79d270104c8bbd784758dcee879de3768b403b (diff) | |
Fix the check for ws_fdopen() failure.
If tf.handle() fails, it returns -1; we shouldn't call ws_fdopen() on
its return value. (I'm not sure whether it can fail, but this code is
all a bit twisty.)
If tf.handle() succeeds, and we hand its return value to ws_fdopen(),
and we get back NULL, *that* indicates that ws_fdopen() failed.
This should fix Coverity CID 1457929, preventing a FILE leak.
Change-Id: I23bb04579d26928037f8b9284b7741affc3596f7
Reviewed-on: https://code.wireshark.org/review/35940
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions