diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2018-11-30 01:31:32 +0100 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2018-11-30 06:11:06 +0000 |
| commit | ee61bc739e133ca2b07bc51d1baa3249265193dd (patch) | |
| tree | 21b40ad794b1217b35d11750ec2058c7acff0067 /test/suite_follow.py | |
| parent | 9c0beafe44480b352bb4af56754143c9108a54fa (diff) | |
test: use assertRun instead of runProcess where possible
The case_decrypt_tls.test_tls_rsa_pq test is unexpectedly passing when
GnuTLS is disabled. It checks for '/' in the output, but that also
matches an error message. Use assertRun here and pretty much everywhere
else to catch such issues. Remove a few redundant returncode checks.
Change-Id: I0f9d1dadc0ca73eef9cffb3e2f452aa7c8395c95
Reviewed-on: https://code.wireshark.org/review/30838
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'test/suite_follow.py')
| -rw-r--r-- | test/suite_follow.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/suite_follow.py b/test/suite_follow.py index 3144bce43b..1e3df4f808 100644 --- a/test/suite_follow.py +++ b/test/suite_follow.py @@ -27,7 +27,7 @@ class case_follow_tcp(subprocesstest.SubprocessTestCase): # 6. lost but acked segments # 7. lost 3/5 fragments, but acked # Not checked: lost and not acked (currently truncated, is that OK?) - proc = self.runProcess((cmd_tshark, + proc = self.assertRun((cmd_tshark, '-r', capture_file('tcp-badsegments.pcap'), '-qz', 'follow,tcp,hex,0', )) |