diff options
| author | Guy Harris <guy@alum.mit.edu> | 2015-01-13 12:13:45 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2015-01-13 20:20:03 +0000 |
| commit | bc23f797296582d5aca5029dd34244de41ff8605 (patch) | |
| tree | c582e37dbe1f7186d2a8f16e8c6b22ab608b055d /plugins/stats_tree | |
| parent | a988253fef15e6a0ddd05b0fb06e18ccde00082b (diff) | |
UAT error string pointers should not be const pointers.
UAT error strings are usually allocated by g_strdup() or
g_strdup_printf(), and must ultimately be freed by the caller.
Make the pointer-to-error-string-pointer arguments to various functions
be "char **", not "const char **".
Fix cases that finds where a raw string was being used, as that won't
work if you try to free it; g_strdup() it instead.
Add a missing free of an error string.
Remove some no-longer-necessary casts.
Remove some unnecessary g_strdup()s (the string being handed to it was
already g_malloc()ated).
Change some variable declarations to match.
Put in XXX comments for some cases where the error string is just freed,
without being shown to the user.
Change-Id: I40297746a2ef729c56763baeddbb0842386fa0d0
Reviewed-on: https://code.wireshark.org/review/6525
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'plugins/stats_tree')
| -rw-r--r-- | plugins/stats_tree/pinfo_stats_tree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugins/stats_tree/pinfo_stats_tree.c b/plugins/stats_tree/pinfo_stats_tree.c index 0fa870ac68..a90f3f54f1 100644 --- a/plugins/stats_tree/pinfo_stats_tree.c +++ b/plugins/stats_tree/pinfo_stats_tree.c @@ -67,7 +67,7 @@ static void *uat_plen_record_copy_cb(void *n, const void *o, size_t siz _U_) { } static void -uat_plen_record_update_cb(void *r, const char **err) +uat_plen_record_update_cb(void *r, char **err) { uat_plen_record_t *rec = (uat_plen_record_t*)r; if (rec->packet_range->nranges < 1) { |