diff options
| author | gerald <gerald@f5534014-38df-0310-8fa8-9805f1628bb7> | 2005-06-20 19:35:58 +0000 |
|---|---|---|
| committer | gerald <gerald@f5534014-38df-0310-8fa8-9805f1628bb7> | 2005-06-20 19:35:58 +0000 |
| commit | 9ed804afbbc10c08e19fb72797535cf69f01378c (patch) | |
| tree | 0bc3f2c2b25520d8672dc5a055f3181818019400 /plugins/irda | |
| parent | d0d0f2314bed810351bde6939544d1187dd4c56a (diff) | |
Fix a format string vulneratility in the AFP dissector identified
by iDEFENSE. Add constant format strings to proto_item_append_text()
in a bunch of other dissectors. Copy a comment from proto.c to proto.h.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14713 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'plugins/irda')
| -rw-r--r-- | plugins/irda/packet-irda.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/plugins/irda/packet-irda.c b/plugins/irda/packet-irda.c index f8332b122f..53e50258d6 100644 --- a/plugins/irda/packet-irda.c +++ b/plugins/irda/packet-irda.c @@ -949,7 +949,7 @@ gboolean check_iap_octet_result(tvbuff_t* tvb, proto_tree* tree, unsigned offset if (tree) { proto_item* ti = proto_tree_add_item(tree, hf_iap_invaloctet, tvb, offset, 0, FALSE); - proto_item_append_text(ti, attr_name); + proto_item_append_text(ti, "%s", attr_name); proto_item_append_text(ti, "\" attribute must be octet sequence!"); } @@ -975,7 +975,7 @@ guint8 check_iap_lsap_result(tvbuff_t* tvb, proto_tree* tree, unsigned offset, if (tree) { proto_item* ti = proto_tree_add_item(tree, hf_iap_invallsap, tvb, offset, 0, FALSE); - proto_item_append_text(ti, attr_name); + proto_item_append_text(ti, "%s", attr_name); proto_item_append_text(ti, "\" attribute must be integer value between 0x01 and 0x6F!"); } |