aboutsummaryrefslogtreecommitdiffstats
path: root/plugins/epan/gryphon/packet-gryphon.c
diff options
context:
space:
mode:
authorGuy Harris <gharris@sonic.net>2021-08-25 17:29:59 -0700
committerGuy Harris <gharris@sonic.net>2021-08-25 17:29:59 -0700
commit1ab37111326e098eae7363d8e8d4bb9caabc1583 (patch)
tree1ca750dcec9ee790503c314f1fe6859070d236a7 /plugins/epan/gryphon/packet-gryphon.c
parent5e016c1970944ec85604debee19b5ee83552e316 (diff)
gryphon: explain in detail why we can't import tfs strings from libwireshark.
Diffstat (limited to 'plugins/epan/gryphon/packet-gryphon.c')
-rw-r--r--plugins/epan/gryphon/packet-gryphon.c13
1 files changed, 12 insertions, 1 deletions
diff --git a/plugins/epan/gryphon/packet-gryphon.c b/plugins/epan/gryphon/packet-gryphon.c
index 15d9dc5cfd..49afe5664e 100644
--- a/plugins/epan/gryphon/packet-gryphon.c
+++ b/plugins/epan/gryphon/packet-gryphon.c
@@ -977,7 +977,18 @@ static const value_string protocol_types[] = {
{0, NULL},
};
-/* Note: using external tfs strings doesn't work in a plugin */
+/*
+ * Note: using external tfs strings doesn't work in a plugin.
+ * The address of a data item exported from a shared library
+ * such as libwireshark is not known until the library is
+ * loaded, so "&data_item" is not a constant; MSVC complains
+ * about that.
+ *
+ * (*Direct* references to the item in code can execute a
+ * different code sequence to get the address and then load
+ * from that address, but references from a data structure
+ * can't do that.)
+ */
static const true_false_string tfs_wait_response = { "Wait", "Don't Wait" };
static const true_false_string true_false = { "True", "False" };
static const true_false_string register_unregister_action_flags = { "Register", "Unregister" };