diff options
| author | Guy Harris <guy@alum.mit.edu> | 2003-12-13 03:18:38 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2003-12-13 03:18:38 +0000 |
| commit | c20f75c872ff560b2d7a612c80dc1ce1d2be4331 (patch) | |
| tree | 3796da836583fa87bfb67e91757c4fa47801e396 /plugins/docsis/packet-uccrsp.c | |
| parent | d64affe0a47c0a5b31687adbd3849648fc206201 (diff) | |
Use "int"s, not "guint16"s, as packet offsets (using values shorter
than32 bits risks overflow problems).
Use "gint" for tvbuff lengths.
Use -1 for uses of "tvb_length_remaining()" that mean "the rest of the
tvbuff"; use "tvb_reported_length_remaining()" for "the rest of the
packet.
Clean up the handling of the DOCSIS payload.
svn path=/trunk/; revision=9267
Diffstat (limited to 'plugins/docsis/packet-uccrsp.c')
| -rw-r--r-- | plugins/docsis/packet-uccrsp.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/plugins/docsis/packet-uccrsp.c b/plugins/docsis/packet-uccrsp.c index ff03269a23..e2b54f1aea 100644 --- a/plugins/docsis/packet-uccrsp.c +++ b/plugins/docsis/packet-uccrsp.c @@ -2,7 +2,7 @@ * Routines for Upstream Channel Change Response dissection * Copyright 2002, Anand V. Narwani <anand[AT]narwani.org> * - * $Id: packet-uccrsp.c,v 1.5 2003/05/28 14:52:52 gerald Exp $ + * $Id: packet-uccrsp.c,v 1.6 2003/12/13 03:18:38 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -70,8 +70,7 @@ dissect_uccrsp (tvbuff_t * tvb, packet_info * pinfo, proto_tree * tree) if (tree) { it = - proto_tree_add_protocol_format (tree, proto_docsis_uccrsp, tvb, 0, - tvb_length_remaining (tvb, 0), + proto_tree_add_protocol_format (tree, proto_docsis_uccrsp, tvb, 0, -1, "UCC Response"); uccrsp_tree = proto_item_add_subtree (it, ett_docsis_uccrsp); proto_tree_add_item (uccrsp_tree, hf_docsis_uccrsp_upchid, tvb, 0, 1, |