diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /plugins/docsis/packet-dscreq.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'plugins/docsis/packet-dscreq.c')
| -rw-r--r-- | plugins/docsis/packet-dscreq.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/plugins/docsis/packet-dscreq.c b/plugins/docsis/packet-dscreq.c index 59be9668f2..d94e23183c 100644 --- a/plugins/docsis/packet-dscreq.c +++ b/plugins/docsis/packet-dscreq.c @@ -36,6 +36,8 @@ static dissector_handle_t docsis_tlv_handle; /* Initialize the subtree pointers */ static gint ett_docsis_dscreq = -1; +static dissector_handle_t docsis_dscreq_handle; + /* Dissection */ static int dissect_dscreq (tvbuff_t * tvb, packet_info * pinfo, proto_tree * tree, void* data _U_) @@ -89,15 +91,12 @@ proto_register_docsis_dscreq (void) proto_register_field_array (proto_docsis_dscreq, hf, array_length (hf)); proto_register_subtree_array (ett, array_length (ett)); - register_dissector ("docsis_dscreq", dissect_dscreq, proto_docsis_dscreq); + docsis_dscreq_handle = register_dissector ("docsis_dscreq", dissect_dscreq, proto_docsis_dscreq); } void proto_reg_handoff_docsis_dscreq (void) { - dissector_handle_t docsis_dscreq_handle; - - docsis_dscreq_handle = find_dissector ("docsis_dscreq"); docsis_tlv_handle = find_dissector ("docsis_tlv"); dissector_add_uint ("docsis_mgmt", 0x12, docsis_dscreq_handle); } |