diff options
| author | João Valverde <joao.valverde@tecnico.ulisboa.pt> | 2021-02-26 22:09:15 +0000 |
|---|---|---|
| committer | Wireshark GitLab Utility <gerald+gitlab-utility@wireshark.org> | 2021-03-01 20:59:39 +0000 |
| commit | 7f105d39813914036f6c04a2d73b315542cde322 (patch) | |
| tree | 7901018f226e9c077670aa1936f54faa000eb994 /plugins/codecs | |
| parent | 142cfb03ac5d0473d70f3e8adeabdc4f4496e953 (diff) | |
CMake: Use CheckAPI's abort/termoutput with dissectors only
I believe this was the original intention, to use these API restricitons
with dissectors only (not that I necessarily agree with that policy either),
and through copy-paste and lack of clear guidelines it spread to other
parts of the build.
Rename the checkAPI groups to make it very clear that this is dissector-only.
This doesn't mean, of course, that good programming practices shouldn't be
followed everywhere. In particular assertions need to be used properly.
Don't use them to catch runtime errors or validate input data.
This commit will be followed by another removing the various ugly hacks
people have been using to get around the checkAPI hammer.
Diffstat (limited to 'plugins/codecs')
| -rw-r--r-- | plugins/codecs/G711/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | plugins/codecs/G722/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | plugins/codecs/G726/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | plugins/codecs/G729/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | plugins/codecs/iLBC/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | plugins/codecs/l16_mono/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | plugins/codecs/opus_dec/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | plugins/codecs/sbc/CMakeLists.txt | 1 |
8 files changed, 0 insertions, 8 deletions
diff --git a/plugins/codecs/G711/CMakeLists.txt b/plugins/codecs/G711/CMakeLists.txt index 440f7ff0d3..0adcb74c25 100644 --- a/plugins/codecs/G711/CMakeLists.txt +++ b/plugins/codecs/G711/CMakeLists.txt @@ -48,7 +48,6 @@ CHECKAPI( NAME g711 SWITCHES - -g abort -g termoutput SOURCES ${CODEC_SRC} ${CODEC_HEADERS} diff --git a/plugins/codecs/G722/CMakeLists.txt b/plugins/codecs/G722/CMakeLists.txt index d69e35f14c..9e53820f53 100644 --- a/plugins/codecs/G722/CMakeLists.txt +++ b/plugins/codecs/G722/CMakeLists.txt @@ -50,7 +50,6 @@ CHECKAPI( NAME g722 SWITCHES - -g abort -g termoutput SOURCES ${CODEC_SRC} ${CODEC_HEADERS} diff --git a/plugins/codecs/G726/CMakeLists.txt b/plugins/codecs/G726/CMakeLists.txt index 8cfbb6edd2..faa5949d7e 100644 --- a/plugins/codecs/G726/CMakeLists.txt +++ b/plugins/codecs/G726/CMakeLists.txt @@ -50,7 +50,6 @@ CHECKAPI( NAME g726 SWITCHES - -g abort -g termoutput SOURCES ${CODEC_SRC} ${CODEC_HEADERS} diff --git a/plugins/codecs/G729/CMakeLists.txt b/plugins/codecs/G729/CMakeLists.txt index f6193c6938..fa6a9dd371 100644 --- a/plugins/codecs/G729/CMakeLists.txt +++ b/plugins/codecs/G729/CMakeLists.txt @@ -50,7 +50,6 @@ CHECKAPI( NAME g729 SWITCHES - -g abort -g termoutput SOURCES ${CODEC_SRC} ${CODEC_HEADERS} diff --git a/plugins/codecs/iLBC/CMakeLists.txt b/plugins/codecs/iLBC/CMakeLists.txt index e3ab0c7dd7..54afddda51 100644 --- a/plugins/codecs/iLBC/CMakeLists.txt +++ b/plugins/codecs/iLBC/CMakeLists.txt @@ -50,7 +50,6 @@ CHECKAPI( NAME ilbc SWITCHES - -g abort -g termoutput SOURCES ${CODEC_SRC} ${CODEC_HEADERS} diff --git a/plugins/codecs/l16_mono/CMakeLists.txt b/plugins/codecs/l16_mono/CMakeLists.txt index a6b7e27955..2c71b184d8 100644 --- a/plugins/codecs/l16_mono/CMakeLists.txt +++ b/plugins/codecs/l16_mono/CMakeLists.txt @@ -48,7 +48,6 @@ CHECKAPI( NAME l16mono SWITCHES - -g abort -g termoutput SOURCES ${CODEC_SRC} ${CODEC_HEADERS} diff --git a/plugins/codecs/opus_dec/CMakeLists.txt b/plugins/codecs/opus_dec/CMakeLists.txt index aee83a33c9..1a48c8a4b2 100644 --- a/plugins/codecs/opus_dec/CMakeLists.txt +++ b/plugins/codecs/opus_dec/CMakeLists.txt @@ -50,7 +50,6 @@ CHECKAPI( NAME opus SWITCHES - -g abort -g termoutput SOURCES ${CODEC_SRC} ${CODEC_HEADERS} diff --git a/plugins/codecs/sbc/CMakeLists.txt b/plugins/codecs/sbc/CMakeLists.txt index d06eb21e83..892081ad6a 100644 --- a/plugins/codecs/sbc/CMakeLists.txt +++ b/plugins/codecs/sbc/CMakeLists.txt @@ -50,7 +50,6 @@ CHECKAPI( NAME sbc SWITCHES - -g abort -g termoutput SOURCES ${CODEC_SRC} ${CODEC_HEADERS} |