diff options
| author | Jaap Keuter <jaap.keuter@xs4all.nl> | 2009-02-22 12:22:28 +0000 |
|---|---|---|
| committer | Jaap Keuter <jaap.keuter@xs4all.nl> | 2009-02-22 12:22:28 +0000 |
| commit | ace93cb4bb376fb55422bcc1b493c7e0ad85b32b (patch) | |
| tree | d432696b86bf4863e48ee5e2d72eeca5f7b289be /plugins/asn1 | |
| parent | 23461c4382b1ece366280aaba8da767fa7287b49 (diff) | |
From Robert Groenenberg:
As of version 0.99.8, there has been an annoying problem in the ASN.1 dissector:
when using a 'type table' which discribes the ASN.1 syntax of the traced packets,
wireshark would crash on the very first packet. The cause for the crash is an out-of-
boundry write, detected by g_free().
svn path=/trunk/; revision=27507
Diffstat (limited to 'plugins/asn1')
| -rw-r--r-- | plugins/asn1/packet-asn1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugins/asn1/packet-asn1.c b/plugins/asn1/packet-asn1.c index a44fc2f115..efaa99cf90 100644 --- a/plugins/asn1/packet-asn1.c +++ b/plugins/asn1/packet-asn1.c @@ -566,7 +566,7 @@ showoctets(guchar *octets, guint len, guint hexlen) /* if len <= hexlen, always for (i=0; i<len; i++) { p += g_sprintf(p, "%2.2X", octets[i]); } - strncpy(p, endstr, len*2 + 5); + strncpy(p, endstr, 5); } else { if (len <= hexlen) { /* show both hex and ascii, assume hexlen < MAX_OTSLEN */ str = p = g_malloc(len*3+2); |