diff options
| author | Uwe Girlich <Uwe.Girlich@philosys.de> | 2002-11-18 09:35:29 +0000 |
|---|---|---|
| committer | Uwe Girlich <Uwe.Girlich@philosys.de> | 2002-11-18 09:35:29 +0000 |
| commit | c84b7e9620c2df77eb988dcc7d9e7376c26fa7d9 (patch) | |
| tree | a53e0d1add78d23019cc1ed978acf9485fcdeedf /packet-rpc.c | |
| parent | 4bd37c8dde85cad33c47d100dcddd0689867838b (diff) | |
Since packet-rpc.c 1.56 (ethereal 0.8.18), we store in
dissect_rpc_opaque_data() the actual bytes into the dissector data tree
(improves searching). But if we only give the string "<DATA>" to the
proto_tree_add_* functions and tell it at the same time, that we have indeed
string_length_copy bytes, this leads to problems.
Correction: give the pointer into the real data and not the pointer to the
print string to the proto_tree_add_string_format() and
proto_tree_add_bytes_format() functions.
The correction was found by Martin Regner.
svn path=/trunk/; revision=6655
Diffstat (limited to 'packet-rpc.c')
| -rw-r--r-- | packet-rpc.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/packet-rpc.c b/packet-rpc.c index 36ddb9c8d6..466364aa81 100644 --- a/packet-rpc.c +++ b/packet-rpc.c @@ -2,7 +2,7 @@ * Routines for rpc dissection * Copyright 1999, Uwe Girlich <Uwe.Girlich@philosys.de> * - * $Id: packet-rpc.c,v 1.108 2002/11/13 21:45:56 guy Exp $ + * $Id: packet-rpc.c,v 1.109 2002/11/18 09:35:29 girlich Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -624,12 +624,12 @@ dissect_rpc_opaque_data(tvbuff_t *tvb, int offset, if (string_data) { proto_tree_add_string_format(string_tree, hfindex, tvb, offset, string_length_copy, - string_buffer_print, + string_buffer, "contents: %s", string_buffer_print); } else { proto_tree_add_bytes_format(string_tree, hfindex, tvb, offset, string_length_copy, - string_buffer_print, + string_buffer, "contents: %s", string_buffer_print); } } |