aboutsummaryrefslogtreecommitdiffstats
path: root/packet-ppp.c
diff options
context:
space:
mode:
authorLaurent Deniel <laurent.deniel@free.fr>2000-08-13 14:09:15 +0000
committerLaurent Deniel <laurent.deniel@free.fr>2000-08-13 14:09:15 +0000
commitcc36f0b9312fc36778bf227cbaaf02c89baf09b3 (patch)
tree0aff9b70a00a628a713030dc9000f3b5492d492b /packet-ppp.c
parentdb31ba13c8b9f82c1b96b5444fe3b7e8ff109ce1 (diff)
Add the "Edit:Protocols..." feature which currently only implements
the following: It is now possible to enable/disable a particular protocol decoding (i.e. the protocol dissector is void or not). When a protocol is disabled, it is displayed as Data and of course, all linked sub-protocols are disabled as well. Disabling a protocol could be interesting: - in case of buggy dissectors - in case of wrong heuristics - for performance reasons - to decode the data as another protocol (TODO) Currently (if I am not wrong), all dissectors but NFS can be disabled (and dissectors that do not register protocols :-) I do not like the way the RPC sub-dissectors are disabled (in the sub-dissectors) since this could be done in the RPC dissector itself, knowing the sub-protocol hfinfo entry (this is why, I've not modified the NFS one yet). Two functions are added in proto.c : gboolean proto_is_protocol_enabled(int n); void proto_set_decoding(int n, gboolean enabled); and two MACROs which can be used in dissectors: OLD_CHECK_DISPLAY_AS_DATA(index, pd, offset, fd, tree) CHECK_DISPLAY_AS_DATA(index, tvb, pinfo, tree) See also the XXX in proto_dlg.c and proto.c around the new functions. svn path=/trunk/; revision=2267
Diffstat (limited to 'packet-ppp.c')
-rw-r--r--packet-ppp.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/packet-ppp.c b/packet-ppp.c
index 38a459b66b..6ec222100d 100644
--- a/packet-ppp.c
+++ b/packet-ppp.c
@@ -1,7 +1,7 @@
/* packet-ppp.c
* Routines for ppp packet disassembly
*
- * $Id: packet-ppp.c,v 1.38 2000/08/07 03:21:00 guy Exp $
+ * $Id: packet-ppp.c,v 1.39 2000/08/13 14:08:38 deniel Exp $
*
* Ethereal - Network traffic analyzer
* By Gerald Combs <gerald@zing.org>
@@ -1046,6 +1046,8 @@ dissect_mp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
int first, last;
tvbuff_t *next_tvb;
+ CHECK_DISPLAY_AS_DATA(proto_mp, tvb, pinfo, tree);
+
flags = tvb_get_guint8(tvb, 0);
first = flags && MP_FRAG_FIRST;
last = flags && MP_FRAG_LAST;
@@ -1123,6 +1125,8 @@ dissect_ppp( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree ) {
tvbuff_t *next_tvb;
guint8 byte0;
+ CHECK_DISPLAY_AS_DATA(proto_ppp, tvb, pinfo, tree);
+
pinfo->current_proto = "PPP";
byte0 = tvb_get_guint8(tvb, 0);