diff options
| author | guy <guy@f5534014-38df-0310-8fa8-9805f1628bb7> | 2002-05-16 09:59:52 +0000 |
|---|---|---|
| committer | guy <guy@f5534014-38df-0310-8fa8-9805f1628bb7> | 2002-05-16 09:59:52 +0000 |
| commit | f871d9ec3a9410a8854b34c84116eb82cae40ab5 (patch) | |
| tree | f7dd594451c6594189fae0cf16b7cd0045d61e66 /packet-ncp.c | |
| parent | 400b3fcf4b847a9768528807b0ba112fe24e6e7b (diff) | |
Move the #defines for NCP packet types to "packet-ncp-int.h", and use
them in "packet-ncp2222.inc".
The page at
http://www.odyssea.com/whats_new/tcpipnet/tcpipnet.html
indicates that a positive ACK (0x9999) NCP packet has the same
completion code and connection status fields as a reply (0x3333) packet
(but nothing after them); hand "dissect_ncp_reply()" the packet type as
one of its arguments, and have it handle positive ACK packets as well as
reply packets.
It also indicates that bit 4 of the connection status indicates that the
server is unavailable, and the page at
http://www.unm.edu/~network/presentations/course/appendix/appendix_f/tsld088.htm
speaks of that and of the significance of other bits; put a comment in
"ncp2222.py", before the "hf_ncp_connection_status" field, about that.
From looking at a capture, it appears that a "destroy service
connection" (0x5555) packet should be treated like a "create service
connection" (0x1111) packet and be handed to "dissect_ncp_request()".
Note that perhaps watchdog packets should be handled by
"dissect_ncp_reply()" as well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5489 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'packet-ncp.c')
| -rw-r--r-- | packet-ncp.c | 25 |
1 files changed, 11 insertions, 14 deletions
diff --git a/packet-ncp.c b/packet-ncp.c index 7a94043a86..d451d4502a 100644 --- a/packet-ncp.c +++ b/packet-ncp.c @@ -3,7 +3,7 @@ * Gilbert Ramirez <gram@alumni.rice.edu> * Modified to allow NCP over TCP/IP decodes by James Coe <jammer@cin.net> * - * $Id: packet-ncp.c,v 1.60 2002/05/15 21:37:19 guy Exp $ + * $Id: packet-ncp.c,v 1.61 2002/05/16 09:59:52 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -141,14 +141,6 @@ struct ncp_common_header { }; -#define NCP_ALLOCATE_SLOT 0x1111 -#define NCP_SERVICE_REQUEST 0x2222 -#define NCP_SERVICE_REPLY 0x3333 -#define NCP_WATCHDOG 0x3e3e -#define NCP_DEALLOCATE_SLOT 0x5555 -#define NCP_BURST_MODE_XFER 0x7777 -#define NCP_POSITIVE_ACK 0x9999 - static value_string ncp_type_vals[] = { { NCP_ALLOCATE_SLOT, "Create a service connection" }, { NCP_SERVICE_REQUEST, "Service request" }, @@ -243,7 +235,7 @@ dissect_ncp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) */ switch (header.type) { - case NCP_ALLOCATE_SLOT: /* "Allocate Slot Request"? */ + case NCP_ALLOCATE_SLOT: /* Allocate Slot Request */ case NCP_SERVICE_REQUEST: /* Server NCP Request */ case NCP_SERVICE_REPLY: /* Server NCP Reply */ case NCP_WATCHDOG: /* Watchdog Packet */ @@ -356,20 +348,27 @@ dissect_ncp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) */ switch (header.type) { - case NCP_ALLOCATE_SLOT: /* "Allocate Slot Request"? */ + case NCP_ALLOCATE_SLOT: /* Allocate Slot Request */ case NCP_SERVICE_REQUEST: /* Server NCP Request */ + case NCP_DEALLOCATE_SLOT: /* Deallocate Slot Request */ next_tvb = tvb_new_subset(tvb, hdr_offset, -1, -1); dissect_ncp_request(next_tvb, pinfo, nw_connection, header.sequence, header.type, ncp_tree); break; case NCP_SERVICE_REPLY: /* Server NCP Reply */ + case NCP_POSITIVE_ACK: /* Positive Acknowledgement */ next_tvb = tvb_new_subset(tvb, hdr_offset, -1, -1); dissect_ncp_reply(next_tvb, pinfo, nw_connection, - header.sequence, ncp_tree); + header.sequence, header.type, ncp_tree); break; case NCP_WATCHDOG: /* Watchdog Packet */ + /* + * XXX - should the completion code be interpreted as + * it is in "packet-ncp2222.inc"? If so, this + * packet should be handled by "dissect_ncp_reply()". + */ proto_tree_add_item(ncp_tree, hf_ncp_completion_code, tvb, commhdr + 6, 1, TRUE); proto_tree_add_item(ncp_tree, hf_ncp_connection_status, @@ -423,8 +422,6 @@ dissect_ncp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) } break; - case NCP_DEALLOCATE_SLOT: /* Deallocate Slot Request */ - case NCP_POSITIVE_ACK: /* Positive Acknowledgement */ default: if (tree) { proto_tree_add_text(ncp_tree, tvb, commhdr + 6, -1, |