diff options
author | Guy Harris <guy@alum.mit.edu> | 2003-06-12 08:02:47 +0000 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2003-06-12 08:02:47 +0000 |
commit | 6402ebc0e56386a13be179caa6bfa1b845254b6b (patch) | |
tree | 1ae6fef818afa2ea9da0ef70b56bfa72d4e42e3d /packet-mbtcp.c | |
parent | 96524f20bc4c9fc7be2eb86d178a8396254ee42e (diff) |
Heuristic dissectors are not allowed to return FALSE after they've done
something to the protocol tree or the columns, as that leaves crud in
the protocol tree that could mess up whatever stuff subsequent
dissection code does with the packet.
Get rid of all column-setting code before the initial sanity checking
code, and have that code just return FALSE rather than putting
"Malformed FIX Packet" indications (if the dissector returns FALSE, it's
saying the packet *isn't* a FIX packet, not that it is one but that it's
malformed). After we've set the columns and created the protocol tree,
return TRUE if we find a problem (we should put an error indication
there in that case).
svn path=/trunk/; revision=7857
Diffstat (limited to 'packet-mbtcp.c')
0 files changed, 0 insertions, 0 deletions