diff options
author | Guy Harris <guy@alum.mit.edu> | 2000-08-07 03:21:25 +0000 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2000-08-07 03:21:25 +0000 |
commit | 56b989e0adbbbdb7b5f0e9edeb47dc7ebd44ced0 (patch) | |
tree | 33bbe4cfb92d0ba70d2d9909cfe9763031f5c77c /packet-lpd.c | |
parent | a60203b3c6656798f1be051910a997091b734c2d (diff) |
Allow either old-style (pre-tvbuff) or new-style (tvbuffified)
dissectors to be registered as dissectors for particular ports,
registered as heuristic dissectors, and registered as dissectors for
conversations, and have routines to be used both by old-style and
new-style dissectors to call registered dissectors.
Have the code that calls those dissectors translate the arguments as
necessary. (For conversation dissectors, replace
"find_conversation_dissector()", which just returns a pointer to the
dissector, with "old_try_conversation_dissector()" and
"try_conversation_dissector()", which actually call the dissector, so
that there's a single place at which we can do that translation. Also
make "dissector_lookup()" static and, instead of calling it and, if it
returns a non-null pointer, calling that dissector, just use
"old_dissector_try_port()" or "dissector_try_port()", for the same
reason.)
This allows some dissectors that took old-style arguments and
immediately translated them to new-style arguments to just take
new-style arguments; make them do so. It also allows some new-style
dissectors not to have to translate arguments before calling routines to
look up and call dissectors; make them not do so.
Get rid of checks for too-short frames in new-style dissectors - the
tvbuff code does those checks for you.
Give the routines to register old-style dissectors, and to call
dissectors from old-style dissectors, names beginning with "old_", with
the routines for new-style dissectors not having the "old_". Update the
dissectors that use those routines appropriately.
Rename "dissect_data()" to "old_dissect_data()", and
"dissect_data_tvb()" to "dissect_data()".
svn path=/trunk/; revision=2218
Diffstat (limited to 'packet-lpd.c')
-rw-r--r-- | packet-lpd.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/packet-lpd.c b/packet-lpd.c index d457f5bf7f..aad54d273e 100644 --- a/packet-lpd.c +++ b/packet-lpd.c @@ -2,7 +2,7 @@ * Routines for LPR and LPRng packet disassembly * Gilbert Ramirez <gram@xiexie.org> * - * $Id: packet-lpd.c,v 1.20 2000/05/31 05:07:17 guy Exp $ + * $Id: packet-lpd.c,v 1.21 2000/08/07 03:20:51 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@zing.org> @@ -124,7 +124,7 @@ dissect_lpd(const u_char *pd, int offset, frame_data *fd, proto_tree *tree) strlen(printer), "Printer/options: %s", printer); } else { - dissect_data(pd, offset, fd, tree); + old_dissect_data(pd, offset, fd, tree); } if (printer) @@ -138,11 +138,11 @@ dissect_lpd(const u_char *pd, int offset, frame_data *fd, proto_tree *tree) lpd_server_code[response]); } else { - dissect_data(pd, offset, fd, tree); + old_dissect_data(pd, offset, fd, tree); } } else { - dissect_data(pd, offset, fd, tree); + old_dissect_data(pd, offset, fd, tree); } } } @@ -200,5 +200,5 @@ proto_register_lpd(void) void proto_reg_handoff_lpd(void) { - dissector_add("tcp.port", TCP_PORT_PRINTER, &dissect_lpd); + old_dissector_add("tcp.port", TCP_PORT_PRINTER, &dissect_lpd); } |