diff options
author | gram <gram@f5534014-38df-0310-8fa8-9805f1628bb7> | 2000-11-21 16:17:58 +0000 |
---|---|---|
committer | gram <gram@f5534014-38df-0310-8fa8-9805f1628bb7> | 2000-11-21 16:17:58 +0000 |
commit | 26f1e02003188bcc075da9cd26d5bd14d0e13f6a (patch) | |
tree | 9df6de8599c26d7cd8a985eda1f4b2f2c298fe89 /packet-icq.c | |
parent | 76ed40e14cb2640bab971fd3128c1b16b4f45d03 (diff) |
Fix infinite loop in reallocation of memory for decryption buffer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2688 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'packet-icq.c')
-rw-r--r-- | packet-icq.c | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/packet-icq.c b/packet-icq.c index 1fa21a8651..90720af220 100644 --- a/packet-icq.c +++ b/packet-icq.c @@ -1,7 +1,7 @@ /* packet-icq.c * Routines for ICQ packet disassembly * - * $Id: packet-icq.c,v 1.23 2000/11/19 19:23:54 gerald Exp $ + * $Id: packet-icq.c,v 1.24 2000/11/21 16:17:58 gram Exp $ * * Ethereal - Network traffic analyzer * By Johan Feyaerts @@ -2053,14 +2053,19 @@ dissect_icqv5Client(const u_char *pd, guint32 key = -1; guint16 pktsize = -1; /* The size of the ICQ content */ static u_char *decr_pd = NULL; /* Decrypted content */ + static int decr_size = 0; /* Size of decrypted-content buffer */ pktsize = END_OF_FRAME; - if (decr_pd == NULL) - decr_pd = (u_char *) g_malloc(sizeof (u_char) * 128); - - while (sizeof(decr_pd) < pktsize + 3) - decr_pd = (u_char *) g_realloc(decr_pd, sizeof (decr_pd) * 2); + if (decr_size == 0 ) { + decr_size = sizeof(u_char) * 128; + decr_pd = g_malloc(decr_size); + } + + while (decr_size < pktsize + 3) { + decr_size *= 2; + decr_pd = g_realloc(decr_pd, decr_size); + } /* First copy the memory, we don't want to overwrite the old content */ memcpy(decr_pd, &pd[offset], pktsize); |