Add the "Edit:Protocols..." feature which currently only implements

the following:

It is now possible to enable/disable a particular protocol decoding
(i.e. the protocol dissector is void or not). When a protocol
is disabled, it is displayed as Data and of course, all linked
sub-protocols are disabled as well.

Disabling a protocol could be interesting:

- in case of buggy dissectors
- in case of wrong heuristics
- for performance reasons
- to decode the data as another protocol (TODO)

Currently (if I am not wrong), all dissectors but NFS can be disabled
(and dissectors that do not register protocols :-)

I do not like the way the RPC sub-dissectors are disabled (in the
sub-dissectors) since this could be done in the RPC dissector itself,
knowing the sub-protocol hfinfo entry (this is why, I've not modified
the NFS one yet).

Two functions are added in proto.c :

gboolean proto_is_protocol_enabled(int n);
void proto_set_decoding(int n, gboolean enabled);

and two MACROs which can be used in dissectors:

OLD_CHECK_DISPLAY_AS_DATA(index, pd, offset, fd, tree)
CHECK_DISPLAY_AS_DATA(index, tvb, pinfo, tree)

See also the XXX in proto_dlg.c and proto.c around the new functions.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2267 f5534014-38df-0310-8fa8-9805f1628bb7

1 files changed, 3 insertions, 1 deletions

diff --git a/packet-icp.c b/packet-icp.c
index 7041308d06..015035b599 100644
--- a/packet-icp.c
+++ b/packet-icp.c
@@ -2,7 +2,7 @@
  * Routines for ICP (internet cache protocol) packet disassembly
  * RFC 2186 && RFC 2187
  *
- * $Id: packet-icp.c,v 1.10 2000/08/07 03:20:38 guy Exp $
+ * $Id: packet-icp.c,v 1.11 2000/08/13 14:08:14 deniel Exp $
  *
  * Ethereal - Network traffic analyzer
  * By Peter Torvals
@@ -181,6 +181,8 @@ static void dissect_icp(const u_char *pd, int offset, frame_data *fd,
 
   gchar *opcodestrval;
 
+  OLD_CHECK_DISPLAY_AS_DATA(proto_icp, pd, offset, fd, tree);
+
 /* TBD: check if this is a fragment or first part of udp packet */
   icph.opcode=pd[offset];
   icph.version=pd[offset+1];