diff options
| author | Gerald Combs <gerald@wireshark.org> | 2020-02-05 11:15:39 -0800 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2020-02-11 01:43:33 +0000 |
| commit | 937c7c512ab5bcb4d70e48760a11af825742effa (patch) | |
| tree | a5a5d1c4c978476b2fe3b967f97c600d930d1bf7 /packaging | |
| parent | 76462953a9079c886e37a0dabebfbeaf04776feb (diff) | |
Debian+RPM: Require QtSVG.
Although we don't depend on any of Qt's SVG classes directly, we do use
SVG icons in Preferences → Appearance → Language and QIcon loads its SVG
engine dynamically. If it's not present Wireshark will still run, but
the user won't see any flag icons.
Require QtSVG in the Debian and RPM packaging. It's not that large (~
400k here on Ubuntu 18.04) and ensures that we have a uniform user
experience across platforms. In this particular case, if the user
experience happens to be "Wireshark's UI is in a language I don't
understand" the little flags can come in handy.
Change-Id: If3c2e8a6040967353dbc462ee475ef12514b25f9
Reviewed-on: https://code.wireshark.org/review/36037
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'packaging')
| -rw-r--r-- | packaging/rpm/wireshark.spec.in | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/packaging/rpm/wireshark.spec.in b/packaging/rpm/wireshark.spec.in index 501e03e4de..61e42be0c8 100644 --- a/packaging/rpm/wireshark.spec.in +++ b/packaging/rpm/wireshark.spec.in @@ -243,6 +243,7 @@ Requires: libQt5PrintSupport5 BuildRequires: libqt5-qtmultimedia-devel Requires: libQt5Multimedia5 BuildRequires: libqt5-linguist-devel +Requires: libQt5Svg5 # Need this for SUSE's suse_update_desktop_file macro BuildRequires: update-desktop-files %else @@ -252,6 +253,7 @@ Requires: qt5-qtbase-gui BuildRequires: qt5-qtmultimedia-devel Requires: qt5-qtmultimedia BuildRequires: qt5-linguist +Requires: qt5-qtsvg %endif Requires: xdg-utils Requires: hicolor-icon-theme |