diff options
| author | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2006-06-22 11:08:35 +0000 |
|---|---|---|
| committer | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2006-06-22 11:08:35 +0000 |
| commit | 6ceb4d9b46a74a1c5d632c70a5e4493bc8279997 (patch) | |
| tree | 4d127bc3b7ec7b4fcfa718da12a85571b2d976ac /gtk | |
| parent | a8b26ae252251c677a986c41d2997f84b73e4b81 (diff) | |
coverity 194
this is actually a false positive in coverity and can not trigger since htis pointer can not be null here
but verifying this before the varialbe is dereferenced does not hurt in case
the file is changed and this contract is broken.
checking the
svn path=/trunk/; revision=18542
Diffstat (limited to 'gtk')
| -rw-r--r-- | gtk/voip_calls.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gtk/voip_calls.c b/gtk/voip_calls.c index e7c106e2a8..1d997d9c32 100644 --- a/gtk/voip_calls.c +++ b/gtk/voip_calls.c @@ -1681,6 +1681,7 @@ H225calls_packet(void *ptr _U_, packet_info *pinfo, epan_dissect_t *edt _U_, con while (list) { tmp_listinfo=list->data; + g_assert(tmp_h323info != NULL); if (tmp_listinfo->protocol == VOIP_H323){ tmp_h323info = tmp_listinfo->prot_info; if (tmp_h323info->requestSeqNum == pi->requestSeqNum) { @@ -1698,6 +1699,7 @@ H225calls_packet(void *ptr _U_, packet_info *pinfo, epan_dissect_t *edt _U_, con tmp_listinfo=list->data; if (tmp_listinfo->protocol == VOIP_H323){ tmp_h323info = tmp_listinfo->prot_info; + g_assert(tmp_h323info != NULL); if ( (memcmp(tmp_h323info->guid, &guid_allzero, GUID_LEN) != 0) && (memcmp(tmp_h323info->guid, &pi->guid,GUID_LEN)==0) ){ strinfo = (voip_calls_info_t*)(list->data); break; @@ -1725,6 +1727,7 @@ H225calls_packet(void *ptr _U_, packet_info *pinfo, epan_dissect_t *edt _U_, con strinfo->protocol=VOIP_H323; strinfo->prot_info=g_malloc(sizeof(h323_calls_info_t)); tmp_h323info = strinfo->prot_info; + g_assert(tmp_h323info != NULL); tmp_h323info->guid = g_memdup(&pi->guid, sizeof pi->guid); tmp_h323info->h225SetupAddr.type = AT_NONE; tmp_h323info->h225SetupAddr.len = 0; |