GtkList to GtkTreeView conversion.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6217 f5534014-38df-0310-8fa8-9805f1628bb7

2 files changed, 889 insertions, 858 deletions

diff --git a/gtk2/STATUS b/gtk2/STATUS
index 736bc09841..6fae739234 100644
--- a/gtk2/STATUS
+++ b/gtk2/STATUS
@@ -6,7 +6,7 @@ GtkList and GtkCList ==> GtkTreeView conversion :
 - column_prefs.c
 - decode_as_dlg.c : done
 - dfilter_expr_dialog.c
-- filter_prefs.c
+- filter_prefs.c : done
 - main.c
 - plugins_dlg.c : done
 
diff --git a/gtk2/filter_prefs.c b/gtk2/filter_prefs.c
index 55b171b67a..9e89aade48 100644
--- a/gtk2/filter_prefs.c
+++ b/gtk2/filter_prefs.c
@@ -3,7 +3,7 @@
  * (This used to be a notebook page under "Preferences", hence the
  * "prefs" in the file name.)
  *
- * $Id: filter_prefs.c,v 1.1 2002/08/31 09:55:21 oabad Exp $
+ * $Id: filter_prefs.c,v 1.2 2002/09/07 10:48:07 oabad Exp $
  *
  * Ethereal - Network traffic analyzer
  * By Gerald Combs <gerald@ethereal.com>
@@ -57,12 +57,13 @@
 #define E_FILT_DBLACTIVATE_KEY      "filter_dblactivate"
 
 typedef struct _filter_cb_data {
-  GList     *fl;
-  GtkWidget *win;
+    GList     *fl;
+    GtkWidget *win;
 } filter_cb_data;
 
 static GtkWidget *filter_dialog_new(GtkWidget *caller, GtkWidget *filter_te,
-    filter_list_type_t list, construct_args_t *construct_args);
+                                    filter_list_type_t list,
+                                    construct_args_t *construct_args);
 static void filter_dlg_dclick(GtkWidget *dummy, gpointer main_w_arg,
 			      gpointer activate);
 static void filter_dlg_ok_cb(GtkWidget *ok_bt, gpointer dummy);
@@ -72,20 +73,20 @@ static void filter_dlg_save_cb(GtkWidget *save_bt, gpointer parent_w);
 static void filter_dlg_close_cb(GtkWidget *close_bt, gpointer parent_w);
 static void filter_dlg_destroy(GtkWidget *win, gpointer data);
 
-static gint       filter_sel_list_button_cb(GtkWidget *, GdkEventButton *,
-                           gpointer);
-static void       filter_sel_list_cb(GtkWidget *, gpointer);
-static void       filter_list_destroy_cb(GtkWidget *, gpointer);
-static void       filter_new_bt_clicked_cb(GtkWidget *, gpointer);
-static void       filter_chg_bt_clicked_cb(GtkWidget *, gpointer);
-static void       filter_chg_bt_destroy_cb(GtkWidget *, gpointer);
-static void       filter_copy_bt_clicked_cb(GtkWidget *, gpointer);
-static void       filter_copy_bt_destroy_cb(GtkWidget *, gpointer);
-static void       filter_del_bt_clicked_cb(GtkWidget *, gpointer);
-static void       filter_del_bt_destroy_cb(GtkWidget *, gpointer);
-static void       filter_expr_cb(GtkWidget *, gpointer);
-static void       filter_name_te_destroy_cb(GtkWidget *, gpointer);
-static void       filter_filter_te_destroy_cb(GtkWidget *, gpointer);
+static gint filter_sel_list_button_cb(GtkWidget *, GdkEventButton *,
+                                      gpointer);
+static void filter_sel_list_cb(GtkTreeSelection *, gpointer);
+static void filter_list_destroy_cb(GtkWidget *, gpointer);
+static void filter_new_bt_clicked_cb(GtkWidget *, gpointer);
+static void filter_chg_bt_clicked_cb(GtkWidget *, gpointer);
+static void filter_chg_bt_destroy_cb(GtkWidget *, gpointer);
+static void filter_copy_bt_clicked_cb(GtkWidget *, gpointer);
+static void filter_copy_bt_destroy_cb(GtkWidget *, gpointer);
+static void filter_del_bt_clicked_cb(GtkWidget *, gpointer);
+static void filter_del_bt_destroy_cb(GtkWidget *, gpointer);
+static void filter_expr_cb(GtkWidget *, gpointer);
+static void filter_name_te_destroy_cb(GtkWidget *, gpointer);
+static void filter_filter_te_destroy_cb(GtkWidget *, gpointer);
 
 #ifdef HAVE_LIBPCAP
 /* Create a filter dialog for constructing a capture filter.
@@ -100,43 +101,43 @@ static void       filter_filter_te_destroy_cb(GtkWidget *, gpointer);
 void
 capture_filter_construct_cb(GtkWidget *w, gpointer user_data _U_)
 {
-	GtkWidget *caller = gtk_widget_get_toplevel(w);
-	GtkWidget *filter_browse_w;
-	GtkWidget *parent_filter_te;
-	/* No Apply button, and "OK" just sets our text widget, it doesn't
-	   activate it (i.e., it doesn't cause us to try to open the file). */
-	static construct_args_t args = {
-		"Ethereal: Capture Filter",
-		FALSE,
-		FALSE
-	};
-
-	/* Has a filter dialog box already been opened for that top-level
-	   widget? */
-	filter_browse_w = gtk_object_get_data(GTK_OBJECT(caller),
-	    E_FILT_DIALOG_PTR_KEY);
-
-	if (filter_browse_w != NULL) {
-		/* Yes.  Just re-activate that dialog box. */
-		reactivate_window(filter_browse_w);
-		return;
-	}
-
-	/* No.  Get the text entry attached to the button. */
-	parent_filter_te = gtk_object_get_data(GTK_OBJECT(w), E_FILT_TE_PTR_KEY);
-
-	/* Now create a new dialog, without an "Add Expression..." button. */
-	filter_browse_w = filter_dialog_new(caller, parent_filter_te,
-	    CFILTER_LIST, &args);
-
-	/* Set the E_FILT_CALLER_PTR_KEY for the new dialog to point to
-	   our caller. */
-	gtk_object_set_data(GTK_OBJECT(filter_browse_w), E_FILT_CALLER_PTR_KEY,
-	    caller);
-
-	/* Set the E_FILT_DIALOG_PTR_KEY for the caller to point to us */
-	gtk_object_set_data(GTK_OBJECT(caller), E_FILT_DIALOG_PTR_KEY,
-	    filter_browse_w);
+    GtkWidget *caller = gtk_widget_get_toplevel(w);
+    GtkWidget *filter_browse_w;
+    GtkWidget *parent_filter_te;
+    /* No Apply button, and "OK" just sets our text widget, it doesn't
+       activate it (i.e., it doesn't cause us to try to open the file). */
+    static construct_args_t args = {
+        "Ethereal: Capture Filter",
+        FALSE,
+        FALSE
+    };
+
+    /* Has a filter dialog box already been opened for that top-level
+       widget? */
+    filter_browse_w = gtk_object_get_data(GTK_OBJECT(caller),
+                                          E_FILT_DIALOG_PTR_KEY);
+
+    if (filter_browse_w != NULL) {
+        /* Yes.  Just re-activate that dialog box. */
+        reactivate_window(filter_browse_w);
+        return;
+    }
+
+    /* No.  Get the text entry attached to the button. */
+    parent_filter_te = gtk_object_get_data(GTK_OBJECT(w), E_FILT_TE_PTR_KEY);
+
+    /* Now create a new dialog, without an "Add Expression..." button. */
+    filter_browse_w = filter_dialog_new(caller, parent_filter_te,
+                                        CFILTER_LIST, &args);
+
+    /* Set the E_FILT_CALLER_PTR_KEY for the new dialog to point to
+       our caller. */
+    gtk_object_set_data(GTK_OBJECT(filter_browse_w), E_FILT_CALLER_PTR_KEY,
+                        caller);
+
+    /* Set the E_FILT_DIALOG_PTR_KEY for the caller to point to us */
+    gtk_object_set_data(GTK_OBJECT(caller), E_FILT_DIALOG_PTR_KEY,
+                        filter_browse_w);
 }
 #endif
 
@@ -155,38 +156,38 @@ capture_filter_construct_cb(GtkWidget *w, gpointer user_data _U_)
 void
 display_filter_construct_cb(GtkWidget *w, gpointer construct_args_ptr)
 {
-	construct_args_t *construct_args = construct_args_ptr;
-	GtkWidget *caller = gtk_widget_get_toplevel(w);
-	GtkWidget *filter_browse_w;
-	GtkWidget *parent_filter_te;
-
-	/* Has a filter dialog box already been opened for that top-level
-	   widget? */
-	filter_browse_w = gtk_object_get_data(GTK_OBJECT(caller),
-	    E_FILT_DIALOG_PTR_KEY);
-
-	if (filter_browse_w != NULL) {
-		/* Yes.  Just re-activate that dialog box. */
-		reactivate_window(filter_browse_w);
-		return;
-	}
-
-	/* No.  Get the text entry attached to the button. */
-	parent_filter_te = gtk_object_get_data(GTK_OBJECT(w), E_FILT_TE_PTR_KEY);
-
-	/* Now create a new dialog, possibly with an "Apply" button, and
-	   definitely with an "Add Expression..." button. */
-	filter_browse_w = filter_dialog_new(caller, parent_filter_te,
-	    DFILTER_LIST, construct_args);
-
-	/* Set the E_FILT_CALLER_PTR_KEY for the new dialog to point to
-	   our caller. */
-	gtk_object_set_data(GTK_OBJECT(filter_browse_w), E_FILT_CALLER_PTR_KEY,
-	    caller);
-
-	/* Set the E_FILT_DIALOG_PTR_KEY for the caller to point to us */
-	gtk_object_set_data(GTK_OBJECT(caller), E_FILT_DIALOG_PTR_KEY,
-	    filter_browse_w);
+    construct_args_t *construct_args = construct_args_ptr;
+    GtkWidget *caller = gtk_widget_get_toplevel(w);
+    GtkWidget *filter_browse_w;
+    GtkWidget *parent_filter_te;
+
+    /* Has a filter dialog box already been opened for that top-level
+       widget? */
+    filter_browse_w = gtk_object_get_data(GTK_OBJECT(caller),
+                                          E_FILT_DIALOG_PTR_KEY);
+
+    if (filter_browse_w != NULL) {
+        /* Yes.  Just re-activate that dialog box. */
+        reactivate_window(filter_browse_w);
+        return;
+    }
+
+    /* No.  Get the text entry attached to the button. */
+    parent_filter_te = gtk_object_get_data(GTK_OBJECT(w), E_FILT_TE_PTR_KEY);
+
+    /* Now create a new dialog, possibly with an "Apply" button, and
+       definitely with an "Add Expression..." button. */
+    filter_browse_w = filter_dialog_new(caller, parent_filter_te,
+                                        DFILTER_LIST, construct_args);
+
+    /* Set the E_FILT_CALLER_PTR_KEY for the new dialog to point to
+       our caller. */
+    gtk_object_set_data(GTK_OBJECT(filter_browse_w), E_FILT_CALLER_PTR_KEY,
+                        caller);
+
+    /* Set the E_FILT_DIALOG_PTR_KEY for the caller to point to us */
+    gtk_object_set_data(GTK_OBJECT(caller), E_FILT_DIALOG_PTR_KEY,
+                        filter_browse_w);
 }
 
 #ifdef HAVE_LIBPCAP
@@ -197,28 +198,28 @@ static GtkWidget *global_cfilter_w;
 void
 cfilter_dialog_cb(GtkWidget *w _U_)
 {
-	/* No Apply button, and there's no text widget to set, much less
-	   activate, on "OK". */
-	static construct_args_t args = {
-		"Ethereal: Edit Capture Filter List",
-		FALSE,
-		FALSE
-	};
-
-	/* Has a filter dialog box already been opened for editing
-	   capture filters? */
-	if (global_cfilter_w != NULL) {
-		/* Yes.  Just reactivate it. */
-		reactivate_window(global_cfilter_w);
-		return;
-	}
-
-	/*
-	 * No.  Create one; we didn't pop this up as a result of pressing
-	 * a button next to some text entry field, so don't associate it
-	 * with a text entry field.
-	 */
-	global_cfilter_w = filter_dialog_new(NULL, NULL, CFILTER_LIST, &args);
+    /* No Apply button, and there's no text widget to set, much less
+       activate, on "OK". */
+    static construct_args_t args = {
+        "Ethereal: Edit Capture Filter List",
+        FALSE,
+        FALSE
+    };
+
+    /* Has a filter dialog box already been opened for editing
+       capture filters? */
+    if (global_cfilter_w != NULL) {
+        /* Yes.  Just reactivate it. */
+        reactivate_window(global_cfilter_w);
+        return;
+    }
+
+    /*
+     * No.  Create one; we didn't pop this up as a result of pressing
+     * a button next to some text entry field, so don't associate it
+     * with a text entry field.
+     */
+    global_cfilter_w = filter_dialog_new(NULL, NULL, CFILTER_LIST, &args);
 }
 #endif
 
@@ -229,28 +230,28 @@ static GtkWidget *global_dfilter_w;
 void
 dfilter_dialog_cb(GtkWidget *w _U_)
 {
-	/* No Apply button, and there's no text widget to set, much less
-	   activate, on "OK". */
-	static construct_args_t args = {
-		"Ethereal: Edit Display Filter List",
-		FALSE,
-		FALSE
-	};
-
-	/* Has a filter dialog box already been opened for editing
-	   display filters? */
-	if (global_dfilter_w != NULL) {
-		/* Yes.  Just reactivate it. */
-		reactivate_window(global_dfilter_w);
-		return;
-	}
-
-	/*
-	 * No.  Create one; we didn't pop this up as a result of pressing
-	 * a button next to some text entry field, so don't associate it
-	 * with a text entry field.
-	 */
-	global_dfilter_w = filter_dialog_new(NULL, NULL, DFILTER_LIST, &args);
+    /* No Apply button, and there's no text widget to set, much less
+       activate, on "OK". */
+    static construct_args_t args = {
+        "Ethereal: Edit Display Filter List",
+        FALSE,
+        FALSE
+    };
+
+    /* Has a filter dialog box already been opened for editing
+       display filters? */
+    if (global_dfilter_w != NULL) {
+        /* Yes.  Just reactivate it. */
+        reactivate_window(global_dfilter_w);
+        return;
+    }
+
+    /*
+     * No.  Create one; we didn't pop this up as a result of pressing
+     * a button next to some text entry field, so don't associate it
+     * with a text entry field.
+     */
+    global_dfilter_w = filter_dialog_new(NULL, NULL, DFILTER_LIST, &args);
 }
 
 /* List of capture filter dialogs, so that if the list of filters changes
@@ -266,654 +267,664 @@ static GList *dfilter_dialogs;
 static void
 remember_filter_dialog(GtkWidget *main_w, GList **filter_dialogs)
 {
-	*filter_dialogs = g_list_append(*filter_dialogs, main_w);
+    *filter_dialogs = g_list_append(*filter_dialogs, main_w);
 }
 
 /* Remove a filter dialog from the specified list of filter_dialogs. */
 static void
 forget_filter_dialog(GtkWidget *main_w, filter_list_type_t list)
 {
-	switch (list) {
+    switch (list) {
 
-	case CFILTER_LIST:
-		cfilter_dialogs = g_list_remove(cfilter_dialogs, main_w);
-		break;
+    case CFILTER_LIST:
+        cfilter_dialogs = g_list_remove(cfilter_dialogs, main_w);
+        break;
 
-	case DFILTER_LIST:
-		dfilter_dialogs = g_list_remove(dfilter_dialogs, main_w);
-		break;
+    case DFILTER_LIST:
+        dfilter_dialogs = g_list_remove(dfilter_dialogs, main_w);
+        break;
 
-	default:
-		g_assert_not_reached();
-		break;
-	}
+    default:
+        g_assert_not_reached();
+        break;
+    }
 }
 
 /* Get the dialog list corresponding to a particular filter list. */
 static GList *
 get_filter_dialog_list(filter_list_type_t list)
 {
-	switch (list) {
+    switch (list) {
 
-	case CFILTER_LIST:
-		return cfilter_dialogs;
+    case CFILTER_LIST:
+        return cfilter_dialogs;
 
-	case DFILTER_LIST:
-		return dfilter_dialogs;
+    case DFILTER_LIST:
+        return dfilter_dialogs;
 
-	default:
-		g_assert_not_reached();
-		return NULL;
-	}
+    default:
+        g_assert_not_reached();
+        return NULL;
+    }
 }
 
 static GtkWidget *
 filter_dialog_new(GtkWidget *caller _U_, GtkWidget *parent_filter_te,
-    filter_list_type_t list, construct_args_t *construct_args)
+                  filter_list_type_t list, construct_args_t *construct_args)
 {
-	GtkWidget	*main_w,		/* main window */
-			*main_vb,		/* main container */
-			*bbox,			/* button container */
-			*ok_bt,			/* "OK" button */
-			*apply_bt,		/* "Apply" button */
-			*save_bt,		/* "Save" button */
-			*close_bt;		/* "Cancel" button */
-	GtkWidget	*filter_pg = NULL;	/* filter settings box */
-	GtkWidget	*top_hb,
-			*list_bb,
-			*new_bt,
-			*chg_bt,
-			*copy_bt,
-			*del_bt,
-			*filter_sc,
-			*filter_l,
-			*nl_item,
-			*nl_lb,
-			*middle_hb,
-			*name_lb,
-			*name_te,
-			*bottom_hb,
-			*filter_lb,
-			*filter_te,
-			*add_expression_bt;
-	GtkWidget	*l_select = NULL;
-	GList		*fl_entry;
-	filter_def	*filt;
-	const gchar	*filter_te_str = NULL;
-	GList		**filter_dialogs;
-	static filter_list_type_t cfilter_list = CFILTER_LIST;
-	static filter_list_type_t dfilter_list = DFILTER_LIST;
-	filter_list_type_t *filter_list_p;
-
-	/* Get a pointer to a static variable holding the type of filter on
-	   which we're working, so we can pass that pointer to callback
-	   routines. */
-	switch (list) {
-
-	case CFILTER_LIST:
-		filter_dialogs = &cfilter_dialogs;
-		filter_list_p = &cfilter_list;
-		break;
-
-	case DFILTER_LIST:
-		filter_dialogs = &dfilter_dialogs;
-		filter_list_p = &dfilter_list;
-		break;
-
-	default:
-		g_assert_not_reached();
-		filter_dialogs = NULL;
-		filter_list_p = NULL;
-		break;
-	}
-
-	main_w = dlg_window_new(construct_args->title);
-	gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_CONSTRUCT_ARGS_KEY,
-	    construct_args);
-
-	/* Call a handler when we're destroyed, so we can inform
-	   our caller, if any, that we've been destroyed. */
-	g_signal_connect(G_OBJECT(main_w), "destroy",
-                         G_CALLBACK(filter_dlg_destroy), filter_list_p);
-
-	main_vb = gtk_vbox_new(FALSE, 5);
-	gtk_container_border_width(GTK_CONTAINER(main_vb), 5);
-	gtk_container_add(GTK_CONTAINER(main_w), main_vb);
-	gtk_widget_show(main_vb);
-
-	/* Make sure everything is set up */
-	if (parent_filter_te)
-		filter_te_str = gtk_entry_get_text(GTK_ENTRY(parent_filter_te));
-
-	/* Container for each row of widgets */
-	filter_pg = gtk_vbox_new(FALSE, 5);
-	gtk_container_border_width(GTK_CONTAINER(filter_pg), 5);
-	gtk_widget_show(filter_pg);
-
-	/* Top row: Filter list and buttons */
-	top_hb = gtk_hbox_new(FALSE, 5);
-	gtk_container_add(GTK_CONTAINER(filter_pg), top_hb);
-	gtk_widget_show(top_hb);
-
-	list_bb = gtk_vbutton_box_new();
-	gtk_button_box_set_layout (GTK_BUTTON_BOX (list_bb), GTK_BUTTONBOX_START);
-	gtk_container_add(GTK_CONTAINER(top_hb), list_bb);
-	gtk_widget_show(list_bb);
-
-	new_bt = gtk_button_new_from_stock(GTK_STOCK_NEW);
-	g_signal_connect(G_OBJECT(new_bt), "clicked",
-                         G_CALLBACK(filter_new_bt_clicked_cb), filter_list_p);
-	gtk_container_add(GTK_CONTAINER(list_bb), new_bt);
-	gtk_widget_show(new_bt);
-
-	chg_bt = gtk_button_new_with_label ("Change");
-	gtk_widget_set_sensitive(chg_bt, FALSE);
-	g_signal_connect(G_OBJECT(chg_bt), "clicked",
-                         G_CALLBACK(filter_chg_bt_clicked_cb), filter_list_p);
-	gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_CHG_BT_KEY, chg_bt);
-	g_signal_connect(G_OBJECT(chg_bt), "destroy",
-                         G_CALLBACK(filter_chg_bt_destroy_cb), NULL);
-	gtk_container_add(GTK_CONTAINER(list_bb), chg_bt);
-	gtk_widget_show(chg_bt);
-
-	copy_bt = gtk_button_new_from_stock(GTK_STOCK_COPY);
-	gtk_widget_set_sensitive(copy_bt, FALSE);
-	g_signal_connect(G_OBJECT(copy_bt), "clicked",
-                         G_CALLBACK(filter_copy_bt_clicked_cb), filter_list_p);
-	gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_COPY_BT_KEY, copy_bt);
-	g_signal_connect(G_OBJECT(copy_bt), "destroy",
-                         G_CALLBACK(filter_copy_bt_destroy_cb), NULL);
-	gtk_container_add(GTK_CONTAINER(list_bb), copy_bt);
-	gtk_widget_show(copy_bt);
-
-	del_bt = gtk_button_new_from_stock(GTK_STOCK_DELETE);
-	gtk_widget_set_sensitive(del_bt, FALSE);
-	g_signal_connect(G_OBJECT(del_bt), "clicked",
-                         G_CALLBACK(filter_del_bt_clicked_cb), filter_list_p);
-	gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_DEL_BT_KEY, del_bt);
-	g_signal_connect(G_OBJECT(del_bt), "destroy",
-                         G_CALLBACK(filter_del_bt_destroy_cb), NULL);
-	gtk_container_add(GTK_CONTAINER(list_bb), del_bt);
-	gtk_widget_show(del_bt);
-
-	if (list == DFILTER_LIST) {
-		/* Create the "Add Expression..." button, to pop up a dialog
-		   for constructing filter comparison expressions. */
-		add_expression_bt = gtk_button_new_with_label("Add Expression...");
-		g_signal_connect(G_OBJECT(add_expression_bt), "clicked",
-                                 G_CALLBACK(filter_expr_cb), main_w);
-		gtk_container_add(GTK_CONTAINER(list_bb), add_expression_bt);
-		gtk_widget_show(add_expression_bt);
-	}
-
-	filter_sc = gtk_scrolled_window_new(NULL, NULL);
-	gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(filter_sc),
-	    GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
-	gtk_widget_set_size_request(filter_sc, 250, 150);
-	gtk_container_add(GTK_CONTAINER(top_hb), filter_sc);
-	gtk_widget_show(filter_sc);
-
-	filter_l = gtk_list_new();
-	gtk_list_set_selection_mode(GTK_LIST(filter_l), GTK_SELECTION_SINGLE);
-	g_signal_connect(G_OBJECT(filter_l), "selection_changed",
-                         G_CALLBACK(filter_sel_list_cb), filter_pg);
-	gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY, filter_l);
-	g_signal_connect(G_OBJECT(filter_l), "destroy",
-                         G_CALLBACK(filter_list_destroy_cb), NULL);
-	gtk_scrolled_window_add_with_viewport(GTK_SCROLLED_WINDOW(filter_sc),
-	    filter_l);
-	gtk_widget_show(filter_l);
-
-	gtk_object_set_data(GTK_OBJECT(filter_l), E_FILT_DBLFUNC_KEY, filter_dlg_dclick);
-	gtk_object_set_data(GTK_OBJECT(filter_l), E_FILT_DBLARG_KEY, main_w);
-	/* This is a Boolean, but we make it a non-null pointer for TRUE
-	   and a null pointer for FALSE, as object data is a pointer. */
-	gtk_object_set_data(GTK_OBJECT(filter_l), E_FILT_DBLACTIVATE_KEY,
-	    construct_args->activate_on_ok? "" : NULL);
-
-	fl_entry = get_filter_list_first(list);
-	while (fl_entry != NULL) {
-		filt    = (filter_def *) fl_entry->data;
-		nl_lb   = gtk_label_new(filt->name);
-		nl_item = gtk_list_item_new();
-
-		g_signal_connect(G_OBJECT(nl_item), "button_press_event",
-                                 G_CALLBACK(filter_sel_list_button_cb),
-                                 filter_l);
-
-		gtk_misc_set_alignment (GTK_MISC (nl_lb), 0.0, 0.5);
-		gtk_container_add(GTK_CONTAINER(nl_item), nl_lb);
-		gtk_widget_show(nl_lb);
-		gtk_container_add(GTK_CONTAINER(filter_l), nl_item);
-		gtk_widget_show(nl_item);
-		gtk_object_set_data(GTK_OBJECT(nl_item), E_FILT_LBL_KEY, nl_lb);
-		gtk_object_set_data(GTK_OBJECT(nl_item), E_FILT_LIST_ITEM_MODEL_KEY,
-		    fl_entry);
-
-		if (filter_te_str && filt->strval) {
-			if (strcmp(filter_te_str, filt->strval) == 0)
-				l_select = nl_item;
-		}
-
-		fl_entry = fl_entry->next;
-	}
-
-	/* Middle row: Filter name entry */
-	middle_hb = gtk_hbox_new(FALSE, 5);
-	gtk_container_add(GTK_CONTAINER(filter_pg), middle_hb);
-	gtk_widget_show(middle_hb);
-
-	name_lb = gtk_label_new("Filter name:");
-	gtk_box_pack_start(GTK_BOX(middle_hb), name_lb, FALSE, FALSE, 3);
-	gtk_widget_show(name_lb);
-
-	name_te = gtk_entry_new();
-	gtk_box_pack_start(GTK_BOX(middle_hb), name_te, TRUE, TRUE, 3);
-	gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_NAME_TE_KEY, name_te);
-	g_signal_connect(G_OBJECT(name_te), "destroy",
-                         G_CALLBACK(filter_name_te_destroy_cb), NULL);
-	gtk_widget_show(name_te);
-
-	/* Bottom row: Filter text entry */
-	bottom_hb = gtk_hbox_new(FALSE, 5);
-	gtk_container_add(GTK_CONTAINER(filter_pg), bottom_hb);
-	gtk_widget_show(bottom_hb);
-
-	filter_lb = gtk_label_new("Filter string:");
-	gtk_box_pack_start(GTK_BOX(bottom_hb), filter_lb, FALSE, FALSE, 3);
-	gtk_widget_show(filter_lb);
-
-	filter_te = gtk_entry_new();
-	gtk_box_pack_start(GTK_BOX(bottom_hb), filter_te, TRUE, TRUE, 3);
-	gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_FILTER_TE_KEY, filter_te);
-
-	g_signal_connect(G_OBJECT(filter_te), "destroy",
-                         G_CALLBACK(filter_filter_te_destroy_cb), NULL);
-	gtk_widget_show(filter_te);
-
-	if (l_select) {
-		gtk_list_select_child(GTK_LIST(filter_l), l_select);
-	} else if (filter_te_str && filter_te_str[0]) {
-		gtk_entry_set_text(GTK_ENTRY(name_te), "New filter");
-		gtk_entry_set_text(GTK_ENTRY(filter_te), filter_te_str);
-	}
-
-	gtk_box_pack_start(GTK_BOX(main_vb), filter_pg, TRUE, TRUE, 0);
-	gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_PARENT_FILTER_TE_KEY,
-	    parent_filter_te);
-
-	bbox = gtk_hbutton_box_new();
-	gtk_button_box_set_layout (GTK_BUTTON_BOX (bbox), GTK_BUTTONBOX_END);
-	gtk_button_box_set_spacing(GTK_BUTTON_BOX(bbox), 5);
-	gtk_container_add(GTK_CONTAINER(main_vb), bbox);
-	gtk_widget_show(bbox);
-
-	if (parent_filter_te != NULL) {
-		/*
-		 * We have a filter text entry that we can fill in if
-		 * the "OK" button is clicked, so put in an "OK" button.
-		 */
-		ok_bt = gtk_button_new_from_stock(GTK_STOCK_OK);
-		g_signal_connect(G_OBJECT(ok_bt), "clicked",
-                                 G_CALLBACK(filter_dlg_ok_cb), NULL);
-		GTK_WIDGET_SET_FLAGS(ok_bt, GTK_CAN_DEFAULT);
-		gtk_box_pack_start(GTK_BOX(bbox), ok_bt, TRUE, TRUE, 0);
-		gtk_widget_grab_default(ok_bt);
-		gtk_widget_show(ok_bt);
-
-		/* Catch the "activate" signal on the filter name and filter
-		   expression text entries, so that if the user types Return
-		   there, we act as if the "OK" button had been selected, as
-		   happens if Return is typed if some widget that *doesn't*
-		   handle the Return key has the input focus. */
-		dlg_set_activate(name_te, ok_bt);
-		dlg_set_activate(filter_te, ok_bt);
-	}
-
-	if (construct_args->wants_apply_button) {
-		apply_bt = gtk_button_new_from_stock(GTK_STOCK_APPLY);
-		g_signal_connect(G_OBJECT(apply_bt), "clicked",
-                                 G_CALLBACK(filter_dlg_apply_cb), NULL);
-		GTK_WIDGET_SET_FLAGS(apply_bt, GTK_CAN_DEFAULT);
-		gtk_box_pack_start(GTK_BOX(bbox), apply_bt, TRUE, TRUE, 0);
-		gtk_widget_show(apply_bt);
-	}
-
-	save_bt = gtk_button_new_from_stock(GTK_STOCK_SAVE);
-	g_signal_connect(G_OBJECT(save_bt), "clicked",
-                         G_CALLBACK(filter_dlg_save_cb), filter_list_p);
-	GTK_WIDGET_SET_FLAGS(save_bt, GTK_CAN_DEFAULT);
-	gtk_box_pack_start(GTK_BOX(bbox), save_bt, TRUE, TRUE, 0);
-	gtk_widget_show(save_bt);
-
-	close_bt = gtk_button_new_from_stock(GTK_STOCK_CLOSE);
-	g_signal_connect(G_OBJECT(close_bt), "clicked",
-                         G_CALLBACK(filter_dlg_close_cb), GTK_OBJECT(main_w));
-	GTK_WIDGET_SET_FLAGS(close_bt, GTK_CAN_DEFAULT);
-	gtk_box_pack_start(GTK_BOX(bbox), close_bt, TRUE, TRUE, 0);
-	gtk_widget_show(close_bt);
-
-	/*
-	 * Catch the "key_press_event" signal in the window, so that we can
-	 * catch the ESC key being pressed and act as if the "Close" button
-	 * had been selected.
-	 */
-	dlg_set_cancel(main_w, close_bt);
-
-	remember_filter_dialog(main_w, filter_dialogs);
-
-	gtk_widget_show(main_w);
-
-	return main_w;
+    GtkWidget                *main_w,           /* main window */
+                             *main_vb,          /* main container */
+                             *bbox,             /* button container */
+                             *ok_bt,            /* "OK" button */
+                             *apply_bt,         /* "Apply" button */
+                             *save_bt,          /* "Save" button */
+                             *close_bt;         /* "Cancel" button */
+    GtkWidget                *filter_pg = NULL; /* filter settings box */
+    GtkWidget                *top_hb,
+                             *list_bb,
+                             *new_bt,
+                             *chg_bt,
+                             *copy_bt,
+                             *del_bt,
+                             *filter_sc,
+                             *filter_l,
+                             *middle_hb,
+                             *name_lb,
+                             *name_te,
+                             *bottom_hb,
+                             *filter_lb,
+                             *filter_te,
+                             *add_expression_bt;
+    gboolean                  l_select = FALSE;
+    GList                    *fl_entry;
+    filter_def               *filt;
+    const gchar              *filter_te_str = NULL;
+    GList                   **filter_dialogs;
+    static filter_list_type_t cfilter_list = CFILTER_LIST;
+    static filter_list_type_t dfilter_list = DFILTER_LIST;
+    filter_list_type_t       *filter_list_p;
+    GtkListStore             *store;
+    GtkCellRenderer          *renderer;
+    GtkTreeViewColumn        *column;
+    GtkTreeSelection         *sel;
+    GtkTreeIter               iter;
+
+    /* Get a pointer to a static variable holding the type of filter on
+       which we're working, so we can pass that pointer to callback
+       routines. */
+    switch (list) {
+
+    case CFILTER_LIST:
+        filter_dialogs = &cfilter_dialogs;
+        filter_list_p = &cfilter_list;
+        break;
+
+    case DFILTER_LIST:
+        filter_dialogs = &dfilter_dialogs;
+        filter_list_p = &dfilter_list;
+        break;
+
+    default:
+        g_assert_not_reached();
+        filter_dialogs = NULL;
+        filter_list_p = NULL;
+        break;
+    }
+
+    main_w = dlg_window_new(construct_args->title);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_CONSTRUCT_ARGS_KEY,
+                        construct_args);
+
+    /* Call a handler when we're destroyed, so we can inform
+       our caller, if any, that we've been destroyed. */
+    g_signal_connect(G_OBJECT(main_w), "destroy",
+                     G_CALLBACK(filter_dlg_destroy), filter_list_p);
+
+    main_vb = gtk_vbox_new(FALSE, 5);
+    gtk_container_border_width(GTK_CONTAINER(main_vb), 5);
+    gtk_container_add(GTK_CONTAINER(main_w), main_vb);
+    gtk_widget_show(main_vb);
+
+    /* Make sure everything is set up */
+    if (parent_filter_te)
+        filter_te_str = gtk_entry_get_text(GTK_ENTRY(parent_filter_te));
+
+    /* Container for each row of widgets */
+    filter_pg = gtk_vbox_new(FALSE, 5);
+    gtk_container_border_width(GTK_CONTAINER(filter_pg), 5);
+    gtk_widget_show(filter_pg);
+
+    /* Top row: Filter list and buttons */
+    top_hb = gtk_hbox_new(FALSE, 5);
+    gtk_container_add(GTK_CONTAINER(filter_pg), top_hb);
+    gtk_widget_show(top_hb);
+
+    list_bb = gtk_vbutton_box_new();
+    gtk_button_box_set_layout (GTK_BUTTON_BOX (list_bb), GTK_BUTTONBOX_START);
+    gtk_container_add(GTK_CONTAINER(top_hb), list_bb);
+    gtk_widget_show(list_bb);
+
+    new_bt = gtk_button_new_from_stock(GTK_STOCK_NEW);
+    g_signal_connect(G_OBJECT(new_bt), "clicked",
+                     G_CALLBACK(filter_new_bt_clicked_cb), filter_list_p);
+    gtk_container_add(GTK_CONTAINER(list_bb), new_bt);
+    gtk_widget_show(new_bt);
+
+    chg_bt = gtk_button_new_with_label ("Change");
+    gtk_widget_set_sensitive(chg_bt, FALSE);
+    g_signal_connect(G_OBJECT(chg_bt), "clicked",
+                     G_CALLBACK(filter_chg_bt_clicked_cb), filter_list_p);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_CHG_BT_KEY, chg_bt);
+    g_signal_connect(G_OBJECT(chg_bt), "destroy",
+                     G_CALLBACK(filter_chg_bt_destroy_cb), NULL);
+    gtk_container_add(GTK_CONTAINER(list_bb), chg_bt);
+    gtk_widget_show(chg_bt);
+
+    copy_bt = gtk_button_new_from_stock(GTK_STOCK_COPY);
+    gtk_widget_set_sensitive(copy_bt, FALSE);
+    g_signal_connect(G_OBJECT(copy_bt), "clicked",
+                     G_CALLBACK(filter_copy_bt_clicked_cb), filter_list_p);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_COPY_BT_KEY, copy_bt);
+    g_signal_connect(G_OBJECT(copy_bt), "destroy",
+                     G_CALLBACK(filter_copy_bt_destroy_cb), NULL);
+    gtk_container_add(GTK_CONTAINER(list_bb), copy_bt);
+    gtk_widget_show(copy_bt);
+
+    del_bt = gtk_button_new_from_stock(GTK_STOCK_DELETE);
+    gtk_widget_set_sensitive(del_bt, FALSE);
+    g_signal_connect(G_OBJECT(del_bt), "clicked",
+                     G_CALLBACK(filter_del_bt_clicked_cb), filter_list_p);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_DEL_BT_KEY, del_bt);
+    g_signal_connect(G_OBJECT(del_bt), "destroy",
+                     G_CALLBACK(filter_del_bt_destroy_cb), NULL);
+    gtk_container_add(GTK_CONTAINER(list_bb), del_bt);
+    gtk_widget_show(del_bt);
+
+    if (list == DFILTER_LIST) {
+        /* Create the "Add Expression..." button, to pop up a dialog
+           for constructing filter comparison expressions. */
+        add_expression_bt = gtk_button_new_with_label("Add Expression...");
+        g_signal_connect(G_OBJECT(add_expression_bt), "clicked",
+                         G_CALLBACK(filter_expr_cb), main_w);
+        gtk_container_add(GTK_CONTAINER(list_bb), add_expression_bt);
+        gtk_widget_show(add_expression_bt);
+    }
+
+    filter_sc = gtk_scrolled_window_new(NULL, NULL);
+    gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(filter_sc),
+                                   GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
+    gtk_widget_set_size_request(filter_sc, 250, 150);
+    gtk_container_add(GTK_CONTAINER(top_hb), filter_sc);
+    gtk_widget_show(filter_sc);
+
+    store = gtk_list_store_new(2, G_TYPE_STRING, G_TYPE_POINTER);
+    filter_l = gtk_tree_view_new_with_model(GTK_TREE_MODEL(store));
+    gtk_tree_view_set_rules_hint(GTK_TREE_VIEW(filter_l), TRUE);
+    gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(filter_l), FALSE);
+    renderer = gtk_cell_renderer_text_new();
+    column = gtk_tree_view_column_new_with_attributes("", renderer, "text",
+                                                      0, NULL);
+    gtk_tree_view_column_set_sort_column_id(column, 0);
+    gtk_tree_view_append_column(GTK_TREE_VIEW(filter_l), column);
+    sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(filter_l));
+    gtk_tree_selection_set_mode(sel, GTK_SELECTION_SINGLE);
+    g_signal_connect(G_OBJECT(sel), "changed",
+                     G_CALLBACK(filter_sel_list_cb), filter_pg);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY, filter_l);
+    g_signal_connect(G_OBJECT(filter_l), "destroy",
+                     G_CALLBACK(filter_list_destroy_cb), NULL);
+    g_signal_connect(G_OBJECT(filter_l), "button_press_event",
+                     G_CALLBACK(filter_sel_list_button_cb), NULL);
+    gtk_scrolled_window_add_with_viewport(GTK_SCROLLED_WINDOW(filter_sc),
+                                          filter_l);
+    gtk_widget_show(filter_l);
+
+    gtk_object_set_data(GTK_OBJECT(filter_l), E_FILT_DBLFUNC_KEY,
+                        filter_dlg_dclick);
+    gtk_object_set_data(GTK_OBJECT(filter_l), E_FILT_DBLARG_KEY, main_w);
+    /* This is a Boolean, but we make it a non-null pointer for TRUE
+       and a null pointer for FALSE, as object data is a pointer. */
+    gtk_object_set_data(GTK_OBJECT(filter_l), E_FILT_DBLACTIVATE_KEY,
+                        construct_args->activate_on_ok? "" : NULL);
+
+    fl_entry = get_filter_list_first(list);
+    while (fl_entry != NULL) {
+        filt    = (filter_def *) fl_entry->data;
+        gtk_list_store_append(store, &iter);
+        gtk_list_store_set(store, &iter, 0, filt->name,
+                           1, fl_entry, -1);
+        if (filter_te_str && filt->strval) {
+            if (strcmp(filter_te_str, filt->strval) == 0)
+            {
+                gtk_tree_selection_select_iter(sel, &iter);
+                l_select = TRUE;
+            }
+        }
+
+        fl_entry = fl_entry->next;
+    }
+    g_object_unref(G_OBJECT(store));
+
+    /* Middle row: Filter name entry */
+    middle_hb = gtk_hbox_new(FALSE, 5);
+    gtk_container_add(GTK_CONTAINER(filter_pg), middle_hb);
+    gtk_widget_show(middle_hb);
+
+    name_lb = gtk_label_new("Filter name:");
+    gtk_box_pack_start(GTK_BOX(middle_hb), name_lb, FALSE, FALSE, 3);
+    gtk_widget_show(name_lb);
+
+    name_te = gtk_entry_new();
+    gtk_box_pack_start(GTK_BOX(middle_hb), name_te, TRUE, TRUE, 3);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_NAME_TE_KEY, name_te);
+    g_signal_connect(G_OBJECT(name_te), "destroy",
+                     G_CALLBACK(filter_name_te_destroy_cb), NULL);
+    gtk_widget_show(name_te);
+
+    /* Bottom row: Filter text entry */
+    bottom_hb = gtk_hbox_new(FALSE, 5);
+    gtk_container_add(GTK_CONTAINER(filter_pg), bottom_hb);
+    gtk_widget_show(bottom_hb);
+
+    filter_lb = gtk_label_new("Filter string:");
+    gtk_box_pack_start(GTK_BOX(bottom_hb), filter_lb, FALSE, FALSE, 3);
+    gtk_widget_show(filter_lb);
+
+    filter_te = gtk_entry_new();
+    gtk_box_pack_start(GTK_BOX(bottom_hb), filter_te, TRUE, TRUE, 3);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_FILTER_TE_KEY, filter_te);
+
+    g_signal_connect(G_OBJECT(filter_te), "destroy",
+                     G_CALLBACK(filter_filter_te_destroy_cb), NULL);
+    gtk_widget_show(filter_te);
+
+    if (!l_select && filter_te_str && filter_te_str[0]) {
+        gtk_entry_set_text(GTK_ENTRY(name_te), "New filter");
+        gtk_entry_set_text(GTK_ENTRY(filter_te), filter_te_str);
+    }
+
+    gtk_box_pack_start(GTK_BOX(main_vb), filter_pg, TRUE, TRUE, 0);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_PARENT_FILTER_TE_KEY,
+                        parent_filter_te);
+
+    bbox = gtk_hbutton_box_new();
+    gtk_button_box_set_layout (GTK_BUTTON_BOX (bbox), GTK_BUTTONBOX_END);
+    gtk_button_box_set_spacing(GTK_BUTTON_BOX(bbox), 5);
+    gtk_container_add(GTK_CONTAINER(main_vb), bbox);
+    gtk_widget_show(bbox);
+
+    if (parent_filter_te != NULL) {
+        /*
+         * We have a filter text entry that we can fill in if
+         * the "OK" button is clicked, so put in an "OK" button.
+         */
+        ok_bt = gtk_button_new_from_stock(GTK_STOCK_OK);
+        g_signal_connect(G_OBJECT(ok_bt), "clicked",
+                         G_CALLBACK(filter_dlg_ok_cb), NULL);
+        GTK_WIDGET_SET_FLAGS(ok_bt, GTK_CAN_DEFAULT);
+        gtk_box_pack_start(GTK_BOX(bbox), ok_bt, TRUE, TRUE, 0);
+        gtk_widget_grab_default(ok_bt);
+        gtk_widget_show(ok_bt);
+
+        /* Catch the "activate" signal on the filter name and filter
+           expression text entries, so that if the user types Return
+           there, we act as if the "OK" button had been selected, as
+           happens if Return is typed if some widget that *doesn't*
+           handle the Return key has the input focus. */
+        dlg_set_activate(name_te, ok_bt);
+        dlg_set_activate(filter_te, ok_bt);
+    }
+
+    if (construct_args->wants_apply_button) {
+        apply_bt = gtk_button_new_from_stock(GTK_STOCK_APPLY);
+        g_signal_connect(G_OBJECT(apply_bt), "clicked",
+                         G_CALLBACK(filter_dlg_apply_cb), NULL);
+        GTK_WIDGET_SET_FLAGS(apply_bt, GTK_CAN_DEFAULT);
+        gtk_box_pack_start(GTK_BOX(bbox), apply_bt, TRUE, TRUE, 0);
+        gtk_widget_show(apply_bt);
+    }
+
+    save_bt = gtk_button_new_from_stock(GTK_STOCK_SAVE);
+    g_signal_connect(G_OBJECT(save_bt), "clicked",
+                     G_CALLBACK(filter_dlg_save_cb), filter_list_p);
+    GTK_WIDGET_SET_FLAGS(save_bt, GTK_CAN_DEFAULT);
+    gtk_box_pack_start(GTK_BOX(bbox), save_bt, TRUE, TRUE, 0);
+    gtk_widget_show(save_bt);
+
+    close_bt = gtk_button_new_from_stock(GTK_STOCK_CLOSE);
+    g_signal_connect(G_OBJECT(close_bt), "clicked",
+                     G_CALLBACK(filter_dlg_close_cb), GTK_OBJECT(main_w));
+    GTK_WIDGET_SET_FLAGS(close_bt, GTK_CAN_DEFAULT);
+    gtk_box_pack_start(GTK_BOX(bbox), close_bt, TRUE, TRUE, 0);
+    gtk_widget_show(close_bt);
+
+    /*
+     * Catch the "key_press_event" signal in the window, so that we can
+     * catch the ESC key being pressed and act as if the "Close" button
+     * had been selected.
+     */
+    dlg_set_cancel(main_w, close_bt);
+
+    remember_filter_dialog(main_w, filter_dialogs);
+
+    gtk_widget_show(main_w);
+
+    return main_w;
 }
 
 static void
 filter_dlg_dclick(GtkWidget *filter_l, gpointer main_w_arg, gpointer activate)
 {
-	GtkWidget  *main_w = GTK_WIDGET(main_w_arg);
-	GtkWidget  *parent_filter_te =
-	    gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_PARENT_FILTER_TE_KEY);
-	GList      *flp, *sl;
-	GtkObject  *l_item;
-	filter_def *filt;
-
-	if (parent_filter_te != NULL) {
-		/*
-		 * We have a text entry widget associated with this dialog
-		 * box; is one of the filters in the list selected?
-		 */
-		sl = GTK_LIST(filter_l)->selection;
-		if (sl != NULL) {
-			/*
-			 * Yes.  Is there a filter definition for that filter?
-			 */
-			l_item = GTK_OBJECT(sl->data);
-			flp    = (GList *) gtk_object_get_data(l_item, E_FILT_LIST_ITEM_MODEL_KEY);
-			if (flp) {
-				/*
-				 * Yes - put it in the text entry widget.
-				 */
-				filt = (filter_def *) flp->data;
-				gtk_entry_set_text(GTK_ENTRY(parent_filter_te),
-				    filt->strval);
-
-				/*
-				 * Are we supposed to cause the filter we
-				 * put there to be applied?
-				 */
-				if (activate != NULL) {
-					/*
-					 * Yes - do so.
-					 */
-					gtk_signal_emit_by_name(GTK_OBJECT(parent_filter_te),
-					    "activate");
-				}
-			}
-		}
-	}
-
-	gtk_widget_destroy(main_w);
+    GtkWidget        *main_w = GTK_WIDGET(main_w_arg);
+    GtkWidget        *parent_filter_te =
+        gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_PARENT_FILTER_TE_KEY);
+    GList            *flp;
+    filter_def       *filt;
+    GtkTreeSelection *sel;
+    GtkTreeModel     *model;
+    GtkTreeIter       iter;
+
+    sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(filter_l));
+
+    if (parent_filter_te != NULL) {
+        /*
+         * We have a text entry widget associated with this dialog
+         * box; is one of the filters in the list selected?
+         */
+
+        /* if something was selected */
+        if (gtk_tree_selection_get_selected(sel, &model, &iter)) {
+            /*
+             * Yes.  Is there a filter definition for that filter?
+             */
+            gtk_tree_model_get(model, &iter, 1, &flp, -1);
+            if (flp) {
+                /*
+                 * Yes - put it in the text entry widget.
+                 */
+                filt = (filter_def *) flp->data;
+                gtk_entry_set_text(GTK_ENTRY(parent_filter_te),
+                                   filt->strval);
+
+                /*
+                 * Are we supposed to cause the filter we
+                 * put there to be applied?
+                 */
+                if (activate != NULL) {
+                    /*
+                     * Yes - do so.
+                     */
+                    gtk_signal_emit_by_name(GTK_OBJECT(parent_filter_te),
+                                            "activate");
+                }
+            }
+        }
+    }
+
+    gtk_widget_destroy(main_w);
 }
 
 static void
 filter_dlg_ok_cb(GtkWidget *ok_bt, gpointer data _U_)
 {
-	/*
-	 * Destroy the dialog box and apply the filter.
-	 */
-	filter_apply(gtk_widget_get_toplevel(ok_bt), TRUE);
+    /*
+     * Destroy the dialog box and apply the filter.
+     */
+    filter_apply(gtk_widget_get_toplevel(ok_bt), TRUE);
 }
 
 static void
 filter_dlg_apply_cb(GtkWidget *apply_bt, gpointer dummy _U_)
 {
-	/*
-         * Apply the filter, but don't destroy the dialog box.
-         */
-        filter_apply(gtk_widget_get_toplevel(apply_bt), FALSE);
+    /*
+     * Apply the filter, but don't destroy the dialog box.
+     */
+    filter_apply(gtk_widget_get_toplevel(apply_bt), FALSE);
 }
 
 static void
 filter_apply(GtkWidget *main_w, gboolean destroy)
 {
-	construct_args_t *construct_args =
-	    gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_CONSTRUCT_ARGS_KEY);
-	GtkWidget  *parent_filter_te =
-	    gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_PARENT_FILTER_TE_KEY);
-	GtkWidget   *filter_te;
-	const gchar *filter_string;
-
-	if (parent_filter_te != NULL) {
-		/*
-		 * We have a text entry widget associated with this dialog
-		 * box; put the filter in our text entry widget into that
-		 * text entry widget.
-		 */
-		filter_te = gtk_object_get_data(GTK_OBJECT(main_w),
-		    E_FILT_FILTER_TE_KEY);
-		filter_string = gtk_entry_get_text(GTK_ENTRY(filter_te));
-		gtk_entry_set_text(GTK_ENTRY(parent_filter_te), filter_string);
+    construct_args_t *construct_args =
+        gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_CONSTRUCT_ARGS_KEY);
+    GtkWidget  *parent_filter_te =
+        gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_PARENT_FILTER_TE_KEY);
+    GtkWidget   *filter_te;
+    const gchar *filter_string;
+
+    if (parent_filter_te != NULL) {
+        /*
+         * We have a text entry widget associated with this dialog
+         * box; put the filter in our text entry widget into that
+         * text entry widget.
+         */
+        filter_te = gtk_object_get_data(GTK_OBJECT(main_w),
+                                        E_FILT_FILTER_TE_KEY);
+        filter_string = gtk_entry_get_text(GTK_ENTRY(filter_te));
+        gtk_entry_set_text(GTK_ENTRY(parent_filter_te), filter_string);
 
-        }
+    }
 
-        if (destroy) {
-                /*
-                 * Destroy the filter dialog box.
-                 */
-                gtk_widget_destroy(main_w);
-        }
+    if (destroy) {
+        /*
+         * Destroy the filter dialog box.
+         */
+        gtk_widget_destroy(main_w);
+    }
 
-        if (parent_filter_te != NULL) {
-                /*
-                 * We have a text entry widget associated with this dialog
-                 * box; activate that widget to cause the filter we put
-                 * there to be applied if we're supposed to do so.
-                 *
-                 * We do this after dismissing the filter dialog box,
-                 * as activating the widget the dialog box to which
-                 * it belongs to be dismissed, and that may cause it
-                 * to destroy our dialog box if the filter succeeds.
-                 * This means that our subsequent attempt to destroy
-                 * it will fail.
-                 *
-                 * We don't know whether it'll destroy our dialog box,
-                 * so we can't rely on it to do so.  Instead, we
-                 * destroy it ourselves, which will clear the
-                 * E_FILT_DIALOG_PTR_KEY pointer for their dialog box,
-                 * meaning they won't think it has one and won't try
-                 * to destroy it.
-                 */
-		if (construct_args->activate_on_ok) {
-			gtk_signal_emit_by_name(GTK_OBJECT(parent_filter_te),
-			    "activate");
-		}
-	}
+    if (parent_filter_te != NULL) {
+        /*
+         * We have a text entry widget associated with this dialog
+         * box; activate that widget to cause the filter we put
+         * there to be applied if we're supposed to do so.
+         *
+         * We do this after dismissing the filter dialog box,
+         * as activating the widget the dialog box to which
+         * it belongs to be dismissed, and that may cause it
+         * to destroy our dialog box if the filter succeeds.
+         * This means that our subsequent attempt to destroy
+         * it will fail.
+         *
+         * We don't know whether it'll destroy our dialog box,
+         * so we can't rely on it to do so.  Instead, we
+         * destroy it ourselves, which will clear the
+         * E_FILT_DIALOG_PTR_KEY pointer for their dialog box,
+         * meaning they won't think it has one and won't try
+         * to destroy it.
+         */
+        if (construct_args->activate_on_ok) {
+            gtk_signal_emit_by_name(GTK_OBJECT(parent_filter_te),
+                                    "activate");
+        }
+    }
 }
 
 static void
 filter_dlg_save_cb(GtkWidget *save_bt _U_, gpointer data)
 {
-	filter_list_type_t list = *(filter_list_type_t *)data;
-	char *pf_dir_path;
-	char *f_path;
-	int f_save_errno;
-	char *filter_type;
-
-	/* Create the directory that holds personal configuration files,
-	   if necessary.  */
-	if (create_persconffile_dir(&pf_dir_path) == -1) {
-		simple_dialog(ESD_TYPE_WARN, NULL,
-		    "Can't create directory\n\"%s\"\nfor filter files: %s.",
-		    pf_dir_path, strerror(errno));
-		g_free(pf_dir_path);
-		return;
-	}
-
-	save_filter_list(list, &f_path, &f_save_errno);
-	if (f_path != NULL) {
-		/* We had an error saving the filter. */
-		switch (list) {
-
-		case CFILTER_LIST:
-			filter_type = "capture";
-			break;
-
-		case DFILTER_LIST:
-			filter_type = "display";
-			break;
-
-		default:
-			g_assert_not_reached();
-			filter_type = NULL;
-			break;
-		}
-		simple_dialog(ESD_TYPE_CRIT, NULL,
-		    "Could not save to your %s filter file\n\"%s\": %s.",
-		    filter_type, f_path, strerror(f_save_errno));
-		g_free(f_path);
-	}
+    filter_list_type_t list = *(filter_list_type_t *)data;
+    char *pf_dir_path;
+    char *f_path;
+    int f_save_errno;
+    char *filter_type;
+
+    /* Create the directory that holds personal configuration files,
+       if necessary.  */
+    if (create_persconffile_dir(&pf_dir_path) == -1) {
+        simple_dialog(ESD_TYPE_WARN, NULL,
+                      "Can't create directory\n\"%s\"\nfor filter files: %s.",
+                      pf_dir_path, strerror(errno));
+        g_free(pf_dir_path);
+        return;
+    }
+
+    save_filter_list(list, &f_path, &f_save_errno);
+    if (f_path != NULL) {
+        /* We had an error saving the filter. */
+        switch (list) {
+
+        case CFILTER_LIST:
+            filter_type = "capture";
+            break;
+
+        case DFILTER_LIST:
+            filter_type = "display";
+            break;
+
+        default:
+            g_assert_not_reached();
+            filter_type = NULL;
+            break;
+        }
+        simple_dialog(ESD_TYPE_CRIT, NULL,
+                      "Could not save to your %s filter file\n\"%s\": %s.",
+                      filter_type, f_path, strerror(f_save_errno));
+        g_free(f_path);
+    }
 }
 
 static void
 filter_dlg_close_cb(GtkWidget *close_bt _U_, gpointer parent_w)
 {
-	gtk_widget_destroy(GTK_WIDGET(parent_w));
+    gtk_widget_destroy(GTK_WIDGET(parent_w));
 }
 
 static void
 filter_dlg_destroy(GtkWidget *win, gpointer data)
 {
-	filter_list_type_t list = *(filter_list_type_t *)data;
-	GtkWidget *caller;
-
-	/* Get the widget that requested that we be popped up, if any.
-	   (It should arrange to destroy us if it's destroyed, so
-	   that we don't get a pointer to a non-existent window here.) */
-	caller = gtk_object_get_data(GTK_OBJECT(win), E_FILT_CALLER_PTR_KEY);
-
-	if (caller != NULL) {
-		/* Tell it we no longer exist. */
-		gtk_object_set_data(GTK_OBJECT(caller), E_FILT_DIALOG_PTR_KEY,
-		    NULL);
-	} else {
-		/* This is an editing dialog popped up from, for example,
-		   a menu item; note that we no longer have one. */
-		switch (list) {
+    filter_list_type_t list = *(filter_list_type_t *)data;
+    GtkWidget *caller;
+
+    /* Get the widget that requested that we be popped up, if any.
+       (It should arrange to destroy us if it's destroyed, so
+       that we don't get a pointer to a non-existent window here.) */
+    caller = gtk_object_get_data(GTK_OBJECT(win), E_FILT_CALLER_PTR_KEY);
+
+    if (caller != NULL) {
+        /* Tell it we no longer exist. */
+        gtk_object_set_data(GTK_OBJECT(caller), E_FILT_DIALOG_PTR_KEY,
+                            NULL);
+    } else {
+        /* This is an editing dialog popped up from, for example,
+           a menu item; note that we no longer have one. */
+        switch (list) {
 
 #ifdef HAVE_LIBPCAP
-		case CFILTER_LIST:
-			g_assert(win == global_cfilter_w);
-			global_cfilter_w = NULL;
-			break;
+        case CFILTER_LIST:
+            g_assert(win == global_cfilter_w);
+            global_cfilter_w = NULL;
+            break;
 #endif
 
-		case DFILTER_LIST:
-			g_assert(win == global_dfilter_w);
-			global_dfilter_w = NULL;
-			break;
+        case DFILTER_LIST:
+            g_assert(win == global_dfilter_w);
+            global_dfilter_w = NULL;
+            break;
 
-		default:
-			g_assert_not_reached();
-			break;
-		}
-	}
+        default:
+            g_assert_not_reached();
+            break;
+        }
+    }
 
-	/* Remove this from the list of filter dialog windows. */
-	forget_filter_dialog(win, list);
+    /* Remove this from the list of filter dialog windows. */
+    forget_filter_dialog(win, list);
 
-	/* Now nuke this window. */
-	gtk_grab_remove(GTK_WIDGET(win));
-	gtk_widget_destroy(GTK_WIDGET(win));
+    /* Now nuke this window. */
+    gtk_grab_remove(GTK_WIDGET(win));
+    gtk_widget_destroy(GTK_WIDGET(win));
 }
 
 static gint
-filter_sel_list_button_cb (GtkWidget *widget, GdkEventButton *event,
-                           gpointer func_data)
+filter_sel_list_button_cb(GtkWidget *list, GdkEventButton *event,
+                          gpointer data _U_)
 {
-    GtkWidget *parent = func_data;
     void (* func)(GtkWidget *, gpointer, gpointer);
     gpointer func_arg;
     gpointer func_activate;
 
-    if (GTK_IS_LIST_ITEM(widget) && event->type == GDK_2BUTTON_PRESS) {
-        func = gtk_object_get_data(GTK_OBJECT(parent), E_FILT_DBLFUNC_KEY);
-        func_arg = gtk_object_get_data(GTK_OBJECT(parent), E_FILT_DBLARG_KEY);
-        func_activate = gtk_object_get_data(GTK_OBJECT(parent), E_FILT_DBLACTIVATE_KEY);
+    if (event->type == GDK_2BUTTON_PRESS) {
+        func = gtk_object_get_data(GTK_OBJECT(list), E_FILT_DBLFUNC_KEY);
+        func_arg = gtk_object_get_data(GTK_OBJECT(list), E_FILT_DBLARG_KEY);
+        func_activate = gtk_object_get_data(GTK_OBJECT(list),
+                                            E_FILT_DBLACTIVATE_KEY);
 
         if (func)
-            (*func)(func_data, func_arg, func_activate);
+            (*func)(list, func_arg, func_activate);
     }
 
     return FALSE;
 }
 
 static void
-filter_sel_list_cb(GtkWidget *l, gpointer data _U_)
+filter_sel_list_cb(GtkTreeSelection *sel, gpointer data _U_)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(l);
-  GtkWidget  *name_te = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_NAME_TE_KEY);
-  GtkWidget  *filter_te = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_TE_KEY);
-  GtkWidget  *chg_bt = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_CHG_BT_KEY);
-  GtkWidget  *copy_bt = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_COPY_BT_KEY);
-  GtkWidget  *del_bt = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_DEL_BT_KEY);
-  filter_def *filt;
-  gchar      *name = "", *strval = "";
-  GList      *sl, *flp;
-  GtkObject  *l_item;
-  gint        sensitivity = FALSE;
-
-  if (l)
-	  sl = GTK_LIST(l)->selection;
-  else
-	  sl = NULL;
-
-  if (sl) {  /* Something was selected */
-    l_item = GTK_OBJECT(sl->data);
-    flp    = (GList *) gtk_object_get_data(l_item, E_FILT_LIST_ITEM_MODEL_KEY);
-    if (flp) {
-      filt   = (filter_def *) flp->data;
-      name   = filt->name;
-      strval = filt->strval;
-      sensitivity = TRUE;
+    GtkWidget    *filter_l = GTK_WIDGET(gtk_tree_selection_get_tree_view(sel));
+    GtkWidget    *main_w = gtk_widget_get_toplevel(filter_l);
+    GtkWidget    *name_te = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                E_FILT_NAME_TE_KEY);
+    GtkWidget    *filter_te = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                  E_FILT_FILTER_TE_KEY);
+    GtkWidget    *chg_bt = gtk_object_get_data(GTK_OBJECT(main_w),
+                                               E_FILT_CHG_BT_KEY);
+    GtkWidget    *copy_bt = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                E_FILT_COPY_BT_KEY);
+    GtkWidget    *del_bt = gtk_object_get_data(GTK_OBJECT(main_w),
+                                               E_FILT_DEL_BT_KEY);
+    filter_def   *filt;
+    gchar        *name = "", *strval = "";
+    GList        *flp;
+    gint          sensitivity = FALSE;
+    GtkTreeModel *model;
+    GtkTreeIter   iter;
+
+    /* if something was selected */
+    if (gtk_tree_selection_get_selected(sel, &model, &iter)) {
+        gtk_tree_model_get(model, &iter, 1, &flp, -1);
+        if (flp) {
+            filt   = (filter_def *) flp->data;
+            name   = filt->name;
+            strval = filt->strval;
+            sensitivity = TRUE;
+        }
     }
-  }
-
-  /*
-   * Did you know that this function is called when the window is destroyed?
-   * Funny, that.
-   * This means that we have to:
-   *
-   *	attach to the top-level window data items containing pointers to
-   *	the widgets we affect here;
-   *
-   *	give each of those widgets their own destroy callbacks;
-   *
-   *	clear that pointer when the widget is destroyed;
-   *
-   *	don't do anything to the widget if the pointer we get back is
-   *	null;
-   *
-   * so that if we're called after any of the widgets we'd affect are
-   * destroyed, we know that we shouldn't do anything to those widgets.
-   */
-  if (name_te != NULL)
-    gtk_entry_set_text(GTK_ENTRY(name_te), name);
-  if (filter_te != NULL)
-    gtk_entry_set_text(GTK_ENTRY(filter_te), strval);
-  if (chg_bt != NULL)
-    gtk_widget_set_sensitive(chg_bt, sensitivity);
-  if (copy_bt != NULL)
-    gtk_widget_set_sensitive(copy_bt, sensitivity);
-  if (del_bt != NULL)
-    gtk_widget_set_sensitive(del_bt, sensitivity);
+
+    /*
+     * Did you know that this function is called when the window is destroyed?
+     * Funny, that.
+     * This means that we have to:
+     *
+     *	attach to the top-level window data items containing pointers to
+     *	the widgets we affect here;
+     *
+     *	give each of those widgets their own destroy callbacks;
+     *
+     *	clear that pointer when the widget is destroyed;
+     *
+     *	don't do anything to the widget if the pointer we get back is
+     *	null;
+     *
+     * so that if we're called after any of the widgets we'd affect are
+     * destroyed, we know that we shouldn't do anything to those widgets.
+     */
+    if (name_te != NULL)
+        gtk_entry_set_text(GTK_ENTRY(name_te), name);
+    if (filter_te != NULL)
+        gtk_entry_set_text(GTK_ENTRY(filter_te), strval);
+    if (chg_bt != NULL)
+        gtk_widget_set_sensitive(chg_bt, sensitivity);
+    if (copy_bt != NULL)
+        gtk_widget_set_sensitive(copy_bt, sensitivity);
+    if (del_bt != NULL)
+        gtk_widget_set_sensitive(del_bt, sensitivity);
 }
 
 static void
 filter_list_destroy_cb(GtkWidget *l, gpointer data _U_)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(l);
+    GtkWidget  *main_w = gtk_widget_get_toplevel(l);
 
-  gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY, NULL);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY, NULL);
 }
 
 /* To do: add input checking to each of these callbacks */
@@ -927,252 +938,272 @@ filter_list_destroy_cb(GtkWidget *l, gpointer data _U_)
    "nflp" is the GList member in the model (filter list) for the new
    filter. */
 typedef struct {
-	GtkWidget *active_filter_l;
-	GList     *nflp;
+    GtkWidget *active_filter_l;
+    GList     *nflp;
 } new_filter_cb_args_t;
 
 static void
 new_filter_cb(gpointer data, gpointer user_data)
 {
-  GtkWidget  *main_w = data;
-  GtkWidget  *filter_l = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY);
-  new_filter_cb_args_t *args = user_data;
-  filter_def *nfilt = args->nflp->data;
-  GtkWidget  *nl_lb, *nl_item;
-
-  nl_lb        = gtk_label_new(nfilt->name);
-  nl_item      = gtk_list_item_new();
-  gtk_misc_set_alignment(GTK_MISC(nl_lb), 0.0, 0.5);
-  gtk_container_add(GTK_CONTAINER(nl_item), nl_lb);
-  gtk_widget_show(nl_lb);
-  gtk_container_add(GTK_CONTAINER(filter_l), nl_item);
-  gtk_widget_show(nl_item);
-  gtk_object_set_data(GTK_OBJECT(nl_item), E_FILT_LBL_KEY, nl_lb);
-  gtk_object_set_data(GTK_OBJECT(nl_item), E_FILT_LIST_ITEM_MODEL_KEY,
-		      args->nflp);
-  if (filter_l == args->active_filter_l) {
-    /* Select the item. */
-    gtk_list_select_child(GTK_LIST(filter_l), nl_item);
-  }
+    GtkWidget            *main_w = data;
+    GtkTreeView          *filter_l;
+    new_filter_cb_args_t *args = user_data;
+    filter_def           *nfilt = args->nflp->data;
+    GtkListStore         *store;
+    GtkTreeIter           iter;
+
+    filter_l = GTK_TREE_VIEW(gtk_object_get_data(GTK_OBJECT(main_w),
+                                                 E_FILT_FILTER_L_KEY));
+    store = GTK_LIST_STORE(gtk_tree_view_get_model(filter_l));
+    gtk_list_store_append(store, &iter);
+    gtk_list_store_set(store, &iter, 0, nfilt->name, 1, args->nflp, -1);
+    if (GTK_WIDGET(filter_l) == args->active_filter_l) {
+        /* Select the item. */
+        gtk_tree_selection_select_iter(gtk_tree_view_get_selection(filter_l),
+                                       &iter);
+    }
 }
 
 static void
 filter_new_bt_clicked_cb(GtkWidget *w, gpointer data)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(w);
-  GtkWidget  *name_te = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_NAME_TE_KEY);
-  GtkWidget  *filter_te = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_TE_KEY);
-  GtkWidget  *filter_l = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY);
-  filter_list_type_t list = *(filter_list_type_t *)data;
-  GList      *fl_entry;
-  const gchar *name, *strval;
-  new_filter_cb_args_t args;
-
-  name   = gtk_entry_get_text(GTK_ENTRY(name_te));
-  strval = gtk_entry_get_text(GTK_ENTRY(filter_te));
-
-  if (strlen(name) > 0 && strlen(strval) > 0) {
-    /* Add a new entry to the filter list. */
-    fl_entry = add_to_filter_list(list, name, strval);
-
-    /* Update all the filter list widgets, not just the one in
-       the dialog box in which we clicked on "Copy". */
-    args.active_filter_l = filter_l;
-    args.nflp = fl_entry;
-    g_list_foreach(get_filter_dialog_list(list), new_filter_cb, &args);
-  } else {
-    /* Give the user some basic directions on how to use the 'new' button */
-    simple_dialog(ESD_TYPE_WARN, NULL,
-                  "You have left either the 'Filter name' or 'Filter string' field empty.\n"
-                  "To add a new filter, enter a name for the filter, and enter the expression\n"
-                  "for the filter or use the 'Add Expression...' button to construct an\n"
-                  "expression, then click 'New'.");
-  }
+    GtkWidget  *main_w = gtk_widget_get_toplevel(w);
+    GtkWidget  *name_te = gtk_object_get_data(GTK_OBJECT(main_w),
+                                              E_FILT_NAME_TE_KEY);
+    GtkWidget  *filter_te = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                E_FILT_FILTER_TE_KEY);
+    GtkWidget  *filter_l = gtk_object_get_data(GTK_OBJECT(main_w),
+                                               E_FILT_FILTER_L_KEY);
+    filter_list_type_t list = *(filter_list_type_t *)data;
+    GList      *fl_entry;
+    const gchar *name, *strval;
+    new_filter_cb_args_t args;
+
+    name   = gtk_entry_get_text(GTK_ENTRY(name_te));
+    strval = gtk_entry_get_text(GTK_ENTRY(filter_te));
+
+    if (strlen(name) > 0 && strlen(strval) > 0) {
+        /* Add a new entry to the filter list. */
+        fl_entry = add_to_filter_list(list, (char *)name, (char *)strval);
+
+        /* Update all the filter list widgets, not just the one in
+           the dialog box in which we clicked on "Copy". */
+        args.active_filter_l = filter_l;
+        args.nflp = fl_entry;
+        g_list_foreach(get_filter_dialog_list(list), new_filter_cb, &args);
+    } else {
+        /* Give the user some basic directions on how to use the 'new' button */
+        simple_dialog(ESD_TYPE_WARN, NULL,
+                      "You have left either the 'Filter name' or 'Filter string' field empty.\n"
+                      "To add a new filter, enter a name for the filter, and enter the expression\n"
+                      "for the filter or use the 'Add Expression...' button to construct an\n"
+                      "expression, then click 'New'.");
+    }
 }
 
-static void
-chg_list_item_cb(GtkWidget *nl_item, gpointer data)
+static gboolean
+chg_list_item_cb(GtkTreeModel *model, GtkTreePath *path _U_, GtkTreeIter *iter,
+                 gpointer data)
 {
-  GList      *flp = data;
-  filter_def *filt = flp->data;
-  GtkLabel   *nl_lb =
-      GTK_LABEL(gtk_object_get_data(GTK_OBJECT(nl_item), E_FILT_LBL_KEY));
-  GList      *nl_model =
-      gtk_object_get_data(GTK_OBJECT(nl_item), E_FILT_LIST_ITEM_MODEL_KEY);
-
-  /* Is this the GtkList item corresponding to the filter list item in
-     question? */
-  if (flp == nl_model) {
-    /* Yes - change the label to correspond to the new name for the filter. */
-    gtk_label_set(nl_lb, filt->name);
-  }
+    GList      *flp = data;
+    filter_def *filt = flp->data;
+    GList      *nl_model;
+
+    gtk_tree_model_get(model, iter, 1, &nl_model, -1);
+    /* Is this the item corresponding to the filter list item in question? */
+    if (flp == nl_model) {
+        /* Yes - change the label to correspond to the new name for the
+         * filter. */
+        gtk_list_store_set(GTK_LIST_STORE(model), iter, 0, filt->name, -1);
+        return TRUE;
+    }
+    return FALSE;
 }
 
 static void
 chg_filter_cb(gpointer data, gpointer user_data)
 {
-  GtkWidget  *main_w = data;
-  GtkWidget  *filter_l = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY);
+    GtkWidget  *main_w = data;
+    GtkWidget  *filter_l = gtk_object_get_data(GTK_OBJECT(main_w),
+                                               E_FILT_FILTER_L_KEY);
 
-  gtk_container_foreach(GTK_CONTAINER(filter_l), chg_list_item_cb, user_data);
+    gtk_tree_model_foreach(gtk_tree_view_get_model(GTK_TREE_VIEW(filter_l)),
+                           chg_list_item_cb, user_data);
 }
 
 static void
 filter_chg_bt_clicked_cb(GtkWidget *w, gpointer data)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(w);
-  GtkWidget  *name_te = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_NAME_TE_KEY);
-  GtkWidget  *filter_te = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_TE_KEY);
-  GtkWidget  *filter_l = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY);
-  filter_def *filt;
-  const gchar *name, *strval;
-  GList      *sl, *fl_entry;
-  GtkObject  *l_item;
-  GtkLabel   *nl_lb;
-  filter_list_type_t list = *(filter_list_type_t *)data;
-
-  sl     = GTK_LIST(filter_l)->selection;
-  name   = gtk_entry_get_text(GTK_ENTRY(name_te));
-  strval = gtk_entry_get_text(GTK_ENTRY(filter_te));
-
-  if (sl) {  /* Something was selected */
-    l_item = GTK_OBJECT(sl->data);
-    fl_entry = (GList *) gtk_object_get_data(l_item, E_FILT_LIST_ITEM_MODEL_KEY);
-    nl_lb = (GtkLabel *) gtk_object_get_data(l_item, E_FILT_LBL_KEY);
-    if (fl_entry != NULL && nl_lb != NULL) {
-      filt = (filter_def *) fl_entry->data;
-
-      if (strlen(name) > 0 && strlen(strval) > 0 && filt) {
-        g_free(filt->name);
-        g_free(filt->strval);
-        filt->name   = g_strdup(name);
-        filt->strval = g_strdup(strval);
-
-        /* Update all the filter list widgets, not just the one in
-           the dialog box in which we clicked on "Copy". */
-        g_list_foreach(get_filter_dialog_list(list), chg_filter_cb, fl_entry);
-      }
+    GtkWidget         *main_w = gtk_widget_get_toplevel(w);
+    GtkWidget         *name_te = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                     E_FILT_NAME_TE_KEY);
+    GtkWidget         *filter_te = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                       E_FILT_FILTER_TE_KEY);
+    GtkWidget         *filter_l = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                      E_FILT_FILTER_L_KEY);
+    filter_def        *filt;
+    const gchar       *name, *strval;
+    GList             *fl_entry;
+    filter_list_type_t list = *(filter_list_type_t *)data;
+    GtkTreeSelection  *sel;
+    GtkTreeModel      *model;
+    GtkTreeIter        iter;
+
+    name   = gtk_entry_get_text(GTK_ENTRY(name_te));
+    strval = gtk_entry_get_text(GTK_ENTRY(filter_te));
+
+    sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(filter_l));
+
+    /* if something was selected */
+    if (gtk_tree_selection_get_selected(sel, &model, &iter)) {
+        gtk_tree_model_get(model, &iter, 1, &fl_entry, -1);
+        if (fl_entry != NULL) {
+            filt = (filter_def *) fl_entry->data;
+
+            if (strlen(name) > 0 && strlen(strval) > 0 && filt) {
+                g_free(filt->name);
+                g_free(filt->strval);
+                filt->name   = g_strdup(name);
+                filt->strval = g_strdup(strval);
+
+                /* Update all the filter list widgets, not just the one in
+                   the dialog box in which we clicked on "Copy". */
+                g_list_foreach(get_filter_dialog_list(list), chg_filter_cb,
+                               fl_entry);
+            }
+        }
     }
-  }
 }
 
 static void
 filter_chg_bt_destroy_cb(GtkWidget *chg_bt, gpointer data _U_)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(chg_bt);
+    GtkWidget  *main_w = gtk_widget_get_toplevel(chg_bt);
 
-  gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_CHG_BT_KEY, NULL);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_CHG_BT_KEY, NULL);
 }
 
 static void
 filter_copy_bt_clicked_cb(GtkWidget *w, gpointer data)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(w);
-  GtkWidget  *filter_l = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY);
-  GList      *sl, *fl_entry, *nfl_entry;
-  gchar      *prefix = "Copy of ", *name;
-  GtkObject  *l_item;
-  filter_def *filt;
-  filter_list_type_t list = *(filter_list_type_t *)data;
-  new_filter_cb_args_t args;
-
-  sl     = GTK_LIST(filter_l)->selection;
-  if (sl) {  /* Something was selected */
-    l_item = GTK_OBJECT(sl->data);
-    fl_entry = (GList *) gtk_object_get_data(l_item, E_FILT_LIST_ITEM_MODEL_KEY);
-    if (fl_entry != NULL) {
-      /* Add a new entry, copying the existing entry, to the filter list. */
-      filt = (filter_def *) fl_entry->data;
-      name = g_malloc(strlen(prefix) + strlen(filt->name) + 1);
-      sprintf(name, "%s%s", prefix, filt->name);
-      nfl_entry = add_to_filter_list(list, name, filt->strval);
-      g_free(name);
-
-      /* Update all the filter list widgets, not just the one in
-         the dialog box in which we clicked on "Copy". */
-      args.active_filter_l = filter_l;
-      args.nflp = nfl_entry;
-      g_list_foreach(get_filter_dialog_list(list), new_filter_cb, &args);
+    GtkWidget           *main_w = gtk_widget_get_toplevel(w);
+    GtkWidget           *filter_l = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                        E_FILT_FILTER_L_KEY);
+    GList               *fl_entry, *nfl_entry;
+    gchar               *prefix = "Copy of ", *name;
+    filter_def          *filt;
+    filter_list_type_t   list = *(filter_list_type_t *)data;
+    new_filter_cb_args_t args;
+    GtkTreeSelection    *sel;
+    GtkTreeModel        *model;
+    GtkTreeIter          iter;
+
+    sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(filter_l));
+
+    /* if something was selected */
+    if (gtk_tree_selection_get_selected(sel, &model, &iter)) {
+        gtk_tree_model_get(model, &iter, 1, &fl_entry, -1);
+        if (fl_entry != NULL) {
+            /* Add a new entry, copying the existing entry, to the
+             * filter list. */
+            filt = (filter_def *) fl_entry->data;
+            name = g_malloc(strlen(prefix) + strlen(filt->name) + 1);
+            sprintf(name, "%s%s", prefix, filt->name);
+            nfl_entry = add_to_filter_list(list, name, filt->strval);
+            g_free(name);
+
+            /* Update all the filter list widgets, not just the one in
+               the dialog box in which we clicked on "Copy". */
+            args.active_filter_l = filter_l;
+            args.nflp = nfl_entry;
+            g_list_foreach(get_filter_dialog_list(list), new_filter_cb, &args);
+        }
     }
-  }
 }
 
 static void
 filter_copy_bt_destroy_cb(GtkWidget *copy_bt, gpointer data _U_)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(copy_bt);
+    GtkWidget  *main_w = gtk_widget_get_toplevel(copy_bt);
 
-  gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_COPY_BT_KEY, NULL);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_COPY_BT_KEY, NULL);
 }
 
 static void
 delete_filter_cb(gpointer data, gpointer user_data)
 {
-  GtkWidget  *main_w = data;
-  GtkWidget  *filter_l = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY);
-  gint pos = *(gint *)user_data;
-
-  gtk_list_clear_items(GTK_LIST(filter_l), pos, pos + 1);
+    GtkWidget    *main_w = data;
+    GtkWidget    *filter_l = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                 E_FILT_FILTER_L_KEY);
+    gchar        *pos = (gchar *)user_data;
+    GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(filter_l));
+    GtkTreeIter   iter;
+
+    gtk_tree_model_get_iter_from_string(model, &iter, pos);
+    gtk_list_store_remove(GTK_LIST_STORE(model), &iter);
 }
 
 static void
 filter_del_bt_clicked_cb(GtkWidget *w, gpointer data)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(w);
-  GtkWidget  *filter_l = gtk_object_get_data(GTK_OBJECT(main_w), E_FILT_FILTER_L_KEY);
-  filter_list_type_t list = *(filter_list_type_t *)data;
-  GList      *sl, *fl_entry;
-  GtkObject  *l_item;
-  gint        pos;
-
-  sl = GTK_LIST(filter_l)->selection;
-  if (sl) {  /* Something was selected */
-    l_item = GTK_OBJECT(sl->data);
-    pos    = gtk_list_child_position(GTK_LIST(filter_l),
-      GTK_WIDGET(l_item));
-    fl_entry = (GList *) gtk_object_get_data(l_item, E_FILT_LIST_ITEM_MODEL_KEY);
-    if (fl_entry != NULL) {
-      /* Remove the entry from the filter list. */
-      remove_from_filter_list(list, fl_entry);
-
-      /* Update all the filter list widgets, not just the one in
-         the dialog box in which we clicked on "Delete". */
-      g_list_foreach(get_filter_dialog_list(list), delete_filter_cb, &pos);
+    GtkWidget         *main_w = gtk_widget_get_toplevel(w);
+    GtkWidget         *filter_l = gtk_object_get_data(GTK_OBJECT(main_w),
+                                                      E_FILT_FILTER_L_KEY);
+    filter_list_type_t list = *(filter_list_type_t *)data;
+    GList             *fl_entry;
+    gchar             *pos;
+    GtkTreeSelection  *sel;
+    GtkTreeModel      *model;
+    GtkTreeIter        iter;
+
+    sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(filter_l));
+    /* If something was selected */
+    if (gtk_tree_selection_get_selected(sel, &model, &iter)) {
+        gtk_tree_model_get(model, &iter, 1, &fl_entry, -1);
+        pos = gtk_tree_path_to_string(gtk_tree_model_get_path(model, &iter));
+        if (fl_entry != NULL) {
+            /* Remove the entry from the filter list. */
+            remove_from_filter_list(list, fl_entry);
+
+            /* Update all the filter list widgets, not just the one in
+               the dialog box in which we clicked on "Delete". */
+            g_list_foreach(get_filter_dialog_list(list), delete_filter_cb, pos);
+        }
+        g_free(pos);
     }
-  }
 }
 
 static void
 filter_del_bt_destroy_cb(GtkWidget *del_bt, gpointer data _U_)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(del_bt);
+    GtkWidget  *main_w = gtk_widget_get_toplevel(del_bt);
 
-  gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_DEL_BT_KEY, NULL);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_DEL_BT_KEY, NULL);
 }
 
 static void
 filter_expr_cb(GtkWidget *w _U_, gpointer main_w_arg)
 {
-	GtkWidget  *main_w = GTK_WIDGET(main_w_arg);
-	GtkWidget  *filter_te;
+    GtkWidget  *main_w = GTK_WIDGET(main_w_arg);
+    GtkWidget  *filter_te;
 
-	filter_te = gtk_object_get_data(GTK_OBJECT(main_w),
-	    E_FILT_FILTER_TE_KEY);
-	dfilter_expr_dlg_new(filter_te);
+    filter_te = gtk_object_get_data(GTK_OBJECT(main_w),
+                                    E_FILT_FILTER_TE_KEY);
+    dfilter_expr_dlg_new(filter_te);
 }
 
 static void
 filter_name_te_destroy_cb(GtkWidget *name_te, gpointer data _U_)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(name_te);
+    GtkWidget  *main_w = gtk_widget_get_toplevel(name_te);
 
-  gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_NAME_TE_KEY, NULL);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_NAME_TE_KEY, NULL);
 }
 
 static void
 filter_filter_te_destroy_cb(GtkWidget *filter_te, gpointer data _U_)
 {
-  GtkWidget  *main_w = gtk_widget_get_toplevel(filter_te);
+    GtkWidget  *main_w = gtk_widget_get_toplevel(filter_te);
 
-  gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_FILTER_TE_KEY, NULL);
+    gtk_object_set_data(GTK_OBJECT(main_w), E_FILT_FILTER_TE_KEY, NULL);
 }