Have tap listeners specify whether the "packet" routine requires

	a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645

1 files changed, 7 insertions, 9 deletions

diff --git a/gtk/mgcp_stat.c b/gtk/mgcp_stat.c
index 02183d9d5f..0ca343d2ca 100644
--- a/gtk/mgcp_stat.c
+++ b/gtk/mgcp_stat.c
@@ -250,20 +250,18 @@ static void
 gtk_mgcpstat_init(const char *optarg, void *userdata _U_)
 {
 	mgcpstat_t *ms;
-	const char *filter=NULL;
 	GString *error_string;
 	GtkWidget *bt_close;
 	GtkWidget *bbox;
 
+	ms=g_malloc(sizeof(mgcpstat_t));
+
 	if(strncmp(optarg,"mgcp,srt,",9) == 0){
-		filter=optarg+9;
+		ms->filter=g_strdup(optarg+9);
 	} else {
-		filter="";
+		ms->filter=NULL;
 	}
 
-	ms=g_malloc(sizeof(mgcpstat_t));
-	ms->filter=g_strdup(filter);
-
 	mgcpstat_reset(ms);
 
 	ms->win=window_new(GTK_WINDOW_TOPLEVEL, "MGCP SRT");
@@ -271,14 +269,14 @@ gtk_mgcpstat_init(const char *optarg, void *userdata _U_)
 
 	ms->vbox=gtk_vbox_new(FALSE, 3);
 
-	init_main_stat_window(ms->win, ms->vbox, "MGCP Service Response Time (SRT) Statistics", filter);
+	init_main_stat_window(ms->win, ms->vbox, "MGCP Service Response Time (SRT) Statistics", ms->filter);
 
 	/* init a scrolled window*/
 	ms->scrolled_window = scrolled_window_new(NULL, NULL);
 
 	ms->table = create_stat_table(ms->scrolled_window, ms->vbox, 7, titles);
 
-	error_string=register_tap_listener("mgcp", ms, filter, mgcpstat_reset, mgcpstat_packet, mgcpstat_draw);
+	error_string=register_tap_listener("mgcp", ms, ms->filter, 0, mgcpstat_reset, mgcpstat_packet, mgcpstat_draw);
 	if(error_string){
 		simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "%s", error_string->str);
 		g_string_free(error_string, TRUE);
@@ -300,7 +298,7 @@ gtk_mgcpstat_init(const char *optarg, void *userdata _U_)
 	gtk_widget_show_all(ms->win);
 	window_present(ms->win);
 
-	cf_retap_packets(&cfile, FALSE);
+	cf_retap_packets(&cfile);
 	gdk_window_raise(ms->win->window);
 }