Instead of using a Boolean for the search direction, use an enum, so

that you can tell from examination whether the search is forward or
backward.

Make the cf_find_packet routines take the direction as an explicit
argument, rather than, in the cases where you don't want to permanently
set the direction, saving the direction in the capture_file structure,
changing it, doing the search, and restoring the saved direction.  Give
more information in the Doxygen comments for those routines.

Add a cf_find_packet_dfilter_string() routine, which takes a filter
string rather than a compiled filter as an argument.  Replace
find_previous_next_frame_with_filter() with it.

Have cf_read_frame_r() and cf_read_frame() pop up the error dialog if
the read fails, rather than leaving that up to its caller.  That lets us
eliminate cf_read_error_message(), by swallowing its code into
cf_read_frame_r().  Add Doxygen comments for cf_read_frame_r() and
cf_read_frame().

Don't have find_packet() read the packet before calling the callback
routine; leave that up to the callback routine.

Add cf_find_packet_marked(), to find the next or previous marked packet,
and cf_find_packet_time_reference(), to find the next or previous time
reference packet.  Those routines do *not* need to read the packet data
to see if it matches; that lets them run much faster.

Clean up indentation.

svn path=/trunk/; revision=33791

1 files changed, 2 insertions, 2 deletions

diff --git a/gtk/filter_utils.c b/gtk/filter_utils.c
index a41fe657bf..96bdf55fdd 100644
--- a/gtk/filter_utils.c
+++ b/gtk/filter_utils.c
@@ -94,10 +94,10 @@ apply_selected_filter (guint callback_action, char *filter)
 		find_frame_with_filter(str);
 		break;
 	case ACTION_FIND_NEXT:
-		find_previous_next_frame_with_filter(str, FALSE);
+		cf_find_packet_dfilter_string(&cfile, str, SD_FORWARD);
 		break;
 	case ACTION_FIND_PREVIOUS:
-		find_previous_next_frame_with_filter(str, TRUE);
+		cf_find_packet_dfilter_string(&cfile, str, SD_BACKWARD);
 		break;
 	case ACTION_COLORIZE:
 		color_display_with_filter(str);