diff options
author | Moshe Kaplan <me@moshekaplan.com> | 2020-12-20 21:30:28 -0500 |
---|---|---|
committer | AndersBroman <a.broman58@gmail.com> | 2020-12-22 14:56:38 +0000 |
commit | e16166a74cca1d66e2c302e257cf94aebb380599 (patch) | |
tree | 8834b4b8390fca83dd7bc1b4b9e6a7bb276e1d7e /fileset.c | |
parent | 7b27b444cbd94853b399da770e0dad4b91ef23ac (diff) |
Detect and replace bad allocation patterns
Adds a pre-commit hook for detecting and replacing
occurrences of `g_malloc()` and `wmem_alloc()` with
`g_new()` and `wmem_new()`, to improve the
readability of Wireshark's code, and
occurrences of
`g_malloc(sizeof(struct myobj) * foo)`
with
`g_new(struct myobj, foo)`
to prevent integer overflows
Also fixes all existing occurrences across
the codebase.
Diffstat (limited to 'fileset.c')
-rw-r--r-- | fileset.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -222,7 +222,7 @@ fileset_add_file(const char *dirname, const char *fname, gboolean current) /* Show statistics if they are valid */ if( result == 0 ) { - entry = (fileset_entry *)g_malloc(sizeof(fileset_entry)); + entry = g_new(fileset_entry, 1); entry->fullname = g_strdup(path); entry->name = g_strdup(fname); |