aboutsummaryrefslogtreecommitdiffstats
path: root/extcap_parser.c
diff options
context:
space:
mode:
authorTomasz Moń <desowin@gmail.com>2019-04-25 16:44:56 +0200
committerAnders Broman <a.broman58@gmail.com>2019-04-26 06:35:31 +0000
commit73e401afd22f5d6c25da6addd6ea4b47a781eba1 (patch)
treec3c10bedc46d754c59fa774c947220c03cb8c131 /extcap_parser.c
parent57c5015a6bb104c63f73ea29dfe06f50a5d26de8 (diff)
extcap: Do not crash on invalid values
The easiest way to trigger the crash was to forget the {display=...} in the extcap config value sentence. This change fixes the crash by simply ignoring invalid value sentences. Bug: 15668 Bug: 15728 Change-Id: I2f41682460c3e08fa766046949f013247bc0a846 Reviewed-on: https://code.wireshark.org/review/32984 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'extcap_parser.c')
-rw-r--r--extcap_parser.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/extcap_parser.c b/extcap_parser.c
index 62a5fc5aec..44ca9bfd56 100644
--- a/extcap_parser.c
+++ b/extcap_parser.c
@@ -578,6 +578,8 @@ static extcap_arg *extcap_parse_arg_sentence(GList *args, extcap_token_sentence
} else if (sent == EXTCAP_SENTENCE_VALUE) {
value = extcap_parse_value_sentence(s);
+ if (value == NULL)
+ return NULL;
if ((entry = g_list_find_custom(args, &value->arg_num, glist_find_numbered_arg))
== NULL) {