diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2021-09-05 15:17:30 +0200 |
|---|---|---|
| committer | Wireshark GitLab Utility <gerald+gitlab-utility@wireshark.org> | 2021-09-06 04:21:14 +0000 |
| commit | 4a55281078434874c3d7a662dc83e7926d8cacc5 (patch) | |
| tree | b3fb4d4a926865a2d9f896f843babd82c63c4070 /extcap | |
| parent | 7740e9ae27f4ae3d2ea7a7e6290f95d92316717f (diff) | |
dpauxmon(extcap): Fix Dead Store found by Clang Analyzer
dpauxmon.c:290:7: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err' [deadcode.DeadStores]
dpauxmon.c:432:7: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err' [deadcode.DeadStores]
dpauxmon.c:437:7: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err' [deadcode.DeadStores]
dpauxmon.c:443:7: warning: Although the value stored to 'err' is used in the enclosing expression, the value is never actually read from 'err' [deadcode.DeadStores]
Diffstat (limited to 'extcap')
| -rw-r--r-- | extcap/dpauxmon.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/extcap/dpauxmon.c b/extcap/dpauxmon.c index 7e86a75299..3f31d7020d 100644 --- a/extcap/dpauxmon.c +++ b/extcap/dpauxmon.c @@ -288,7 +288,7 @@ static int send_start(struct nl_sock *sock, int family, unsigned int interface_i } if ((err = nl_send_auto_complete(sock, msg)) < 0) - ws_debug("Starting monitor failed, already running?"); + ws_debug("Starting monitor failed, already running? :%s", nl_geterror(err)); out_free: nlmsg_free(msg); @@ -430,19 +430,22 @@ static void run_listener(const char* fifo, unsigned int interface_id) } if ((err = genl_register_family(&ops)) < 0) { - ws_critical("Unable to register Generic Netlink family"); + ws_critical("Unable to register Generic Netlink family: %s", + nl_geterror(err)); goto err_out; } if ((err = genl_ops_resolve(sock, &ops)) < 0) { - ws_critical("Unable to resolve family name"); + ws_critical("Unable to resolve family name: %s", + nl_geterror(err)); goto err_out; } /* register notification handler callback */ if ((err = nl_socket_modify_cb(sock, NL_CB_VALID, NL_CB_CUSTOM, parse_cb, NULL)) < 0) { - ws_critical("Unable to modify valid message callback"); + ws_critical("Unable to modify valid message callback %s", + nl_geterror(err)); goto err_out; } |