diff options
author | Guy Harris <guy@alum.mit.edu> | 2019-05-01 18:46:23 -0700 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2019-05-02 09:29:01 +0000 |
commit | 2ee483a222bc765f8a738dfa15124826d89dc543 (patch) | |
tree | b1011d49978414331d191c2190318cb1d92d634e /extcap/ciscodump.c | |
parent | 7bc066aa0c74f8c595ba01678832f2ac17e279dc (diff) |
Move the Winsock initialization and cleanup to wsutil routines.
Those routines exist on both Windows and UN*X, but they don't do
anything on UN*X (they could if it were ever necessary).
That eliminates some #ifdefs, and also means that the gory details of
initializing Winsock, including the Winsock version being requested,
are buried in one routine.
The initialization routine returns NULL on success and a pointer to a
g_malloc()ated error message on failure; report the error to the user,
along with a "report this to the Wireshark developers" suggestion.
That means including wsutil/socket.h, which obviates the need to include
some headers for socket APIs, as it includes them for you.
Change-Id: I9327bbf25effbb441e4217edc5354a4d5ab07186
Reviewed-on: https://code.wireshark.org/review/33045
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'extcap/ciscodump.c')
-rw-r--r-- | extcap/ciscodump.c | 25 |
1 files changed, 11 insertions, 14 deletions
diff --git a/extcap/ciscodump.c b/extcap/ciscodump.c index b125353251..778d83a2b6 100644 --- a/extcap/ciscodump.c +++ b/extcap/ciscodump.c @@ -17,6 +17,7 @@ #include <wsutil/strtoi.h> #include <wsutil/filesystem.h> #include <wsutil/privileges.h> +#include <wsutil/please_report_bug.h> #include <extcap/ssh-base.h> #include <writecap/pcapio.h> @@ -518,7 +519,7 @@ static int list_config(char *interface, unsigned int remote_port) int main(int argc, char *argv[]) { - char* init_progfile_dir_error; + char* err_msg; int result; int option_idx = 0; ssh_params_t* ssh_params = ssh_params_new(); @@ -530,10 +531,6 @@ int main(int argc, char *argv[]) char* help_url; char* help_header = NULL; -#ifdef _WIN32 - WSADATA wsaData; -#endif /* _WIN32 */ - /* * Get credential information for later use. */ @@ -543,11 +540,11 @@ int main(int argc, char *argv[]) * Attempt to get the pathname of the directory containing the * executable file. */ - init_progfile_dir_error = init_progfile_dir(argv[0]); - if (init_progfile_dir_error != NULL) { + err_msg = init_progfile_dir(argv[0]); + if (err_msg != NULL) { g_warning("Can't get pathname of directory containing the captype program: %s.", - init_progfile_dir_error); - g_free(init_progfile_dir_error); + err_msg); + g_free(err_msg); } help_url = data_file_url("ciscodump.html"); @@ -688,13 +685,13 @@ int main(int argc, char *argv[]) goto end; } -#ifdef _WIN32 - result = WSAStartup(MAKEWORD(2, 2), &wsaData); - if (result != 0) { - g_warning("ERROR: WSAStartup failed with error: %d", result); + err_msg = ws_init_sockets(); + if (err_msg != NULL) { + g_warning("ERROR: %s", err_msg); + g_free(err_msg); + g_warning("%s", please_report_bug()); goto end; } -#endif /* _WIN32 */ if (extcap_conf->capture) { if (!ssh_params->host) { |