aboutsummaryrefslogtreecommitdiffstats
path: root/epan
diff options
context:
space:
mode:
authorGerald Combs <gerald@wireshark.org>2018-02-22 11:36:51 -0800
committerGerald Combs <gerald@wireshark.org>2018-02-22 19:51:11 +0000
commit2e139a15fab0206403e66abaf435456007cb5e1f (patch)
tree61cf53f8bb75a19129f44fcec05b0b21077f3f39 /epan
parent05cd2b6c1cc52aca95a822096f77aec203f34622 (diff)
SIGCOMP: Disable UDVM dissection and decompression.
This dissector has had multiple, severe issues over the years. Set the display.udvm.code and decomp.msg preferences to FALSE by default. Add warnings about re-enabling them. Change-Id: Ib23ab1b2cd23b35f2377416c7d197730dedbd9e2 Reviewed-on: https://code.wireshark.org/review/26002 Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'epan')
-rw-r--r--epan/dissectors/packet-sigcomp.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/epan/dissectors/packet-sigcomp.c b/epan/dissectors/packet-sigcomp.c
index cbd3eaf626..0742f3370b 100644
--- a/epan/dissectors/packet-sigcomp.c
+++ b/epan/dissectors/packet-sigcomp.c
@@ -165,10 +165,14 @@ static dissector_handle_t sigcomp_handle;
/* Default preference whether to display the bytecode in UDVM operands or not */
static gboolean display_udvm_bytecode = FALSE;
/* Default preference whether to dissect the UDVM code or not */
-static gboolean dissect_udvm_code = TRUE;
+/* WARNING: Setting this to true might result in the entire dissector being
+ disabled by default or removed completely. */
+static gboolean dissect_udvm_code = FALSE;
static gboolean display_raw_txt = FALSE;
/* Default preference whether to decompress the message or not */
-static gboolean decompress = TRUE;
+/* WARNING: Setting this to true might result in the entire dissector being
+ disabled by default or removed completely. */
+static gboolean decompress = FALSE;
/* Default preference whether to print debug info at execution of UDVM
* 0 = No printout
* 1 = details level 1