If we receive junk data from the network it means we have a

malformed packet.  It doesn't necessarily mean that we have a problem
with our dissector.  If we see something we didn't expect, throw a
ReportedBoundsError instead of calling DISSECTOR_ASSERT() (which makes
BuildBot open a ticket).

Fixes bugs 362 - 366.


svn path=/trunk/; revision=15390

1 files changed, 2 insertions, 2 deletions

diff --git a/epan/dissectors/packet-bittorrent.c b/epan/dissectors/packet-bittorrent.c
index d3021a8832..6c5caccd06 100644
--- a/epan/dissectors/packet-bittorrent.c
+++ b/epan/dissectors/packet-bittorrent.c
@@ -156,13 +156,13 @@ static guint get_bittorrent_pdu_length(tvbuff_t *tvb, int offset)
                of this TCP segment as "continuation data"; if this is
                a real BitTorrent connection, we probably didn't get some
                data before this segment. */
-            DISSECTOR_ASSERT(!"Reassemble error?");
+            THROW(ReportedBoundsError);
             return 0;
          }
       } else {
          /* For now, we just give up, so we don't end up dissecting
             a message with a bogus length. */
-         DISSECTOR_ASSERT(!"Reassemble error?");
+         THROW(ReportedBoundsError);
          return 0;
       }
    }