diff options
author | Hal Rosenstock <hal.rosenstock@gmail.com> | 2017-10-26 19:54:59 +0200 |
---|---|---|
committer | Anders Broman <a.broman58@gmail.com> | 2017-11-04 07:21:32 +0000 |
commit | 0cd40887d4963cf20b1118eba4085670d5cf1b01 (patch) | |
tree | 28334748ed3b68b2ad39aecf32ec7b82fe3e3825 /epan | |
parent | b4856927eb2593795f114df8606f16136fb5048c (diff) |
packet-infiniband: Better variable naming
Rather than use PERF_header_item for all classes,
use acronym for class appended with _header_item
Change-Id: I52ac46000c20b7f51c87c8dc4a8dfc85c20f31f3
Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com>
Reviewed-on: https://code.wireshark.org/review/24233
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan')
-rw-r--r-- | epan/dissectors/packet-infiniband.c | 36 |
1 files changed, 18 insertions, 18 deletions
diff --git a/epan/dissectors/packet-infiniband.c b/epan/dissectors/packet-infiniband.c index 7e3e4336a3..8d4bd43e60 100644 --- a/epan/dissectors/packet-infiniband.c +++ b/epan/dissectors/packet-infiniband.c @@ -3069,7 +3069,7 @@ static void parse_BM(proto_tree *parentTree, tvbuff_t *tvb, gint *offset) /* Parse the Common MAD Header */ MAD_Data MadData; gint local_offset; - proto_item *PERF_header_item; + proto_item *BM_header_item; if (!parse_MAD_Common(parentTree, tvb, offset, &MadData)) { @@ -3078,9 +3078,9 @@ static void parse_BM(proto_tree *parentTree, tvbuff_t *tvb, gint *offset) } local_offset = *offset; - PERF_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); + BM_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); local_offset += MAD_DATA_SIZE; - proto_item_set_text(PERF_header_item, "%s", "BM - Baseboard Management MAD (Dissector Not Implemented)"); + proto_item_set_text(BM_header_item, "%s", "BM - Baseboard Management MAD (Dissector Not Implemented)"); *offset = local_offset; } @@ -3093,7 +3093,7 @@ static void parse_DEV_MGT(proto_tree *parentTree, tvbuff_t *tvb, gint *offset) /* Parse the Common MAD Header */ MAD_Data MadData; gint local_offset; - proto_item *PERF_header_item; + proto_item *DEVM_header_item; if (!parse_MAD_Common(parentTree, tvb, offset, &MadData)) { @@ -3101,9 +3101,9 @@ static void parse_DEV_MGT(proto_tree *parentTree, tvbuff_t *tvb, gint *offset) return; } local_offset = *offset; - PERF_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); + DEVM_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); local_offset += MAD_DATA_SIZE; - proto_item_set_text(PERF_header_item, "%s", "DEV_MGT - Device Management MAD (Dissector Not Implemented)"); + proto_item_set_text(DEVM_header_item, "%s", "DEV_MGT - Device Management MAD (Dissector Not Implemented)"); *offset = local_offset; } @@ -3757,7 +3757,7 @@ static void parse_SNMP(proto_tree *parentTree, tvbuff_t *tvb, gint *offset) /* Parse the Common MAD Header */ MAD_Data MadData; gint local_offset; - proto_item *PERF_header_item; + proto_item *SNMP_header_item; if (!parse_MAD_Common(parentTree, tvb, offset, &MadData)) { @@ -3766,9 +3766,9 @@ static void parse_SNMP(proto_tree *parentTree, tvbuff_t *tvb, gint *offset) } local_offset = *offset; - PERF_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); + SNMP_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); local_offset += MAD_DATA_SIZE; - proto_item_set_text(PERF_header_item, "%s", "SNMP - SNMP Tunneling MAD (Dissector Not Implemented)"); + proto_item_set_text(SNMP_header_item, "%s", "SNMP - SNMP Tunneling MAD (Dissector Not Implemented)"); *offset = local_offset; } @@ -3781,7 +3781,7 @@ static void parse_VENDOR_MANAGEMENT(proto_tree *parentTree, tvbuff_t *tvb, gint /* Parse the Common MAD Header */ MAD_Data MadData; gint local_offset; - proto_item *PERF_header_item; + proto_item *VENDOR_header_item; if (!parse_MAD_Common(parentTree, tvb, offset, &MadData)) { @@ -3790,9 +3790,9 @@ static void parse_VENDOR_MANAGEMENT(proto_tree *parentTree, tvbuff_t *tvb, gint } local_offset = *offset; - PERF_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); + VENDOR_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); local_offset += MAD_DATA_SIZE; - proto_item_set_text(PERF_header_item, "%s", "VENDOR - Vendor Specific Management MAD (Dissector Not Implemented)"); + proto_item_set_text(VENDOR_header_item, "%s", "VENDOR - Vendor Specific Management MAD (Dissector Not Implemented)"); *offset = local_offset; } @@ -3805,7 +3805,7 @@ static void parse_APPLICATION_MANAGEMENT(proto_tree *parentTree, tvbuff_t *tvb, /* Parse the Common MAD Header */ MAD_Data MadData; gint local_offset; - proto_item *PERF_header_item; + proto_item *APP_header_item; if (!parse_MAD_Common(parentTree, tvb, offset, &MadData)) { @@ -3813,9 +3813,9 @@ static void parse_APPLICATION_MANAGEMENT(proto_tree *parentTree, tvbuff_t *tvb, return; } local_offset = *offset; - PERF_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); + APP_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, MAD_DATA_SIZE, ENC_NA); local_offset += MAD_DATA_SIZE; - proto_item_set_text(PERF_header_item, "%s", "APP - Application Specific MAD (Dissector Not Implemented)"); + proto_item_set_text(APP_header_item, "%s", "APP - Application Specific MAD (Dissector Not Implemented)"); *offset = local_offset; } @@ -3833,7 +3833,7 @@ static void parse_RESERVED_MANAGEMENT(proto_tree *parentTree, tvbuff_t *tvb, gin /* Parse the Common MAD Header */ MAD_Data MadData; gint local_offset; - proto_item *PERF_header_item; + proto_item *RESV_header_item; if (!parse_MAD_Common(parentTree, tvb, offset, &MadData)) { @@ -3841,9 +3841,9 @@ static void parse_RESERVED_MANAGEMENT(proto_tree *parentTree, tvbuff_t *tvb, gin return; } local_offset = *offset; - PERF_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, 256, ENC_NA); + RESV_header_item = proto_tree_add_item(parentTree, hf_infiniband_smp_data, tvb, local_offset, 256, ENC_NA); local_offset += 256; - proto_item_set_text(PERF_header_item, "%s", "RESERVED - Reserved MAD Type (Possible Device Error)"); + proto_item_set_text(RESV_header_item, "%s", "RESERVED - Reserved MAD Type (Possible Device Error)"); *offset = local_offset; } |