diff options
| author | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2013-06-22 02:00:03 +0000 |
|---|---|---|
| committer | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2013-06-22 02:00:03 +0000 |
| commit | 707e2ce4098a65abde3dc2e89c970cd580937a4c (patch) | |
| tree | d9a80fa88d50205bf0b92095c53a4f6d14d05432 /epan | |
| parent | e18e93348236cd5e21f4d5c972b5d9c820ba1c75 (diff) | |
Make TCP segment length a generated field instead of a hidden field.
We should deprecate the use of hidden fields, at least for fields that arei
useful in filters. To make it easier for users to discover and use the fields.
Change the highly useful field for TCP segment payload length from
being a hidden field to be a generated field instead.
svn path=/trunk/; revision=50112
Diffstat (limited to 'epan')
| -rw-r--r-- | epan/dissectors/packet-tcp.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/epan/dissectors/packet-tcp.c b/epan/dissectors/packet-tcp.c index 80511315c7..90bea4c96a 100644 --- a/epan/dissectors/packet-tcp.c +++ b/epan/dissectors/packet-tcp.c @@ -4300,10 +4300,11 @@ dissect_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) tcph->th_seglen = reported_len - tcph->th_hlen; tcph->th_have_seglen = TRUE; - if (tree) { /* Add the seglen as an invisible field */ + if (tree) { + proto_item *pi; - hidden_item = proto_tree_add_uint(ti, hf_tcp_len, tvb, offset+12, 1, tcph->th_seglen); - PROTO_ITEM_SET_HIDDEN(hidden_item); + pi = proto_tree_add_uint(ti, hf_tcp_len, tvb, offset+12, 1, tcph->th_seglen); + PROTO_ITEM_SET_GENERATED(pi); } |