diff options
author | Guy Harris <guy@alum.mit.edu> | 2019-03-29 19:20:44 -0700 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2019-03-30 02:21:24 +0000 |
commit | 1d984e598e10bd6bec8b10ee8527f1aa7e274303 (patch) | |
tree | 90d75f49d38cf70c8fe295017463a1da20fdc3fa /epan | |
parent | 2cb8bed2e4c7b7bb9ecbfb35f119d1be8d568f96 (diff) |
Update a comment.
Update a URL, raise questions about *which* escape sequences give you
24-bit color on Windows.
Change-Id: Ic88e29de1049824210be2857b75409a5ffa1585e
Reviewed-on: https://code.wireshark.org/review/32624
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan')
-rw-r--r-- | epan/print_stream.c | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/epan/print_stream.c b/epan/print_stream.c index 5d06858277..d8193cca5f 100644 --- a/epan/print_stream.c +++ b/epan/print_stream.c @@ -72,12 +72,27 @@ print_color_escape(FILE *fh, const color_t *fg, const color_t *bg) * * https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences * - * documents all the escape sequences the Console supports. + * documents all the escape sequences the Console supports. The current + * version says that 24-bit color is supported using Operating System + * Command (OSC) control sequences and that the ODA versions with 24-bit + * color are supported but select the closest color from the 16-color + * palette. * * The console in Windows 10 builds 14931 (a preview version of Windows 10 * version 1703) and later supports SGR RGB sequences: * - * https://blogs.msdn.microsoft.com/commandline/2016/09/22/24-bit-color-in-the-windows-console/ + * https://devblogs.microsoft.com/commandline/24-bit-color-in-the-windows-console/ + * + * That page says: + * + * Thanks to our ability to run Linux apps and scripts using our new + * Bash on Ubuntu on Windows environment atop the Windows Subsystem + * for Linux (WSL), we can use some Linux scripts and tools to + * demonstrate the Console's new 24-bit color support: + * + * which suggests that, with that version, whatever escape sequences + * work on UN*Xes also work on Windows, so maybe they support full + * 24-bit color with the ODA versions. * * We might want to print those instead depending on the version of * Windows or just remove the SetConsoleTextAttribute calls and only |