diff options
| author | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2006-05-01 07:32:09 +0000 |
|---|---|---|
| committer | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2006-05-01 07:32:09 +0000 |
| commit | 9c18c35c38b0e91758f5b329da25d2e34cac0422 (patch) | |
| tree | 8192ab7c9d6a5ea7f8e889d7ba03a618f27f5e52 /epan | |
| parent | 0dfbc73cbedd0d1b88218eb594f88bc98c583faf (diff) | |
remove a test for NULL we dont need since itlq can not be null here and thus we
dont need to test for it.
this unnecessary test for itlq==NULL was shown by coverity issue 151
svn path=/trunk/; revision=18052
Diffstat (limited to 'epan')
| -rw-r--r-- | epan/dissectors/packet-scsi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-scsi.c b/epan/dissectors/packet-scsi.c index 9e6da816ba..24c01aec80 100644 --- a/epan/dissectors/packet-scsi.c +++ b/epan/dissectors/packet-scsi.c @@ -6302,7 +6302,7 @@ dissect_scsi_rsp (tvbuff_t *tvb, packet_info *pinfo, cdata->type=SCSI_PDU_TYPE_RSP; tap_queue_packet(scsi_tap, pinfo, cdata); - csdata=get_cmdset_data(itlq, itl); + csdata=get_cmdset_data(itlq, itl); /* will gassert if itlq is null */ /* Nothing really to do here, just print some stuff passed to us */ @@ -6323,7 +6323,7 @@ dissect_scsi_rsp (tvbuff_t *tvb, packet_info *pinfo, ti=proto_tree_add_uint_format(scsi_tree, hf_scsi_inq_devtype, tvb, 0, 0, itl->cmdset, "Command Set:%s (0x%02x)", val_to_str(itl->cmdset, scsi_devtype_val, "Unknown"), itl->cmdset); PROTO_ITEM_SET_GENERATED(ti); - if(itlq && itlq->scsi_opcode!=0xffff){ + if(itlq->scsi_opcode!=0xffff){ ti=proto_tree_add_uint(scsi_tree, csdata->hf_opcode, tvb, 0, 0, itlq->scsi_opcode); PROTO_ITEM_SET_GENERATED(ti); } |