diff options
| author | Jeff Morriss <jeff.morriss@ulticom.com> | 2010-10-21 00:37:40 +0000 |
|---|---|---|
| committer | Jeff Morriss <jeff.morriss@ulticom.com> | 2010-10-21 00:37:40 +0000 |
| commit | 30ab866b25a0459cce7a414c10f2add6a84c23c0 (patch) | |
| tree | 07b8670524c48fc0079983a7595cb54db94263c5 /epan/wslua | |
| parent | 773a7f4c59633cad61d32bb048b82945af85be88 (diff) | |
From Holger Freyther via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5320 :
Doing a Dumper:close() and then forcing the dumper to be garbage collected will
cause a segfault.
The code attempts to handle the GC that could follow but fails to do it
properly. Assigning Dumper dp = NULL will only have an affect within the scope
of this method... Assumingly this should be a *dp = NULL.
svn path=/trunk/; revision=34597
Diffstat (limited to 'epan/wslua')
| -rw-r--r-- | epan/wslua/wslua_dumper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/wslua/wslua_dumper.c b/epan/wslua/wslua_dumper.c index e7bd4221df..358dde2418 100644 --- a/epan/wslua/wslua_dumper.c +++ b/epan/wslua/wslua_dumper.c @@ -241,7 +241,7 @@ WSLUA_METHOD Dumper_close(lua_State* L) { } /* this way if we close a dumper any attempt to use it (for everything but GC) will yield an error */ - dp = NULL; + *dp = NULL; return 0; } |