Sorry, I forgot that 8.6. UDVM Cycles says

	Note that the number of UDVM cycles MUST NOT be increased if a
	request for additional compressed data fails.

so we *shouldn't* increase the cycle count further when
SIGCOMP_INSTR_INPUT_BYTES fails.  That does *NOT* of course, mean that
we shouldn't increase the cycle count by 1 for a failed INPUT-BYTES
instruction - that would leave UDVM vulnerable to infinite loops (as per
bug 4826), and I *really* doubt that was their intent; presumably, it
means it should not be increased *by the number of cycles for the
additional data*:

	Additionally, if the UDVM successfully requests n bits of
	compressed data using one of the INPUT instructions then the
	number of available UDVM cycles is increased by n *
	cycles_per_bit once the instruction has been executed.

if the attempt to get that additional data fails.

svn path=/trunk/; revision=33065

1 files changed, 0 insertions, 1 deletions

diff --git a/epan/sigcomp-udvm.c b/epan/sigcomp-udvm.c
index 701a1df429..cb5a3a61ba 100644
--- a/epan/sigcomp-udvm.c
+++ b/epan/sigcomp-udvm.c
@@ -1903,7 +1903,6 @@ execute_next_instruction:
 			if (input_address > ( msg_end - 1)){
 				current_address = at_address;
 				result_code = 14;
-				used_udvm_cycles = used_udvm_cycles + length;
 				goto execute_next_instruction;
 			}