Fix a bunch of warnings.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().

Change some data types to avoid those implicit conversion warnings.

When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.

Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers.  Cast
away those warnings in some cases where an API we don't control forces
us to do so.

Enable a bunch of additional warnings by default.  Note why at least
some of the other warnings aren't enabled.

randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.

If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.

svn path=/trunk/; revision=46748

1 files changed, 7 insertions, 3 deletions

diff --git a/epan/req_resp_hdrs.c b/epan/req_resp_hdrs.c
index b7af5bd7e1..f6ae0a6303 100644
--- a/epan/req_resp_hdrs.c
+++ b/epan/req_resp_hdrs.c
@@ -44,9 +44,9 @@ req_resp_hdrs_do_reassembly(tvbuff_t *tvb, const int offset, packet_info *pinfo,
 	gint		next_offset;
 	gint		next_offset_sav;
 	gint		length_remaining, reported_length_remaining;
-	int			linelen;
+	int		linelen;
 	gchar		*header_val;
-	long int	content_length;
+	int		content_length;
 	gboolean	content_length_found = FALSE;
 	gboolean	content_type_found = FALSE;
 	gboolean	chunked_encoding = FALSE;
@@ -153,7 +153,11 @@ req_resp_hdrs_do_reassembly(tvbuff_t *tvb, const int offset, packet_info *pinfo,
 				 */
 				line = tvb_get_ephemeral_string(tvb, next_offset_sav, linelen);
 				if (g_ascii_strncasecmp(line, "Content-Length:", 15) == 0) {
-					if (sscanf(line+15,"%li", &content_length) == 1)
+					/* XXX - what if it doesn't fit in an int?
+					   (Do not "fix" that by making this
+					   a "long"; make it a gint64 or a
+					   guint64.) */
+					if (sscanf(line+15,"%i", &content_length) == 1)
 						content_length_found = TRUE;
 				} else if (g_ascii_strncasecmp(line, "Content-Type:", 13) == 0) {
 					content_type_found = TRUE;