aboutsummaryrefslogtreecommitdiffstats
path: root/epan/expert.h
diff options
context:
space:
mode:
authorMichael Mann <mmann78@netscape.net>2015-09-20 22:20:40 -0400
committerMichael Mann <mmann78@netscape.net>2015-09-21 14:11:43 +0000
commite2735ecfdd7a96ce909cf5e2be27da1d49d7b321 (patch)
tree51c278fbcca1a1f3fee295f8ef084110e78cd8ce /epan/expert.h
parent3b09a9e4570a876faec23ba7a1d8be8ac981f92a (diff)
Remove proto_tree_add_text API.
Its time has finally come. Technically I just renamed it to proto_tree_add_text_internal and removed the WS_DLL_PUBLIC (so it shouldn't link outside of epan). It's still (legitimately) used by expert.c otherwise I would have made it static within proto.c (and the rename wouldn't have been necessary). Change-Id: I9bdf888d5e92bc7b70a3f5461b9297a66d994b80 Reviewed-on: https://code.wireshark.org/review/10594 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
Diffstat (limited to 'epan/expert.h')
-rw-r--r--epan/expert.h10
1 files changed, 5 insertions, 5 deletions
diff --git a/epan/expert.h b/epan/expert.h
index 6bb14cc301..fabe2f67d3 100644
--- a/epan/expert.h
+++ b/epan/expert.h
@@ -132,9 +132,8 @@ expert_add_info_format(packet_info *pinfo, proto_item *pi, expert_field *eiindex
/** Add an expert info associated with some byte data
Add an expert info tree to a protocol item using registered expert info item.
- This function is intended to replace places where
- proto_tree_add_text or proto_tree_add_none_format + expert_add_info
- would be used.
+ This function is intended to replace places where a "text only" proto_tree_add_xxx
+ API + expert_add_info would be used.
@param tree Current protocol tree (or NULL)
@param pinfo Packet info of the currently processed packet. May be NULL if tree is supplied
@param eiindex The registered expert info item
@@ -150,8 +149,9 @@ proto_tree_add_expert(proto_tree *tree, packet_info *pinfo, expert_field *eiinde
/** Add an expert info associated with some byte data
Add an expert info tree to a protocol item, using registered expert info item,
but with a formatted message.
- This function is intended to replace places where
- proto_tree_add_text or proto_tree_add_none_format + expert_add_info_format
+ Add an expert info tree to a protocol item using registered expert info item.
+ This function is intended to replace places where a "text only" proto_tree_add_xxx
+ API + expert_add_info_format
would be used.
@param tree Current protocol tree (or NULL)
@param pinfo Packet info of the currently processed packet. May be NULL if tree is supplied