diff options
author | Dario Lombardo <lomato@gmail.com> | 2021-03-23 16:41:54 +0100 |
---|---|---|
committer | Wireshark GitLab Utility <gerald+gitlab-utility@wireshark.org> | 2021-03-25 09:38:10 +0000 |
commit | ea929d6401351916e0abca7429979eee9c47d3f2 (patch) | |
tree | 522492a802e608e8049fa5a3586477053002bce0 /epan/dissectors | |
parent | e6df13076281a704e9dd1aa8c2afe3e7dce015e3 (diff) |
wsutils: add local implementation of g_memdup2.
g_memdup() was deprecated and replaced with g_memdup2() in GLib 2.68,
we provide our own copy of g_memdup2() for older GLib versions.
Diffstat (limited to 'epan/dissectors')
-rw-r--r-- | epan/dissectors/asn1/c1222/packet-c1222-template.c | 2 | ||||
-rw-r--r-- | epan/dissectors/asn1/kerberos/packet-kerberos-template.c | 4 | ||||
-rw-r--r-- | epan/dissectors/asn1/snmp/packet-snmp-template.c | 36 | ||||
-rw-r--r-- | epan/dissectors/packet-c1222.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-http.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-ieee802154.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-imf.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-isakmp.c | 20 | ||||
-rw-r--r-- | epan/dissectors/packet-k12.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-kerberos.c | 4 | ||||
-rw-r--r-- | epan/dissectors/packet-mtp3.c | 4 | ||||
-rw-r--r-- | epan/dissectors/packet-nfs.c | 4 | ||||
-rw-r--r-- | epan/dissectors/packet-rpc.c | 4 | ||||
-rw-r--r-- | epan/dissectors/packet-smb2.c | 8 | ||||
-rw-r--r-- | epan/dissectors/packet-snmp.c | 36 | ||||
-rw-r--r-- | epan/dissectors/packet-systemd-journal.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-zbee-nwk-gp.c | 10 | ||||
-rw-r--r-- | epan/dissectors/packet-zbee-security.c | 6 |
18 files changed, 75 insertions, 75 deletions
diff --git a/epan/dissectors/asn1/c1222/packet-c1222-template.c b/epan/dissectors/asn1/c1222/packet-c1222-template.c index 7b3a1ca5b3..13de7f21d1 100644 --- a/epan/dissectors/asn1/c1222/packet-c1222-template.c +++ b/epan/dissectors/asn1/c1222/packet-c1222-template.c @@ -717,7 +717,7 @@ c1222_uat_data_copy_cb(void *dest, const void *source, size_t len _U_) d->keynum = o->keynum; d->keylen = o->keylen; - d->key = (guchar *)g_memdup(o->key, o->keylen); + d->key = (guchar *)g_memdup2(o->key, o->keylen); return dest; } diff --git a/epan/dissectors/asn1/kerberos/packet-kerberos-template.c b/epan/dissectors/asn1/kerberos/packet-kerberos-template.c index 6caa2e6dbc..68b64b4f09 100644 --- a/epan/dissectors/asn1/kerberos/packet-kerberos-template.c +++ b/epan/dissectors/asn1/kerberos/packet-kerberos-template.c @@ -2169,7 +2169,7 @@ add_encryption_key(packet_info *pinfo, int keytype, int keylength, const char *k new_key->kvno = 0; new_key->keytype = keytype; new_key->length = keylength; - new_key->contents = g_memdup(keyvalue, keylength); + new_key->contents = g_memdup2(keyvalue, keylength); g_snprintf(new_key->origin, KRB_MAX_ORIG_LEN, "%s learnt from frame %u", origin, pinfo->num); service_key_list = g_slist_append(service_key_list, (gpointer) new_key); } @@ -2297,7 +2297,7 @@ read_keytab_file(const char *service_key_file) sk->kvno = buf[0] << 8 | buf[1]; sk->keytype = KEYTYPE_DES3_CBC_MD5; sk->length = DES3_KEY_SIZE; - sk->contents = g_memdup(buf + 2, DES3_KEY_SIZE); + sk->contents = g_memdup2(buf + 2, DES3_KEY_SIZE); g_snprintf(sk->origin, KRB_MAX_ORIG_LEN, "3DES service key file, key #%d, offset %ld", count, ftell(skf)); service_key_list = g_slist_append(service_key_list, (gpointer) sk); if (fseek(skf, newline_skip, SEEK_CUR) < 0) { diff --git a/epan/dissectors/asn1/snmp/packet-snmp-template.c b/epan/dissectors/asn1/snmp/packet-snmp-template.c index 689ee2aadf..503e02e3f9 100644 --- a/epan/dissectors/asn1/snmp/packet-snmp-template.c +++ b/epan/dissectors/asn1/snmp/packet-snmp-template.c @@ -1427,25 +1427,25 @@ static void set_ue_keys(snmp_ue_assoc_t* n ) { static snmp_ue_assoc_t* ue_dup(snmp_ue_assoc_t* o) { - snmp_ue_assoc_t* d = (snmp_ue_assoc_t*)g_memdup(o,sizeof(snmp_ue_assoc_t)); + snmp_ue_assoc_t* d = (snmp_ue_assoc_t*)g_memdup2(o,sizeof(snmp_ue_assoc_t)); d->user.authModel = o->user.authModel; d->user.privProtocol = o->user.privProtocol; - d->user.userName.data = (guint8 *)g_memdup(o->user.userName.data,o->user.userName.len); + d->user.userName.data = (guint8 *)g_memdup2(o->user.userName.data,o->user.userName.len); d->user.userName.len = o->user.userName.len; - d->user.authPassword.data = o->user.authPassword.data ? (guint8 *)g_memdup(o->user.authPassword.data,o->user.authPassword.len) : NULL; + d->user.authPassword.data = o->user.authPassword.data ? (guint8 *)g_memdup2(o->user.authPassword.data,o->user.authPassword.len) : NULL; d->user.authPassword.len = o->user.authPassword.len; - d->user.privPassword.data = o->user.privPassword.data ? (guint8 *)g_memdup(o->user.privPassword.data,o->user.privPassword.len) : NULL; + d->user.privPassword.data = o->user.privPassword.data ? (guint8 *)g_memdup2(o->user.privPassword.data,o->user.privPassword.len) : NULL; d->user.privPassword.len = o->user.privPassword.len; d->engine.len = o->engine.len; if (d->engine.len) { - d->engine.data = (guint8 *)g_memdup(o->engine.data,o->engine.len); + d->engine.data = (guint8 *)g_memdup2(o->engine.data,o->engine.len); set_ue_keys(d); } @@ -1465,24 +1465,24 @@ snmp_users_copy_cb(void* dest, const void* orig, size_t len _U_) d->priv_proto = o->priv_proto; d->user.privProtocol = priv_protos[o->priv_proto]; - d->user.userName.data = (guint8*)g_memdup(o->user.userName.data,o->user.userName.len); + d->user.userName.data = (guint8*)g_memdup2(o->user.userName.data,o->user.userName.len); d->user.userName.len = o->user.userName.len; - d->user.authPassword.data = o->user.authPassword.data ? (guint8*)g_memdup(o->user.authPassword.data,o->user.authPassword.len) : NULL; + d->user.authPassword.data = o->user.authPassword.data ? (guint8*)g_memdup2(o->user.authPassword.data,o->user.authPassword.len) : NULL; d->user.authPassword.len = o->user.authPassword.len; - d->user.privPassword.data = o->user.privPassword.data ? (guint8*)g_memdup(o->user.privPassword.data,o->user.privPassword.len) : NULL; + d->user.privPassword.data = o->user.privPassword.data ? (guint8*)g_memdup2(o->user.privPassword.data,o->user.privPassword.len) : NULL; d->user.privPassword.len = o->user.privPassword.len; d->engine.len = o->engine.len; if (o->engine.data) { - d->engine.data = (guint8*)g_memdup(o->engine.data,o->engine.len); + d->engine.data = (guint8*)g_memdup2(o->engine.data,o->engine.len); } - d->user.authKey.data = o->user.authKey.data ? (guint8*)g_memdup(o->user.authKey.data,o->user.authKey.len) : NULL; + d->user.authKey.data = o->user.authKey.data ? (guint8*)g_memdup2(o->user.authKey.data,o->user.authKey.len) : NULL; d->user.authKey.len = o->user.authKey.len; - d->user.privKey.data = o->user.privKey.data ? (guint8*)g_memdup(o->user.privKey.data,o->user.privKey.len) : NULL; + d->user.privKey.data = o->user.privKey.data ? (guint8*)g_memdup2(o->user.privKey.data,o->user.privKey.len) : NULL; d->user.privKey.len = o->user.privKey.len; return d; @@ -1601,17 +1601,17 @@ renew_ue_cache(void) static snmp_ue_assoc_t* localize_ue( snmp_ue_assoc_t* o, const guint8* engine, guint engine_len ) { - snmp_ue_assoc_t* n = (snmp_ue_assoc_t*)g_memdup(o,sizeof(snmp_ue_assoc_t)); + snmp_ue_assoc_t* n = (snmp_ue_assoc_t*)g_memdup2(o,sizeof(snmp_ue_assoc_t)); - n->user.userName.data = (guint8*)g_memdup(o->user.userName.data,o->user.userName.len); + n->user.userName.data = (guint8*)g_memdup2(o->user.userName.data,o->user.userName.len); n->user.authModel = o->user.authModel; - n->user.authPassword.data = (guint8*)g_memdup(o->user.authPassword.data,o->user.authPassword.len); + n->user.authPassword.data = (guint8*)g_memdup2(o->user.authPassword.data,o->user.authPassword.len); n->user.authPassword.len = o->user.authPassword.len; - n->user.privPassword.data = (guint8*)g_memdup(o->user.privPassword.data,o->user.privPassword.len); + n->user.privPassword.data = (guint8*)g_memdup2(o->user.privPassword.data,o->user.privPassword.len); n->user.privPassword.len = o->user.privPassword.len; - n->user.authKey.data = (guint8*)g_memdup(o->user.authKey.data,o->user.authKey.len); - n->user.privKey.data = (guint8*)g_memdup(o->user.privKey.data,o->user.privKey.len); - n->engine.data = (guint8*)g_memdup(engine,engine_len); + n->user.authKey.data = (guint8*)g_memdup2(o->user.authKey.data,o->user.authKey.len); + n->user.privKey.data = (guint8*)g_memdup2(o->user.privKey.data,o->user.privKey.len); + n->engine.data = (guint8*)g_memdup2(engine,engine_len); n->engine.len = engine_len; n->priv_proto = o->priv_proto; diff --git a/epan/dissectors/packet-c1222.c b/epan/dissectors/packet-c1222.c index e15fd650eb..2f0797cda7 100644 --- a/epan/dissectors/packet-c1222.c +++ b/epan/dissectors/packet-c1222.c @@ -768,7 +768,7 @@ c1222_uat_data_copy_cb(void *dest, const void *source, size_t len _U_) d->keynum = o->keynum; d->keylen = o->keylen; - d->key = (guchar *)g_memdup(o->key, o->keylen); + d->key = (guchar *)g_memdup2(o->key, o->keylen); return dest; } diff --git a/epan/dissectors/packet-http.c b/epan/dissectors/packet-http.c index c44d89782c..d052b159fc 100644 --- a/epan/dissectors/packet-http.c +++ b/epan/dissectors/packet-http.c @@ -359,7 +359,7 @@ http_eo_packet(void *tapdata, packet_info *pinfo, epan_dissect_t *edt _U_, const entry->content_type = g_strdup(eo_info->content_type); entry->filename = eo_info->filename ? g_path_get_basename(eo_info->filename) : NULL; entry->payload_len = eo_info->payload_len; - entry->payload_data = (guint8 *)g_memdup(eo_info->payload_data, eo_info->payload_len); + entry->payload_data = (guint8 *)g_memdup2(eo_info->payload_data, eo_info->payload_len); object_list->add_entry(object_list->gui_data, entry); diff --git a/epan/dissectors/packet-ieee802154.c b/epan/dissectors/packet-ieee802154.c index 04f2f3cbbc..37d4c365d1 100644 --- a/epan/dissectors/packet-ieee802154.c +++ b/epan/dissectors/packet-ieee802154.c @@ -210,7 +210,7 @@ addr_uat_copy_cb(void *dest, const void *source, size_t len _U_) const static_addr_t* o = (const static_addr_t*)source; static_addr_t* d = (static_addr_t*)dest; - d->eui64 = (guchar *)g_memdup(o->eui64, o->eui64_len); + d->eui64 = (guchar *)g_memdup2(o->eui64, o->eui64_len); d->eui64_len = o->eui64_len; d->addr16 = o->addr16; d->pan = o->pan; diff --git a/epan/dissectors/packet-imf.c b/epan/dissectors/packet-imf.c index 1ad5c83d70..f4f929afc5 100644 --- a/epan/dissectors/packet-imf.c +++ b/epan/dissectors/packet-imf.c @@ -178,7 +178,7 @@ imf_eo_packet(void *tapdata, packet_info *pinfo, epan_dissect_t *edt _U_, const entry->content_type = g_strdup("EML file"); entry->filename = g_strdup_printf("%s.eml", eo_info->subject_data); entry->payload_len = eo_info->payload_len; - entry->payload_data = (guint8 *)g_memdup(eo_info->payload_data, eo_info->payload_len); + entry->payload_data = (guint8 *)g_memdup2(eo_info->payload_data, eo_info->payload_len); object_list->add_entry(object_list->gui_data, entry); diff --git a/epan/dissectors/packet-isakmp.c b/epan/dissectors/packet-isakmp.c index 57b2733fe8..efbd891089 100644 --- a/epan/dissectors/packet-isakmp.c +++ b/epan/dissectors/packet-isakmp.c @@ -6315,9 +6315,9 @@ ikev1_uat_data_copy_cb(void *dest, const void *source, size_t len _U_) const ikev1_uat_data_key_t* o = (const ikev1_uat_data_key_t*)source; ikev1_uat_data_key_t* d = (ikev1_uat_data_key_t*)dest; - d->icookie = (guchar *)g_memdup(o->icookie, o->icookie_len); + d->icookie = (guchar *)g_memdup2(o->icookie, o->icookie_len); d->icookie_len = o->icookie_len; - d->key = (guchar *)g_memdup(o->key, o->key_len); + d->key = (guchar *)g_memdup2(o->key, o->key_len); d->key_len = o->key_len; return dest; @@ -6346,29 +6346,29 @@ ikev2_uat_data_copy_cb(void *dest, const void *source, size_t len _U_) const ikev2_uat_data_t* o = (const ikev2_uat_data_t*)source; ikev2_uat_data_t* d = (ikev2_uat_data_t*)dest; - d->key.spii = (guchar *)g_memdup(o->key.spii, o->key.spii_len); + d->key.spii = (guchar *)g_memdup2(o->key.spii, o->key.spii_len); d->key.spii_len = o->key.spii_len; - d->key.spir = (guchar *)g_memdup(o->key.spir, o->key.spir_len); + d->key.spir = (guchar *)g_memdup2(o->key.spir, o->key.spir_len); d->key.spir_len = o->key.spir_len; d->encr_alg = o->encr_alg; d->auth_alg = o->auth_alg; - d->sk_ei = (guchar *)g_memdup(o->sk_ei, o->sk_ei_len); + d->sk_ei = (guchar *)g_memdup2(o->sk_ei, o->sk_ei_len); d->sk_ei_len = o->sk_ei_len; - d->sk_er = (guchar *)g_memdup(o->sk_er, o->sk_er_len); + d->sk_er = (guchar *)g_memdup2(o->sk_er, o->sk_er_len); d->sk_er_len = o->sk_er_len; - d->sk_ai = (guchar *)g_memdup(o->sk_ai, o->sk_ai_len); + d->sk_ai = (guchar *)g_memdup2(o->sk_ai, o->sk_ai_len); d->sk_ai_len = o->sk_ai_len; - d->sk_ar = (guchar *)g_memdup(o->sk_ar, o->sk_ar_len); + d->sk_ar = (guchar *)g_memdup2(o->sk_ar, o->sk_ar_len); d->sk_ar_len = o->sk_ar_len; - d->encr_spec = (ikev2_encr_alg_spec_t *)g_memdup(o->encr_spec, sizeof(ikev2_encr_alg_spec_t)); - d->auth_spec = (ikev2_auth_alg_spec_t *)g_memdup(o->auth_spec, sizeof(ikev2_auth_alg_spec_t)); + d->encr_spec = (ikev2_encr_alg_spec_t *)g_memdup2(o->encr_spec, sizeof(ikev2_encr_alg_spec_t)); + d->auth_spec = (ikev2_auth_alg_spec_t *)g_memdup2(o->auth_spec, sizeof(ikev2_auth_alg_spec_t)); return dest; } diff --git a/epan/dissectors/packet-k12.c b/epan/dissectors/packet-k12.c index dd08af5423..ef2d65717a 100644 --- a/epan/dissectors/packet-k12.c +++ b/epan/dissectors/packet-k12.c @@ -332,7 +332,7 @@ k12_copy_cb(void* dest, const void* orig, size_t len _U_) d->match = g_strdup(o->match); d->protos = g_strdup(o->protos); - d->handles = (dissector_handle_t *)g_memdup(o->handles,(guint)(sizeof(dissector_handle_t)*(num_protos+1))); + d->handles = (dissector_handle_t *)g_memdup2(o->handles,(guint)(sizeof(dissector_handle_t)*(num_protos+1))); g_strfreev(protos); diff --git a/epan/dissectors/packet-kerberos.c b/epan/dissectors/packet-kerberos.c index b586bbf79e..87d7aed1d4 100644 --- a/epan/dissectors/packet-kerberos.c +++ b/epan/dissectors/packet-kerberos.c @@ -2609,7 +2609,7 @@ add_encryption_key(packet_info *pinfo, int keytype, int keylength, const char *k new_key->kvno = 0; new_key->keytype = keytype; new_key->length = keylength; - new_key->contents = g_memdup(keyvalue, keylength); + new_key->contents = g_memdup2(keyvalue, keylength); g_snprintf(new_key->origin, KRB_MAX_ORIG_LEN, "%s learnt from frame %u", origin, pinfo->num); service_key_list = g_slist_append(service_key_list, (gpointer) new_key); } @@ -2737,7 +2737,7 @@ read_keytab_file(const char *service_key_file) sk->kvno = buf[0] << 8 | buf[1]; sk->keytype = KEYTYPE_DES3_CBC_MD5; sk->length = DES3_KEY_SIZE; - sk->contents = g_memdup(buf + 2, DES3_KEY_SIZE); + sk->contents = g_memdup2(buf + 2, DES3_KEY_SIZE); g_snprintf(sk->origin, KRB_MAX_ORIG_LEN, "3DES service key file, key #%d, offset %ld", count, ftell(skf)); service_key_list = g_slist_append(service_key_list, (gpointer) sk); if (fseek(skf, newline_skip, SEEK_CUR) < 0) { diff --git a/epan/dissectors/packet-mtp3.c b/epan/dissectors/packet-mtp3.c index 569ca1d0db..f74c14ee7c 100644 --- a/epan/dissectors/packet-mtp3.c +++ b/epan/dissectors/packet-mtp3.c @@ -911,13 +911,13 @@ mtp3_stat_packet(void *tapdata, packet_info *pinfo _U_, epan_dissect_t *edt _U_, item_data = stat_tap_get_field_data(table, element, OPC_COLUMN); mtp3_addr_to_str_buf(&m3tr->addr_opc, str, 256); item_data->value.string_value = g_strdup(str); - item_data->user_data.ptr_value = g_memdup(&m3tr->addr_opc, sizeof(mtp3_tap_rec_t)); + item_data->user_data.ptr_value = g_memdup2(&m3tr->addr_opc, sizeof(mtp3_tap_rec_t)); stat_tap_set_field_data(table, element, OPC_COLUMN, item_data); item_data = stat_tap_get_field_data(table, element, DPC_COLUMN); mtp3_addr_to_str_buf(&m3tr->addr_dpc, str, 256); item_data->value.string_value = g_strdup(str); - item_data->user_data.ptr_value = g_memdup(&m3tr->addr_dpc, sizeof(mtp3_tap_rec_t)); + item_data->user_data.ptr_value = g_memdup2(&m3tr->addr_dpc, sizeof(mtp3_tap_rec_t)); stat_tap_set_field_data(table, element, DPC_COLUMN, item_data); sis = try_val_to_str(m3tr->mtp3_si_code, mtp3_service_indicator_code_short_vals); diff --git a/epan/dissectors/packet-nfs.c b/epan/dissectors/packet-nfs.c index a8ff4db9e6..e13e69d153 100644 --- a/epan/dissectors/packet-nfs.c +++ b/epan/dissectors/packet-nfs.c @@ -1069,7 +1069,7 @@ store_nfs_file_handle(nfs_fhandle_data_t *nfs_fh) fhlen = nfs_fh->len/4; /* align the file handle data */ - fhdata = (guint32 *)g_memdup(nfs_fh->fh, fhlen*4); + fhdata = (guint32 *)g_memdup2(nfs_fh->fh, fhlen*4); fhkey[0].length = 1; fhkey[0].key = &fhlen; fhkey[1].length = fhlen; @@ -1349,7 +1349,7 @@ nfs_name_snoop_fh(packet_info *pinfo, proto_tree *tree, tvbuff_t *tvb, int fh_of fhlen = nns->fh_length; /* align it */ - fhdata = (guint32 *)g_memdup(nns->fh, fhlen); + fhdata = (guint32 *)g_memdup2(nns->fh, fhlen); fhkey[0].length = 1; fhkey[0].key = &fhlen; fhkey[1].length = fhlen/4; diff --git a/epan/dissectors/packet-rpc.c b/epan/dissectors/packet-rpc.c index 04ef072a05..4b406b8707 100644 --- a/epan/dissectors/packet-rpc.c +++ b/epan/dissectors/packet-rpc.c @@ -561,7 +561,7 @@ rpc_init_prog(int proto, guint32 prog, int ett, size_t nvers, continue; } - dissector_add_custom_table_handle("rpc.call", g_memdup(&key, sizeof(rpc_proc_info_key)), + dissector_add_custom_table_handle("rpc.call", g_memdup2(&key, sizeof(rpc_proc_info_key)), create_dissector_handle_with_name(proc->dissect_call, value->proto_id, proc->strptr)); if (proc->dissect_reply == NULL) { @@ -576,7 +576,7 @@ rpc_init_prog(int proto, guint32 prog, int ett, size_t nvers, continue; } - dissector_add_custom_table_handle("rpc.reply", g_memdup(&key, sizeof(rpc_proc_info_key)), + dissector_add_custom_table_handle("rpc.reply", g_memdup2(&key, sizeof(rpc_proc_info_key)), create_dissector_handle_with_name(proc->dissect_reply, value->proto_id, proc->strptr)); } } diff --git a/epan/dissectors/packet-smb2.c b/epan/dissectors/packet-smb2.c index 0115b53ab0..eb2a7eb877 100644 --- a/epan/dissectors/packet-smb2.c +++ b/epan/dissectors/packet-smb2.c @@ -1248,13 +1248,13 @@ static void* seskey_list_copy_cb(void *n, const void *o, size_t siz _U_) const smb2_seskey_field_t *old_rec = (const smb2_seskey_field_t *)o; new_rec->id_len = old_rec->id_len; - new_rec->id = old_rec->id ? (guchar *)g_memdup(old_rec->id, old_rec->id_len) : NULL; + new_rec->id = old_rec->id ? (guchar *)g_memdup2(old_rec->id, old_rec->id_len) : NULL; new_rec->seskey_len = old_rec->seskey_len; - new_rec->seskey = old_rec->seskey ? (guchar *)g_memdup(old_rec->seskey, old_rec->seskey_len) : NULL; + new_rec->seskey = old_rec->seskey ? (guchar *)g_memdup2(old_rec->seskey, old_rec->seskey_len) : NULL; new_rec->s2ckey_len = old_rec->s2ckey_len; - new_rec->s2ckey = old_rec->s2ckey ? (guchar *)g_memdup(old_rec->s2ckey, old_rec->s2ckey_len) : NULL; + new_rec->s2ckey = old_rec->s2ckey ? (guchar *)g_memdup2(old_rec->s2ckey, old_rec->s2ckey_len) : NULL; new_rec->c2skey_len = old_rec->c2skey_len; - new_rec->c2skey = old_rec->c2skey ? (guchar *)g_memdup(old_rec->c2skey, old_rec->c2skey_len) : NULL; + new_rec->c2skey = old_rec->c2skey ? (guchar *)g_memdup2(old_rec->c2skey, old_rec->c2skey_len) : NULL; return new_rec; } diff --git a/epan/dissectors/packet-snmp.c b/epan/dissectors/packet-snmp.c index 05fd83aa35..a70e7c60d2 100644 --- a/epan/dissectors/packet-snmp.c +++ b/epan/dissectors/packet-snmp.c @@ -1529,25 +1529,25 @@ static void set_ue_keys(snmp_ue_assoc_t* n ) { static snmp_ue_assoc_t* ue_dup(snmp_ue_assoc_t* o) { - snmp_ue_assoc_t* d = (snmp_ue_assoc_t*)g_memdup(o,sizeof(snmp_ue_assoc_t)); + snmp_ue_assoc_t* d = (snmp_ue_assoc_t*)g_memdup2(o,sizeof(snmp_ue_assoc_t)); d->user.authModel = o->user.authModel; d->user.privProtocol = o->user.privProtocol; - d->user.userName.data = (guint8 *)g_memdup(o->user.userName.data,o->user.userName.len); + d->user.userName.data = (guint8 *)g_memdup2(o->user.userName.data,o->user.userName.len); d->user.userName.len = o->user.userName.len; - d->user.authPassword.data = o->user.authPassword.data ? (guint8 *)g_memdup(o->user.authPassword.data,o->user.authPassword.len) : NULL; + d->user.authPassword.data = o->user.authPassword.data ? (guint8 *)g_memdup2(o->user.authPassword.data,o->user.authPassword.len) : NULL; d->user.authPassword.len = o->user.authPassword.len; - d->user.privPassword.data = o->user.privPassword.data ? (guint8 *)g_memdup(o->user.privPassword.data,o->user.privPassword.len) : NULL; + d->user.privPassword.data = o->user.privPassword.data ? (guint8 *)g_memdup2(o->user.privPassword.data,o->user.privPassword.len) : NULL; d->user.privPassword.len = o->user.privPassword.len; d->engine.len = o->engine.len; if (d->engine.len) { - d->engine.data = (guint8 *)g_memdup(o->engine.data,o->engine.len); + d->engine.data = (guint8 *)g_memdup2(o->engine.data,o->engine.len); set_ue_keys(d); } @@ -1567,24 +1567,24 @@ snmp_users_copy_cb(void* dest, const void* orig, size_t len _U_) d->priv_proto = o->priv_proto; d->user.privProtocol = priv_protos[o->priv_proto]; - d->user.userName.data = (guint8*)g_memdup(o->user.userName.data,o->user.userName.len); + d->user.userName.data = (guint8*)g_memdup2(o->user.userName.data,o->user.userName.len); d->user.userName.len = o->user.userName.len; - d->user.authPassword.data = o->user.authPassword.data ? (guint8*)g_memdup(o->user.authPassword.data,o->user.authPassword.len) : NULL; + d->user.authPassword.data = o->user.authPassword.data ? (guint8*)g_memdup2(o->user.authPassword.data,o->user.authPassword.len) : NULL; d->user.authPassword.len = o->user.authPassword.len; - d->user.privPassword.data = o->user.privPassword.data ? (guint8*)g_memdup(o->user.privPassword.data,o->user.privPassword.len) : NULL; + d->user.privPassword.data = o->user.privPassword.data ? (guint8*)g_memdup2(o->user.privPassword.data,o->user.privPassword.len) : NULL; d->user.privPassword.len = o->user.privPassword.len; d->engine.len = o->engine.len; if (o->engine.data) { - d->engine.data = (guint8*)g_memdup(o->engine.data,o->engine.len); + d->engine.data = (guint8*)g_memdup2(o->engine.data,o->engine.len); } - d->user.authKey.data = o->user.authKey.data ? (guint8*)g_memdup(o->user.authKey.data,o->user.authKey.len) : NULL; + d->user.authKey.data = o->user.authKey.data ? (guint8*)g_memdup2(o->user.authKey.data,o->user.authKey.len) : NULL; d->user.authKey.len = o->user.authKey.len; - d->user.privKey.data = o->user.privKey.data ? (guint8*)g_memdup(o->user.privKey.data,o->user.privKey.len) : NULL; + d->user.privKey.data = o->user.privKey.data ? (guint8*)g_memdup2(o->user.privKey.data,o->user.privKey.len) : NULL; d->user.privKey.len = o->user.privKey.len; return d; @@ -1703,17 +1703,17 @@ renew_ue_cache(void) static snmp_ue_assoc_t* localize_ue( snmp_ue_assoc_t* o, const guint8* engine, guint engine_len ) { - snmp_ue_assoc_t* n = (snmp_ue_assoc_t*)g_memdup(o,sizeof(snmp_ue_assoc_t)); + snmp_ue_assoc_t* n = (snmp_ue_assoc_t*)g_memdup2(o,sizeof(snmp_ue_assoc_t)); - n->user.userName.data = (guint8*)g_memdup(o->user.userName.data,o->user.userName.len); + n->user.userName.data = (guint8*)g_memdup2(o->user.userName.data,o->user.userName.len); n->user.authModel = o->user.authModel; - n->user.authPassword.data = (guint8*)g_memdup(o->user.authPassword.data,o->user.authPassword.len); + n->user.authPassword.data = (guint8*)g_memdup2(o->user.authPassword.data,o->user.authPassword.len); n->user.authPassword.len = o->user.authPassword.len; - n->user.privPassword.data = (guint8*)g_memdup(o->user.privPassword.data,o->user.privPassword.len); + n->user.privPassword.data = (guint8*)g_memdup2(o->user.privPassword.data,o->user.privPassword.len); n->user.privPassword.len = o->user.privPassword.len; - n->user.authKey.data = (guint8*)g_memdup(o->user.authKey.data,o->user.authKey.len); - n->user.privKey.data = (guint8*)g_memdup(o->user.privKey.data,o->user.privKey.len); - n->engine.data = (guint8*)g_memdup(engine,engine_len); + n->user.authKey.data = (guint8*)g_memdup2(o->user.authKey.data,o->user.authKey.len); + n->user.privKey.data = (guint8*)g_memdup2(o->user.privKey.data,o->user.privKey.len); + n->engine.data = (guint8*)g_memdup2(engine,engine_len); n->engine.len = engine_len; n->priv_proto = o->priv_proto; diff --git a/epan/dissectors/packet-systemd-journal.c b/epan/dissectors/packet-systemd-journal.c index 9b450552c1..bab338eb55 100644 --- a/epan/dissectors/packet-systemd-journal.c +++ b/epan/dissectors/packet-systemd-journal.c @@ -287,7 +287,7 @@ static void init_jf_to_hf_map(void) { { hf_sj_systemd_user_slice, "_SYSTEMD_USER_SLICE=" }, { 0, NULL } }; - jf_to_hf = (journal_field_hf_map*) g_memdup(jhmap, sizeof(jhmap)); + jf_to_hf = (journal_field_hf_map*) g_memdup2(jhmap, sizeof(jhmap)); } static void diff --git a/epan/dissectors/packet-zbee-nwk-gp.c b/epan/dissectors/packet-zbee-nwk-gp.c index 247f30ffed..0a5b7b0ecb 100644 --- a/epan/dissectors/packet-zbee-nwk-gp.c +++ b/epan/dissectors/packet-zbee-nwk-gp.c @@ -833,7 +833,7 @@ dissect_zbee_nwk_gp_cmd_commissioning(tvbuff_t *tvb, packet_info *pinfo, proto_t key_record.frame_num = 0; key_record.label = NULL; memcpy(key_record.key, dec_buffer, ZBEE_SEC_CONST_KEYSIZE); - zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup(&key_record, sizeof(key_record_t))); + zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup2(&key_record, sizeof(key_record_t))); payload_tvb = tvb_new_child_real_data(tvb, dec_buffer, ZBEE_SEC_CONST_KEYSIZE, ZBEE_SEC_CONST_KEYSIZE); add_new_data_source(pinfo, payload_tvb, "Decrypted security key"); @@ -849,7 +849,7 @@ dissect_zbee_nwk_gp_cmd_commissioning(tvbuff_t *tvb, packet_info *pinfo, proto_t key_record.label = NULL; key = tvb_memdup(wmem_packet_scope(), tvb, offset - ZBEE_SEC_CONST_KEYSIZE, ZBEE_SEC_CONST_KEYSIZE); memcpy(key_record.key, key, ZBEE_SEC_CONST_KEYSIZE); - zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup(&key_record, sizeof(key_record_t))); + zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup2(&key_record, sizeof(key_record_t))); } } @@ -1116,7 +1116,7 @@ dissect_zbee_nwk_gp_cmd_commissioning_reply(tvbuff_t *tvb, packet_info *pinfo, p key_record.label = NULL; key = tvb_memdup(wmem_packet_scope(), tvb, offset - ZBEE_SEC_CONST_KEYSIZE, ZBEE_SEC_CONST_KEYSIZE); memcpy(key_record.key, key, ZBEE_SEC_CONST_KEYSIZE); - zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup(&key_record, sizeof(key_record_t))); + zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup2(&key_record, sizeof(key_record_t))); } } /* Parse and display security MIC. */ @@ -1157,7 +1157,7 @@ dissect_zbee_nwk_gp_cmd_commissioning_reply(tvbuff_t *tvb, packet_info *pinfo, p key_record.frame_num = 0; key_record.label = NULL; memcpy(key_record.key, dec_buffer, ZBEE_SEC_CONST_KEYSIZE); - zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup(&key_record, sizeof(key_record_t))); + zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup2(&key_record, sizeof(key_record_t))); payload_tvb = tvb_new_child_real_data(tvb, dec_buffer, ZBEE_SEC_CONST_KEYSIZE, ZBEE_SEC_CONST_KEYSIZE); add_new_data_source(pinfo, payload_tvb, "Decrypted security key"); @@ -1931,7 +1931,7 @@ gp_init_zbee_security(void) key_record.frame_num = 0; key_record.label = g_strdup(gp_uat_key_records[i].label); memcpy(key_record.key, gp_uat_key_records[i].key, ZBEE_SEC_CONST_KEYSIZE); - zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup(&key_record, sizeof(key_record_t))); + zbee_gp_keyring = g_slist_prepend(zbee_gp_keyring, g_memdup2(&key_record, sizeof(key_record_t))); } } diff --git a/epan/dissectors/packet-zbee-security.c b/epan/dissectors/packet-zbee-security.c index ed65a59450..9b9acb71c3 100644 --- a/epan/dissectors/packet-zbee-security.c +++ b/epan/dissectors/packet-zbee-security.c @@ -192,7 +192,7 @@ static void uat_key_record_post_update(void) { key_record.frame_num = ZBEE_SEC_PC_KEY; /* means it's a user PC key */ key_record.label = g_strdup(uat_key_records[i].label); memcpy(key_record.key, key, ZBEE_SEC_CONST_KEYSIZE); - zbee_pc_keyring = g_slist_prepend(zbee_pc_keyring, g_memdup(&key_record, sizeof(key_record_t))); + zbee_pc_keyring = g_slist_prepend(zbee_pc_keyring, g_memdup2(&key_record, sizeof(key_record_t))); } } } @@ -1224,7 +1224,7 @@ void zbee_sec_add_key_to_keyring(packet_info *pinfo, const guint8 *key) if ( !nwk_keyring ) { nwk_keyring = (GSList **)g_malloc0(sizeof(GSList*)); g_hash_table_insert(zbee_table_nwk_keyring, - g_memdup(&nwk_hints->src_pan, sizeof(nwk_hints->src_pan)), nwk_keyring); + g_memdup2(&nwk_hints->src_pan, sizeof(nwk_hints->src_pan)), nwk_keyring); } if ( nwk_keyring ) { @@ -1235,7 +1235,7 @@ void zbee_sec_add_key_to_keyring(packet_info *pinfo, const guint8 *key) key_record.frame_num = pinfo->num; key_record.label = NULL; memcpy(&key_record.key, key, ZBEE_APS_CMD_KEY_LENGTH); - *nwk_keyring = g_slist_prepend(*nwk_keyring, g_memdup(&key_record, sizeof(key_record_t))); + *nwk_keyring = g_slist_prepend(*nwk_keyring, g_memdup2(&key_record, sizeof(key_record_t))); } } } |