diff options
author | Bill Meier <wmeier@newsguy.com> | 2014-12-13 16:26:07 -0500 |
---|---|---|
committer | Bill Meier <wmeier@newsguy.com> | 2014-12-13 21:59:55 +0000 |
commit | 1725eee48e46a5cb4037a83910044f2d5e807261 (patch) | |
tree | c82fdcc4a46694c1c1d6057c663242646569340c /epan/dissectors | |
parent | 5992ef414e00e7123953ddf91641402153388b3b (diff) |
Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
Change-Id: Ie8cb993bb9dd3e8dbfa1876a4e731bca10ee0507
Reviewed-on: https://code.wireshark.org/review/5754
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Diffstat (limited to 'epan/dissectors')
-rw-r--r-- | epan/dissectors/packet-aastra-aasp.c | 20 | ||||
-rw-r--r-- | epan/dissectors/packet-beep.c | 4 | ||||
-rw-r--r-- | epan/dissectors/packet-corosync-totemnet.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-esis.c | 10 | ||||
-rw-r--r-- | epan/dissectors/packet-gsm_a_rp.c | 4 | ||||
-rw-r--r-- | epan/dissectors/packet-hci_mon.c | 4 | ||||
-rw-r--r-- | epan/dissectors/packet-ieee80211-airopeek.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-llc.c | 8 | ||||
-rw-r--r-- | epan/dissectors/packet-lpd.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-pw-hdlc.c | 4 | ||||
-rw-r--r-- | epan/dissectors/packet-rtpproxy.c | 8 | ||||
-rw-r--r-- | epan/dissectors/packet-slowprotocols.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-snaeth.c | 2 | ||||
-rw-r--r-- | epan/dissectors/packet-t30.c | 28 | ||||
-rw-r--r-- | epan/dissectors/packet-vssmonitoring.c | 6 |
15 files changed, 53 insertions, 53 deletions
diff --git a/epan/dissectors/packet-aastra-aasp.c b/epan/dissectors/packet-aastra-aasp.c index f5f70d8a01..10454f8774 100644 --- a/epan/dissectors/packet-aastra-aasp.c +++ b/epan/dissectors/packet-aastra-aasp.c @@ -150,7 +150,7 @@ dissect_a_binary_command(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree proto_item_append_text(ti, ", %s", val_to_str(tvb_get_guint8(tvb, 0), szCmdID, "Unk %d")); /* command id */ - proto_tree_add_item(subtree, hf_a_id, tvb, 0, 1, ENC_NA); + proto_tree_add_item(subtree, hf_a_id, tvb, 0, 1, ENC_BIG_ENDIAN); /* attributes */ switch(tvb_get_guint8(tvb, 0)) @@ -202,7 +202,7 @@ dissect_a_binary_command(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree proto_item_append_text(ti, ": %d '%c'", c, c); proto_tree_add_item(subtree, hf_a_data, tvb, 1, 4, ENC_NA); - ti = proto_tree_add_item(subtree, hf_a_button_id, tvb, 5, 1, ENC_NA); + ti = proto_tree_add_item(subtree, hf_a_button_id, tvb, 5, 1, ENC_BIG_ENDIAN); if(ti) proto_item_append_text(ti, " '%c'", c); break; @@ -212,7 +212,7 @@ dissect_a_binary_command(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree if(tvb_reported_length(tvb) > 3) { proto_tree_add_item(subtree, hf_a_data, tvb, 1, 3, ENC_NA); - proto_tree_add_item(subtree, hf_a_length, tvb, 4, 1, ENC_NA); + proto_tree_add_item(subtree, hf_a_length, tvb, 4, 1, ENC_BIG_ENDIAN); proto_tree_add_item(subtree, hf_a_text, tvb, 5, -1, ENC_ASCII|ENC_NA); pstr = tvb_get_string_enc(wmem_packet_scope(), tvb, 5, tvb_get_guint8(tvb, 4), ENC_ASCII|ENC_NA); @@ -241,7 +241,7 @@ dissect_a_binary_command(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree len = 2; ti = proto_tree_add_item(subtree, hf_a_item, tvb, i, len, ENC_NA); infotree = proto_item_add_subtree(ti, ett_a_item); - proto_tree_add_item(infotree, hf_a_day, tvb, i+1, 1, ENC_NA); + proto_tree_add_item(infotree, hf_a_day, tvb, i+1, 1, ENC_BIG_ENDIAN); proto_item_append_text(ti, ", Day: '%d'", tvb_get_guint8(tvb, i+1)); i += len; break; @@ -251,7 +251,7 @@ dissect_a_binary_command(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree len = 2; ti = proto_tree_add_item(subtree, hf_a_item, tvb, i, len, ENC_NA); infotree = proto_item_add_subtree(ti, ett_a_item); - proto_tree_add_item(infotree, hf_a_month, tvb, i+1, 1, ENC_NA); + proto_tree_add_item(infotree, hf_a_month, tvb, i+1, 1, ENC_BIG_ENDIAN); proto_item_append_text(ti, ", Month: '%d'", tvb_get_guint8(tvb, i+1)); i += len; break; @@ -261,7 +261,7 @@ dissect_a_binary_command(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree len = 2; ti = proto_tree_add_item(subtree, hf_a_item, tvb, i, len, ENC_NA); infotree = proto_item_add_subtree(ti, ett_a_item); - proto_tree_add_item(infotree, hf_a_weekofyear, tvb, i+1, 1, ENC_NA); + proto_tree_add_item(infotree, hf_a_weekofyear, tvb, i+1, 1, ENC_BIG_ENDIAN); proto_item_append_text(ti, ", Week of the year: '%d'", tvb_get_guint8(tvb, i+1)); i += len; break; @@ -317,7 +317,7 @@ dissect_a_binary_command(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree len = 2; ti = proto_tree_add_item(subtree, hf_a_item, tvb, i, len, ENC_NA); infotree = proto_item_add_subtree(ti, ett_a_item); - proto_tree_add_item(infotree, hf_a_hour, tvb, i+1, 1, ENC_NA); + proto_tree_add_item(infotree, hf_a_hour, tvb, i+1, 1, ENC_BIG_ENDIAN); proto_item_append_text(ti, ", Hour: '%d'", tvb_get_guint8(tvb, i+1)); i += len; break; @@ -327,7 +327,7 @@ dissect_a_binary_command(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree len = 2; ti = proto_tree_add_item(subtree, hf_a_item, tvb, i, len, ENC_NA); infotree = proto_item_add_subtree(ti, ett_a_item); - proto_tree_add_item(infotree, hf_a_minute, tvb, i+1, 1, ENC_NA); + proto_tree_add_item(infotree, hf_a_minute, tvb, i+1, 1, ENC_BIG_ENDIAN); proto_item_append_text(ti, ", Minute: '%d'", tvb_get_guint8(tvb, i+1)); i += len; break; @@ -349,8 +349,8 @@ dissect_a_binary_command(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree { if(tvb_reported_length(tvb) > 1) { - proto_tree_add_item(subtree, hf_a_line, tvb, 1, 1, ENC_NA); - proto_tree_add_item(subtree, hf_a_length, tvb, 2, 1, ENC_NA); + proto_tree_add_item(subtree, hf_a_line, tvb, 1, 1, ENC_BIG_ENDIAN); + proto_tree_add_item(subtree, hf_a_length, tvb, 2, 1, ENC_BIG_ENDIAN); proto_tree_add_item(subtree, hf_a_cdpn, tvb, 3, -1, ENC_ASCII|ENC_NA); pstr = tvb_get_string_enc(wmem_packet_scope(), tvb, 3, tvb_get_guint8(tvb, 2), ENC_ASCII|ENC_NA); diff --git a/epan/dissectors/packet-beep.c b/epan/dissectors/packet-beep.c index 988accd062..08f0b18207 100644 --- a/epan/dissectors/packet-beep.c +++ b/epan/dissectors/packet-beep.c @@ -221,7 +221,7 @@ dissect_beep_more(tvbuff_t *tvb, packet_info *pinfo, int offset, int ret = 0; guint8 more = tvb_get_guint8(tvb, offset); - hidden_item = proto_tree_add_item(tree, hf_beep_more, tvb, offset, 1, ENC_NA); + hidden_item = proto_tree_add_item(tree, hf_beep_more, tvb, offset, 1, ENC_BIG_ENDIAN); PROTO_ITEM_SET_HIDDEN(hidden_item); switch(more) { @@ -247,7 +247,7 @@ static void dissect_beep_status(tvbuff_t *tvb, int offset, /* FIXME: We should return a value to indicate all OK. */ - proto_tree_add_item(item_tree, hf_beep_status, tvb, offset, 1, ENC_NA); + proto_tree_add_item(item_tree, hf_beep_status, tvb, offset, 1, ENC_BIG_ENDIAN); } #endif diff --git a/epan/dissectors/packet-corosync-totemnet.c b/epan/dissectors/packet-corosync-totemnet.c index 8c43e4af22..c64ad1d241 100644 --- a/epan/dissectors/packet-corosync-totemnet.c +++ b/epan/dissectors/packet-corosync-totemnet.c @@ -109,7 +109,7 @@ dissect_corosync_totemnet_security_header(tvbuff_t *tvb, proto_tree_add_item(tree, hf_corosync_totemnet_security_crypto_type, - tvb, io_len - 1, 1, ENC_NA); + tvb, io_len - 1, 1, ENC_BIG_ENDIAN); key_item = proto_tree_add_string(tree, hf_corosync_totemnet_security_crypto_key, tvb, 0, 0, key); diff --git a/epan/dissectors/packet-esis.c b/epan/dissectors/packet-esis.c index 3377c11050..5fa0ace52a 100644 --- a/epan/dissectors/packet-esis.c +++ b/epan/dissectors/packet-esis.c @@ -260,8 +260,8 @@ dissect_esis(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) { ti = proto_tree_add_item(tree, proto_esis, tvb, 0, -1, ENC_NA); esis_tree = proto_item_add_subtree(ti, ett_esis); - proto_tree_add_item( esis_tree, hf_esis_nlpi, tvb, 0, 1, ENC_NA); - ti = proto_tree_add_item( esis_tree, hf_esis_length, tvb, 1, 1, ENC_NA ); + proto_tree_add_item( esis_tree, hf_esis_nlpi, tvb, 0, 1, ENC_BIG_ENDIAN); + ti = proto_tree_add_item( esis_tree, hf_esis_length, tvb, 1, 1, ENC_BIG_ENDIAN ); length = tvb_get_guint8(tvb, 1); if (length < ESIS_HDR_FIXED_LENGTH) { expert_add_info_format(pinfo, ti, &ei_esis_length, @@ -271,16 +271,16 @@ dissect_esis(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) { } version = tvb_get_guint8(tvb, 2); - ti = proto_tree_add_item( esis_tree, hf_esis_version, tvb, 2, 1, ENC_NA); + ti = proto_tree_add_item( esis_tree, hf_esis_version, tvb, 2, 1, ENC_BIG_ENDIAN); if (version != ESIS_REQUIRED_VERSION){ expert_add_info_format(pinfo, ti, &ei_esis_version, "Unknown ESIS version (%u vs %u)", version, ESIS_REQUIRED_VERSION ); } - proto_tree_add_item( esis_tree, hf_esis_reserved, tvb, 3, 1, ENC_NA); + proto_tree_add_item( esis_tree, hf_esis_reserved, tvb, 3, 1, ENC_BIG_ENDIAN); - type_item = proto_tree_add_item( esis_tree, hf_esis_type, tvb, 4, 1, ENC_NA); + type_item = proto_tree_add_item( esis_tree, hf_esis_type, tvb, 4, 1, ENC_BIG_ENDIAN); type = tvb_get_guint8(tvb, 4) & OSI_PDU_TYPE_MASK; holdtime = tvb_get_ntohs(tvb, 5); diff --git a/epan/dissectors/packet-gsm_a_rp.c b/epan/dissectors/packet-gsm_a_rp.c index 9b116942b6..d8f11122d4 100644 --- a/epan/dissectors/packet-gsm_a_rp.c +++ b/epan/dissectors/packet-gsm_a_rp.c @@ -113,7 +113,7 @@ de_rp_message_ref(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo _U_, guint curr_offset = offset; - proto_tree_add_item(tree, hf_gsm_a_rp_rp_message_reference, tvb, curr_offset, 1, ENC_NA); + proto_tree_add_item(tree, hf_gsm_a_rp_rp_message_reference, tvb, curr_offset, 1, ENC_BIG_ENDIAN); curr_offset++; @@ -213,7 +213,7 @@ de_rp_cause(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo _U_, guint32 off oct = tvb_get_guint8(tvb, curr_offset); proto_tree_add_item(tree, hf_gsm_a_rp_extension, tvb, curr_offset, 1, ENC_NA); - proto_tree_add_item(tree, hf_gsm_a_rp_cause, tvb, curr_offset, 1, ENC_NA); + proto_tree_add_item(tree, hf_gsm_a_rp_cause, tvb, curr_offset, 1, ENC_BIG_ENDIAN); curr_offset++; diff --git a/epan/dissectors/packet-hci_mon.c b/epan/dissectors/packet-hci_mon.c index b8ecdf4d1a..77fb7de8a8 100644 --- a/epan/dissectors/packet-hci_mon.c +++ b/epan/dissectors/packet-hci_mon.c @@ -211,10 +211,10 @@ dissect_hci_mon(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data switch(opcode) { case 0x00: /* New Index */ - proto_tree_add_item(hci_mon_tree, hf_bus, tvb, offset, 1, ENC_NA); + proto_tree_add_item(hci_mon_tree, hf_bus, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; - proto_tree_add_item(hci_mon_tree, hf_type, tvb, offset, 1, ENC_NA); + proto_tree_add_item(hci_mon_tree, hf_type, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; offset = dissect_bd_addr(hf_bd_addr, hci_mon_tree, tvb, offset); diff --git a/epan/dissectors/packet-ieee80211-airopeek.c b/epan/dissectors/packet-ieee80211-airopeek.c index 8258683ec2..21314b3c04 100644 --- a/epan/dissectors/packet-ieee80211-airopeek.c +++ b/epan/dissectors/packet-ieee80211-airopeek.c @@ -72,7 +72,7 @@ dissect_airopeek(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) } if (tree) - proto_tree_add_item(airopeek_tree, hf_channel, tvb, 1, 1, ENC_NA); + proto_tree_add_item(airopeek_tree, hf_channel, tvb, 1, 1, ENC_BIG_ENDIAN); signal_level = tvb_get_guint8(tvb, 2); /* diff --git a/epan/dissectors/packet-llc.c b/epan/dissectors/packet-llc.c index 2246af9331..08e72e8e20 100644 --- a/epan/dissectors/packet-llc.c +++ b/epan/dissectors/packet-llc.c @@ -448,15 +448,15 @@ dissect_llc(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) ti = proto_tree_add_item(tree, proto_llc, tvb, 0, -1, ENC_NA); llc_tree = proto_item_add_subtree(ti, ett_llc); - sap_item = proto_tree_add_item(llc_tree, hf_llc_dsap, tvb, 0, 1, ENC_NA); + sap_item = proto_tree_add_item(llc_tree, hf_llc_dsap, tvb, 0, 1, ENC_BIG_ENDIAN); field_tree = proto_item_add_subtree(sap_item, ett_llc_dsap); - proto_tree_add_item(field_tree, hf_llc_dsap_sap, tvb, 0, 1, ENC_NA); + proto_tree_add_item(field_tree, hf_llc_dsap_sap, tvb, 0, 1, ENC_BIG_ENDIAN); proto_tree_add_item(field_tree, hf_llc_dsap_ig, tvb, 0, 1, ENC_NA); ssap = tvb_get_guint8(tvb, 1); - sap_item = proto_tree_add_item(llc_tree, hf_llc_ssap, tvb, 1, 1, ENC_NA); + sap_item = proto_tree_add_item(llc_tree, hf_llc_ssap, tvb, 1, 1, ENC_BIG_ENDIAN); field_tree = proto_item_add_subtree(sap_item, ett_llc_ssap); - proto_tree_add_item(field_tree, hf_llc_ssap_sap, tvb, 1, 1, ENC_NA); + proto_tree_add_item(field_tree, hf_llc_ssap_sap, tvb, 1, 1, ENC_BIG_ENDIAN); proto_tree_add_item(field_tree, hf_llc_ssap_cr, tvb, 1, 1, ENC_NA); is_snap = (dsap == SAP_SNAP) && (ssap == SAP_SNAP); diff --git a/epan/dissectors/packet-lpd.c b/epan/dissectors/packet-lpd.c index 290aa56f1d..8168468d3e 100644 --- a/epan/dissectors/packet-lpd.c +++ b/epan/dissectors/packet-lpd.c @@ -128,7 +128,7 @@ dissect_lpd(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) } else if (lpr_packet_type == response) { if (code <= 3) { - proto_tree_add_item(lpd_tree, hf_lpd_response_code, tvb, 0, 1, ENC_NA); + proto_tree_add_item(lpd_tree, hf_lpd_response_code, tvb, 0, 1, ENC_BIG_ENDIAN); } else { call_dissector(data_handle,tvb, pinfo, lpd_tree); diff --git a/epan/dissectors/packet-pw-hdlc.c b/epan/dissectors/packet-pw-hdlc.c index e5d90724dd..b8d2396356 100644 --- a/epan/dissectors/packet-pw-hdlc.c +++ b/epan/dissectors/packet-pw-hdlc.c @@ -108,8 +108,8 @@ static int dissect_pw_hdlc_nocw_hdlc_ppp( tvbuff_t * tvb, packet_info * pinfo, p tr = proto_item_add_subtree( item, ett_pw_hdlc ); - item_address = proto_tree_add_item( tr, hf_pw_hdlc_address_field, tvb, 0, 1, ENC_NA ); - item_control = proto_tree_add_item( tr, hf_pw_hdlc_control_field, tvb, 1, 1, ENC_NA ); + item_address = proto_tree_add_item( tr, hf_pw_hdlc_address_field, tvb, 0, 1, ENC_BIG_ENDIAN ); + item_control = proto_tree_add_item( tr, hf_pw_hdlc_control_field, tvb, 1, 1, ENC_BIG_ENDIAN ); tr = proto_item_add_subtree( item_address, ett_pw_hdlc ); diff --git a/epan/dissectors/packet-rtpproxy.c b/epan/dissectors/packet-rtpproxy.c index fa05af9f71..6552df4a4e 100644 --- a/epan/dissectors/packet-rtpproxy.c +++ b/epan/dissectors/packet-rtpproxy.c @@ -314,7 +314,7 @@ rtpproxy_add_parameter(tvbuff_t *tvb, packet_info *pinfo, proto_tree *rtpproxy_t rawstr = tvb_get_string_enc(wmem_packet_scope(), tvb, begin, realsize, ENC_ASCII); while(offset < realsize){ - ti = proto_tree_add_item(rtpproxy_tree, hf_rtpproxy_command_parameter, tvb, begin + offset, 1, ENC_NA); + ti = proto_tree_add_item(rtpproxy_tree, hf_rtpproxy_command_parameter, tvb, begin + offset, 1, ENC_BIG_ENDIAN); offset++; /* Skip 1-byte parameter's type */ switch (g_ascii_tolower(tvb_get_guint8(tvb, begin+offset-1))) { @@ -381,7 +381,7 @@ rtpproxy_add_parameter(tvbuff_t *tvb, packet_info *pinfo, proto_tree *rtpproxy_t break; case 'p': another_tree = proto_item_add_subtree(ti, ett_rtpproxy_command_parameters_proto); - proto_tree_add_item(another_tree, hf_rtpproxy_command_parameter_proto, tvb, begin+offset, 1, ENC_NA); + proto_tree_add_item(another_tree, hf_rtpproxy_command_parameter_proto, tvb, begin+offset, 1, ENC_BIG_ENDIAN); offset++; break; case 't': @@ -394,7 +394,7 @@ rtpproxy_add_parameter(tvbuff_t *tvb, packet_info *pinfo, proto_tree *rtpproxy_t break; case 'v': another_tree = proto_item_add_subtree(ti, ett_rtpproxy_command_parameters_acc); - proto_tree_add_item(another_tree, hf_rtpproxy_command_parameter_acc, tvb, begin+offset, 1, ENC_NA); + proto_tree_add_item(another_tree, hf_rtpproxy_command_parameter_acc, tvb, begin+offset, 1, ENC_BIG_ENDIAN); offset++; break; default: @@ -614,7 +614,7 @@ dissect_rtpproxy(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data } /* All other commands */ - ti = proto_tree_add_item(rtpproxy_tree, hf_rtpproxy_command, tvb, offset, 1, ENC_NA); + ti = proto_tree_add_item(rtpproxy_tree, hf_rtpproxy_command, tvb, offset, 1, ENC_BIG_ENDIAN); /* A specific case - handshake/ping */ if (tmp == 'v') diff --git a/epan/dissectors/packet-slowprotocols.c b/epan/dissectors/packet-slowprotocols.c index 3a48868856..16837d165f 100644 --- a/epan/dissectors/packet-slowprotocols.c +++ b/epan/dissectors/packet-slowprotocols.c @@ -95,7 +95,7 @@ dissect_slow_protocols(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) pdu_tree = proto_item_add_subtree(pdu_item, ett_slow); /* Subtype */ - proto_tree_add_item(pdu_tree, hf_slow_subtype, tvb, 0, 1, ENC_NA); + proto_tree_add_item(pdu_tree, hf_slow_subtype, tvb, 0, 1, ENC_BIG_ENDIAN); } next_tvb = tvb_new_subset_remaining(tvb, 1); diff --git a/epan/dissectors/packet-snaeth.c b/epan/dissectors/packet-snaeth.c index 64ae2179e7..5fa81756e3 100644 --- a/epan/dissectors/packet-snaeth.c +++ b/epan/dissectors/packet-snaeth.c @@ -61,7 +61,7 @@ dissect_snaeth(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) ENC_NA); snaeth_tree = proto_item_add_subtree(snaeth_ti, ett_snaeth); proto_tree_add_uint(snaeth_tree, hf_snaeth_len, tvb, 0, 2, len); - proto_tree_add_item(snaeth_tree, hf_snaeth_padding, tvb, 2, 1, ENC_NA); + proto_tree_add_item(snaeth_tree, hf_snaeth_padding, tvb, 2, 1, ENC_BIG_ENDIAN); } /* diff --git a/epan/dissectors/packet-t30.c b/epan/dissectors/packet-t30.c index ea4a057e49..5583ee918f 100644 --- a/epan/dissectors/packet-t30.c +++ b/epan/dissectors/packet-t30.c @@ -564,7 +564,7 @@ dissect_t30_non_standard_cap(tvbuff_t *tvb, int offset, packet_info *pinfo, int return; } - proto_tree_add_item(tree, hf_t30_fif_country_code, tvb, offset, 1, ENC_NA); + proto_tree_add_item(tree, hf_t30_fif_country_code, tvb, offset, 1, ENC_BIG_ENDIAN); offset++; proto_tree_add_item(tree, hf_t30_fif_non_stand_bytes, tvb, offset, len-1, ENC_NA); @@ -583,7 +583,7 @@ dissect_t30_partial_page_signal(tvbuff_t *tvb, int offset, packet_info *pinfo, i return; } - proto_tree_add_item(tree, hf_t30_partial_page_fcf2, tvb, offset, 1, ENC_NA); + proto_tree_add_item(tree, hf_t30_partial_page_fcf2, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; octet = tvb_get_guint8(tvb, offset); @@ -678,7 +678,7 @@ dissect_t30_dis_dtc(tvbuff_t *tvb, int offset, packet_info *pinfo, int len, prot proto_tree_add_item(tree, hf_t30_fif_rtfc, tvb, offset, 1, ENC_NA); proto_tree_add_item(tree, hf_t30_fif_rfo, tvb, offset, 1, ENC_NA); if (dis_dtc) { - proto_tree_add_item(tree, hf_t30_fif_dsr, tvb, offset, 1, ENC_NA); + proto_tree_add_item(tree, hf_t30_fif_dsr, tvb, offset, 1, ENC_BIG_ENDIAN); col_append_fstr(pinfo->cinfo, COL_INFO, " - DSR:%s", val_to_str_ext_const((octet&0x3C) >> 2, &t30_data_signalling_rate_vals_ext, "<unknown>")); @@ -689,7 +689,7 @@ dissect_t30_dis_dtc(tvbuff_t *tvb, int offset, packet_info *pinfo, int len, prot val_to_str_ext_const((octet&0x3C) >> 2, &t30_data_signalling_rate_vals_ext, "<unknown>")); } else { - proto_tree_add_item(tree, hf_t30_fif_dsr_dcs, tvb, offset, 1, ENC_NA); + proto_tree_add_item(tree, hf_t30_fif_dsr_dcs, tvb, offset, 1, ENC_BIG_ENDIAN); col_append_fstr(pinfo->cinfo, COL_INFO, " - DSR:%s", val_to_str_ext_const((octet&0x3C) >> 2, &t30_data_signalling_rate_dcs_vals_ext, "<unknown>")); @@ -707,13 +707,13 @@ dissect_t30_dis_dtc(tvbuff_t *tvb, int offset, packet_info *pinfo, int len, prot octet = tvb_get_guint8(tvb, offset); if (dis_dtc) { - proto_tree_add_item(tree, hf_t30_fif_rwc, tvb, offset, 1, ENC_NA); - proto_tree_add_item(tree, hf_t30_fif_rlc, tvb, offset, 1, ENC_NA); - proto_tree_add_item(tree, hf_t30_fif_msltcr, tvb, offset, 1, ENC_NA); + proto_tree_add_item(tree, hf_t30_fif_rwc, tvb, offset, 1, ENC_BIG_ENDIAN); + proto_tree_add_item(tree, hf_t30_fif_rlc, tvb, offset, 1, ENC_BIG_ENDIAN); + proto_tree_add_item(tree, hf_t30_fif_msltcr, tvb, offset, 1, ENC_BIG_ENDIAN); } else { - proto_tree_add_item(tree, hf_t30_fif_rw_dcs, tvb, offset, 1, ENC_NA); - proto_tree_add_item(tree, hf_t30_fif_rl_dcs, tvb, offset, 1, ENC_NA); - proto_tree_add_item(tree, hf_t30_fif_mslt_dcs, tvb, offset, 1, ENC_NA); + proto_tree_add_item(tree, hf_t30_fif_rw_dcs, tvb, offset, 1, ENC_BIG_ENDIAN); + proto_tree_add_item(tree, hf_t30_fif_rl_dcs, tvb, offset, 1, ENC_BIG_ENDIAN); + proto_tree_add_item(tree, hf_t30_fif_mslt_dcs, tvb, offset, 1, ENC_BIG_ENDIAN); } proto_tree_add_item(tree, hf_t30_fif_ext, tvb, offset, 1, ENC_NA); @@ -910,7 +910,7 @@ dissect_t30_dis_dtc(tvbuff_t *tvb, int offset, packet_info *pinfo, int len, prot if (dis_dtc) proto_tree_add_item(tree, hf_t30_fif_bwmrcp, tvb, offset, 1, ENC_NA); proto_tree_add_item(tree, hf_t30_fif_t45, tvb, offset, 1, ENC_NA); - proto_tree_add_item(tree, hf_t30_fif_sdmc, tvb, offset, 1, ENC_NA); + proto_tree_add_item(tree, hf_t30_fif_sdmc, tvb, offset, 1, ENC_BIG_ENDIAN); proto_tree_add_item(tree, hf_t30_fif_ext, tvb, offset, 1, ENC_NA); if ( !(octet & 0x01) ) @@ -945,19 +945,19 @@ dissect_t30_hdlc(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data tr=proto_item_add_subtree(it, ett_t30); octet = tvb_get_guint8(tvb, offset); - item = proto_tree_add_item(tr, hf_t30_Address, tvb, offset, 1, ENC_NA); + item = proto_tree_add_item(tr, hf_t30_Address, tvb, offset, 1, ENC_BIG_ENDIAN); if (octet != 0xFF) expert_add_info(pinfo, item, &ei_t30_Address_FF); offset += 1; octet = tvb_get_guint8(tvb, offset); - item = proto_tree_add_item(tr, hf_t30_Control, tvb, offset, 1, ENC_NA); + item = proto_tree_add_item(tr, hf_t30_Control, tvb, offset, 1, ENC_BIG_ENDIAN); if ((octet != 0xC0) && (octet != 0xC8)) expert_add_info(pinfo, item, &ei_t30_Control_C0C8); offset += 1; octet = tvb_get_guint8(tvb, offset); - it_fcf = proto_tree_add_item(tr, hf_t30_Facsimile_Control, tvb, offset, 1, ENC_NA); + it_fcf = proto_tree_add_item(tr, hf_t30_Facsimile_Control, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; tr_fif = proto_item_add_subtree(it_fcf, ett_t30_fif); diff --git a/epan/dissectors/packet-vssmonitoring.c b/epan/dissectors/packet-vssmonitoring.c index 46f65da795..6679785d13 100644 --- a/epan/dissectors/packet-vssmonitoring.c +++ b/epan/dissectors/packet-vssmonitoring.c @@ -183,12 +183,12 @@ dissect_vssmonitoring(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void if ( trailer_len & 1) { vssmonitoring_srcport = (guint16)tvb_get_guint8(tvb, offset); if (tree) - proto_tree_add_item(vssmonitoring_tree, hf_vssmonitoring_srcport, tvb, offset, 1, ENC_NA); + proto_tree_add_item(vssmonitoring_tree, hf_vssmonitoring_srcport, tvb, offset, 1, ENC_BIG_ENDIAN); offset++; } else if ( trailer_len & 2) { vssmonitoring_srcport = tvb_get_ntohs(tvb, offset); if (tree) - proto_tree_add_item(vssmonitoring_tree, hf_vssmonitoring_srcport, tvb, offset, 2, ENC_NA); + proto_tree_add_item(vssmonitoring_tree, hf_vssmonitoring_srcport, tvb, offset, 2, ENC_BIG_ENDIAN); offset += 2; } if (tree) @@ -214,7 +214,7 @@ proto_register_vssmonitoring(void) { &hf_vssmonitoring_srcport, { "Src Port", "vssmonitoring.srcport", - FT_UINT8, BASE_DEC, NULL, 0x0, + FT_UINT16, BASE_DEC, NULL, 0x0, "VSS-Monitoring Source Port", HFILL }} }; |